264721 2023-11-12 22:12:46 -0800 [MSE] SourceBuffer incorrectly emits error when timestamps are negative 2023-11-13 02:54:05 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jean-yves.avenard jean-yves.avenard webkit-bug-importer oldest_to_newest 1992023 0 jean-yves.avenard 2023-11-12 22:12:46 -0800 In SourceBufferPrivate we can read: ``` // If the decode timestamp is less than the presentation start time, then run the end of stream // algorithm with the error parameter set to "decode", and abort these steps. // NOTE: Until <https://www.w3.org/Bugs/Public/show_bug.cgi?id=27487> is resolved, we will only check // the presentation timestamp. ``` This isn't in the spec. The bug linked to referred to https://dvcs.w3.org/hg/html-media/rev/cb96bc1c87c3 in 2014 which drops the requirement. The was dead code anyway, as the steps prior are about dropping frames that are outside the WindowAppend range, so "If the decode timestamp is less than the presentation start time" will always be false. This allows to drop the sourceBufferPrivateStreamEndedWithDecodeError callback. [1] https://searchfox.org/wubkat/rev/6e975c79b0d4766d80b0421a6dedeae64ca84b63/Source/WebCore/platform/graphics/SourceBufferPrivate.cpp#1020-1029 1992024 1 webkit-bug-importer 2023-11-12 22:16:31 -0800 <rdar://problem/118315768> 1992025 2 jean-yves.avenard 2023-11-12 22:20:51 -0800 Pull request: https://github.com/WebKit/WebKit/pull/20401 1992074 3 ews-feeder 2023-11-13 02:54:03 -0800 Committed 270631@main (711b192dda30): <https://commits.webkit.org/270631@main> Reviewed commits have been landed. Closing PR #20401 and removing active labels.