26437 2009-06-16 01:27:27 -0700 commit-log-editor should match ambient line endings 2009-06-16 11:19:54 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth abarth abarth darin fishd oldest_to_newest 126170 0 abarth 2009-06-16 01:27:27 -0700 Let's see where this trail of tears leads. Currently, the commit-log-editor dumps the ChangeLog into the commit message without regard to line endings (which might not match in these two cases). It should be smarter and match the line endings that are already in the commit message. Patch forthcoming. 126171 1 31341 abarth 2009-06-16 01:27:55 -0700 Created attachment 31341 patch 126172 2 31342 abarth 2009-06-16 01:30:13 -0700 Created attachment 31342 patch slight improvement 126218 3 levin 2009-06-16 10:17:48 -0700 Assigned to Adam for landing. 126239 4 abarth 2009-06-16 11:19:54 -0700 Sending WebKitTools/ChangeLog Sending WebKitTools/Scripts/commit-log-editor Transmitting file data .. Committed revision 44727. 31341 2009-06-16 01:27:55 -0700 2009-06-16 01:30:13 -0700 patch edit-cl.patch text/plain 2145 abarth SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ0NzE3KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDYtMTYgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBNYWtlIHRoZSBjb21taXQtbG9nLWVkaXRvciBtYXRjaCB0aGUgYW1iaWVudCBsaW5l IGVuZGluZ3MgaW4gY29tbWl0CisgICAgICAgIG1lc3NhZ2VzLgorCisgICAgICAgICogU2NyaXB0 cy9jb21taXQtbG9nLWVkaXRvcjoKKwogMjAwOS0wNi0xNiAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3 ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2Vi S2l0VG9vbHMvU2NyaXB0cy9jb21taXQtbG9nLWVkaXRvcgo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRU b29scy9TY3JpcHRzL2NvbW1pdC1sb2ctZWRpdG9yCShyZXZpc2lvbiA0NDcxNSkKKysrIFdlYktp dFRvb2xzL1NjcmlwdHMvY29tbWl0LWxvZy1lZGl0b3IJKHdvcmtpbmcgY29weSkKQEAgLTM2LDYg KzM2LDggQEAgdXNlIGxpYiAkRmluZEJpbjo6QmluOwogdXNlIFZDU1V0aWxzOwogdXNlIHdlYmtp dGRpcnM7CiAKK3N1YiBub3JtYWxpemVMaW5lRW5kaW5ncygkJCk7CisKIG15ICRsb2cgPSAkQVJH VlswXTsKIAogbXkgJGJhc2VEaXIgPSBiYXNlUHJvZHVjdERpcigpOwpAQCAtODEsNiArODMsMTMg QEAgd2hpbGUgKDxMT0c+KSB7CiB9CiBjbG9zZSBMT0c7CiAKKyMgV2Ugd2FudCB0byBtYXRjaCB0 aGUgbGluZSBlbmRpbmdzIG9mIHRoZSBleGlzdGluZyBsb2cgZmlsZSBpbiBjYXNlIHRoZXkncmUK KyMgZGlmZmVyZW50IGZyb20gcGVybCdzIGxpbmUgZW5kaW5ncy4KK215ICRlbmRsID0gIlxuIjsK K2lmICgkbG9nQ29udGVudHMgPX4gLyhccj9cbikvKSB7CisgICAgJGVuZGwgPSAkMTsKK30KKwog IyBEb24ndCBjaGFuZ2UgYW55dGhpbmcgaWYgdGhlcmUncyBhbHJlYWR5IGEgbG9nIG1lc3NhZ2UK ICMgKGFzIGNhbiBoYXBwZW4gd2l0aCBnaXQtY29tbWl0IC0tYW1lbmQpCiBleGVjICRlZGl0b3Is IEBBUkdWIGlmICRleGlzdGluZ0xvZzsKQEAgLTEzNCwxMSArMTQzLDExIEBAIG9wZW4gTkVXTE9H LCAiPiRsb2cuZWRpdCIgb3IgZGllOwogZm9yIG15ICRzb3J0S2V5IChzb3J0IGtleXMgJWNoYW5n ZUxvZ1NvcnQpIHsKICAgICBteSAkbGFiZWwgPSAkY2hhbmdlTG9nU29ydHskc29ydEtleX07CiAg ICAgaWYgKGtleXMgJWNoYW5nZUxvZ1NvcnQgPiAxKSB7Ci0gICAgICAgIHByaW50IE5FV0xPRyAi XG4iIGlmICEkZmlyc3Q7CisgICAgICAgIHByaW50IE5FV0xPRyBub3JtYWxpemVMaW5lRW5kaW5n cygiXG4iLCAkZW5kbCkgaWYgISRmaXJzdDsKICAgICAgICAgJGZpcnN0ID0gMDsKLSAgICAgICAg cHJpbnQgTkVXTE9HICIkbGFiZWw6XG5cbiI7CisgICAgICAgIHByaW50IE5FV0xPRyBub3JtYWxp emVMaW5lRW5kaW5ncygiJGxhYmVsOlxuXG4iLCAkZW5kbCk7CiAgICAgfQotICAgIHByaW50IE5F V0xPRyAkY2hhbmdlTG9nQ29udGVudHN7JGxhYmVsfTsKKyAgICBwcmludCBORVdMT0cgbm9ybWFs aXplTGluZUVuZGluZ3MoJGNoYW5nZUxvZ0NvbnRlbnRzeyRsYWJlbH0sICRlbmRsKTsKIH0KIHBy aW50IE5FV0xPRyAkbG9nQ29udGVudHM7CiBjbG9zZSBORVdMT0c7CkBAIC0xODcsMyArMTk2LDEw IEBAIHN1YiB0b3BMZXZlbFNvdXJjZURpcmVjdG9yeQogICAgICAgICByZXR1cm4gRmlsZTo6U3Bl Yy0+cmVsMmFicyhGaWxlOjpTcGVjLT5jYXRkaXIobWFwIHsgIi4uIiB9IEZpbGU6OlNwZWMtPnNw bGl0ZGlyKCRwYXRoKSkpOwogICAgIH0KIH0KKworc3ViIG5vcm1hbGl6ZUxpbmVFbmRpbmdzKCQk KQoreworICAgIG15ICgkc3RyaW5nLCAkZW5kbCkgPSBAXzsKKyAgICAkc3RyaW5nID1+IHMvXHI/ XG4vJGVuZGwvZzsKKyAgICByZXR1cm4gJHN0cmluZzsKK30K 31342 2009-06-16 01:30:13 -0700 2009-06-16 09:43:13 -0700 patch edit-cl.patch text/plain 2146 abarth SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ0NzE3KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDYtMTYgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBNYWtlIHRoZSBjb21taXQtbG9nLWVkaXRvciBtYXRjaCB0aGUgYW1iaWVudCBsaW5l IGVuZGluZ3MgaW4gY29tbWl0CisgICAgICAgIG1lc3NhZ2VzLgorCisgICAgICAgICogU2NyaXB0 cy9jb21taXQtbG9nLWVkaXRvcjoKKwogMjAwOS0wNi0xNiAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3 ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2Vi S2l0VG9vbHMvU2NyaXB0cy9jb21taXQtbG9nLWVkaXRvcgo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRU b29scy9TY3JpcHRzL2NvbW1pdC1sb2ctZWRpdG9yCShyZXZpc2lvbiA0NDcxNSkKKysrIFdlYktp dFRvb2xzL1NjcmlwdHMvY29tbWl0LWxvZy1lZGl0b3IJKHdvcmtpbmcgY29weSkKQEAgLTM2LDYg KzM2LDggQEAgdXNlIGxpYiAkRmluZEJpbjo6QmluOwogdXNlIFZDU1V0aWxzOwogdXNlIHdlYmtp dGRpcnM7CiAKK3N1YiBub3JtYWxpemVMaW5lRW5kaW5ncygkJCk7CisKIG15ICRsb2cgPSAkQVJH VlswXTsKIAogbXkgJGJhc2VEaXIgPSBiYXNlUHJvZHVjdERpcigpOwpAQCAtODEsNiArODMsMTMg QEAgd2hpbGUgKDxMT0c+KSB7CiB9CiBjbG9zZSBMT0c7CiAKKyMgV2Ugd2FudCB0byBtYXRjaCB0 aGUgbGluZSBlbmRpbmdzIG9mIHRoZSBleGlzdGluZyBsb2cgZmlsZSBpbiBjYXNlIHRoZXkncmUK KyMgZGlmZmVyZW50IGZyb20gcGVybCdzIGxpbmUgZW5kaW5ncy4KK215ICRlbmRsID0gIlxuIjsK K2lmICgkbG9nQ29udGVudHMgPX4gLyhccj9cbikvZykgeworICAgICRlbmRsID0gJDE7Cit9CisK ICMgRG9uJ3QgY2hhbmdlIGFueXRoaW5nIGlmIHRoZXJlJ3MgYWxyZWFkeSBhIGxvZyBtZXNzYWdl CiAjIChhcyBjYW4gaGFwcGVuIHdpdGggZ2l0LWNvbW1pdCAtLWFtZW5kKQogZXhlYyAkZWRpdG9y LCBAQVJHViBpZiAkZXhpc3RpbmdMb2c7CkBAIC0xMzQsMTEgKzE0MywxMSBAQCBvcGVuIE5FV0xP RywgIj4kbG9nLmVkaXQiIG9yIGRpZTsKIGZvciBteSAkc29ydEtleSAoc29ydCBrZXlzICVjaGFu Z2VMb2dTb3J0KSB7CiAgICAgbXkgJGxhYmVsID0gJGNoYW5nZUxvZ1NvcnR7JHNvcnRLZXl9Owog ICAgIGlmIChrZXlzICVjaGFuZ2VMb2dTb3J0ID4gMSkgewotICAgICAgICBwcmludCBORVdMT0cg IlxuIiBpZiAhJGZpcnN0OworICAgICAgICBwcmludCBORVdMT0cgbm9ybWFsaXplTGluZUVuZGlu Z3MoIlxuIiwgJGVuZGwpIGlmICEkZmlyc3Q7CiAgICAgICAgICRmaXJzdCA9IDA7Ci0gICAgICAg IHByaW50IE5FV0xPRyAiJGxhYmVsOlxuXG4iOworICAgICAgICBwcmludCBORVdMT0cgbm9ybWFs aXplTGluZUVuZGluZ3MoIiRsYWJlbDpcblxuIiwgJGVuZGwpOwogICAgIH0KLSAgICBwcmludCBO RVdMT0cgJGNoYW5nZUxvZ0NvbnRlbnRzeyRsYWJlbH07CisgICAgcHJpbnQgTkVXTE9HIG5vcm1h bGl6ZUxpbmVFbmRpbmdzKCRjaGFuZ2VMb2dDb250ZW50c3skbGFiZWx9LCAkZW5kbCk7CiB9CiBw cmludCBORVdMT0cgJGxvZ0NvbnRlbnRzOwogY2xvc2UgTkVXTE9HOwpAQCAtMTg3LDMgKzE5Niwx MCBAQCBzdWIgdG9wTGV2ZWxTb3VyY2VEaXJlY3RvcnkKICAgICAgICAgcmV0dXJuIEZpbGU6OlNw ZWMtPnJlbDJhYnMoRmlsZTo6U3BlYy0+Y2F0ZGlyKG1hcCB7ICIuLiIgfSBGaWxlOjpTcGVjLT5z cGxpdGRpcigkcGF0aCkpKTsKICAgICB9CiB9CisKK3N1YiBub3JtYWxpemVMaW5lRW5kaW5ncygk JCkKK3sKKyAgICBteSAoJHN0cmluZywgJGVuZGwpID0gQF87CisgICAgJHN0cmluZyA9fiBzL1xy P1xuLyRlbmRsL2c7CisgICAgcmV0dXJuICRzdHJpbmc7Cit9Cg==