26436 2009-06-16 00:48:27 -0700 Chromium's canvas forgets its context after fillText 2009-06-25 13:36:26 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows Vista RESOLVED FIXED https://bugs.webkit.org/attachment.cgi?id=31339 P2 Normal --- 0 hamaji levin hamaji oldest_to_newest 126166 0 hamaji 2009-06-16 00:48:27 -0700 Chromium's canvas on Windows restore its context after fillText. This doesn't happen with Safari and linux chrome. I think this is the bug of glue code. I'll upload a patch. Related chromium bug: http://code.google.com/p/chromium/issues/detail?id=14065 126167 1 31339 hamaji 2009-06-16 00:49:18 -0700 Created attachment 31339 test case 126169 2 31340 hamaji 2009-06-16 01:00:16 -0700 Created attachment 31340 Patch v1 LayoutTests/ChangeLog | 17 +++++++ .../fast/canvas/resources/translate-text.js | 46 ++++++++++++++++++++ .../fast/canvas/translate-text-expected.txt | 10 ++++ LayoutTests/fast/canvas/translate-text.html | 13 ++++++ WebCore/ChangeLog | 15 ++++++ .../platform/graphics/chromium/TransparencyWin.cpp | 1 + 6 files changed, 102 insertions(+), 0 deletions(-) 128212 3 levin 2009-06-25 10:32:36 -0700 Assign to levin for landing. 128253 4 levin 2009-06-25 13:36:26 -0700 Committed as http://trac.webkit.org/changeset/45188. 31339 2009-06-16 00:49:18 -0700 2009-06-16 00:49:18 -0700 test case filltext.html text/html 387 hamaji PGhlYWQ+CjxzY3JpcHQ+CmZ1bmN0aW9uIGxvYWQoKSB7CiAgY2FudmFzID0gZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoImMiKTsKICBjeCA9IGNhbnZhcy5nZXRDb250ZXh0KCcyZCcpOwogIGN4LnRy YW5zbGF0ZSgwLCA1MCk7CiAgY3guZm9udCA9ICIxMHB0IEFyaWFsIgogIGN4LmZpbGxUZXh0KCJU aGlzIHRleHQgbXVzdCBub3QgYmUgc2VlbiIsIDIwLCAyMCk7CiAgLy8gVGhlIHRleHQgYWJvdmUg c2hvdWxkIGJlIG92ZXJ3cml0dGVuLgogIGN4LmZpbGxSZWN0KDAsIDAsIDUwMCwgNTApOwp9Cjwv c2NyaXB0Pgo8L2hlYWQ+Cjxib2R5IG9ubG9hZD0ibG9hZCgpOyI+CjxjYW52YXMgaWQ9ImMiIHdp ZHRoPSI1MDBweCIgaGVpZ2h0PSI1MDBweCI+PC9jYW52YXM+CjwvYm9keT4K 31340 2009-06-16 01:00:16 -0700 2009-06-18 09:30:32 -0700 Patch v1 Patch-v1.patch text/plain 5367 hamaji MzhmZWJhNDdjMmIzYjhjNzRmNjBmZjNmYTkzZjNiOTcyYTA1ZjMyOQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGJmMGI1Y2Eu LjRmOGE5OTcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAwOS0wNi0xNiAgU2hpbmljaGlybyBI YW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yNjQzNgorCisgICAgICAgIFdpbmRvd3MgQ2hyb21pdW0gYnVnIGZpeDogc2F2ZSBjb250 ZXh0IG9mIGRlc3RpbmF0aW9uIGNhbnZhcyBpbgorICAgICAgICBUcmFuc3BhcmVuY3lXaW46OmNv bXBvc2l0ZVRleHRDb21wb3NpdGUoKSBiZWZvcmUgdGhlIGZ1bmN0aW9uCisgICAgICAgIG1vZGlm aWVzIHRoZSBjb250ZXh0LgorCisgICAgICAgICogZmFzdC9jYW52YXMvcmVzb3VyY2VzL3RyYW5z bGF0ZS10ZXh0LmpzOiBBZGRlZC4KKyAgICAgICAgKGRlc2NyaXB0aW9uLnBpeGVsVmFsdWVBdCk6 CisgICAgICAgIChwaXhlbFRvU3RyaW5nKToKKyAgICAgICAgKHBpeGVsU2hvdWxkQmUpOgorICAg ICAgICAqIGZhc3QvY2FudmFzL3RyYW5zbGF0ZS10ZXh0LWV4cGVjdGVkLnR4dDogQWRkZWQuCisg ICAgICAgICogZmFzdC9jYW52YXMvdHJhbnNsYXRlLXRleHQuaHRtbDogQWRkZWQuCisKIDIwMDkt MDYtMTUgIENocmlzIE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+LgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvcmVzb3VyY2VzL3RyYW5zbGF0ZS10ZXh0LmpzIGIv TGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvcmVzb3VyY2VzL3RyYW5zbGF0ZS10ZXh0LmpzCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjRhZGU4MzEKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9yZXNvdXJjZXMvdHJhbnNsYXRlLXRleHQuanMKQEAg LTAsMCArMSw0NiBAQAorZGVzY3JpcHRpb24oIlRlc3QgZm9yIGNocm9taXVtJ3MgY2FudmFzIGJ1 ZyB3aGVyZSBmaWxsVGV4dCByZXNldHMgdGhlIGN1cnJlbnQgY29udGV4dCBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjY0MzYgLiBZb3UgbXVzdCBzZWUgZ3JlZW4gYm94 IHdpdGggbWVzc2FnZSAnVGhpcyB0ZXh0IHNob3VsZCBiZSBzZWVuJywgYW5kIGJsYWNrIGJveCBi ZWxvdyB0aGUgZ3JlZW4gYm94LiIpCisKK2Z1bmN0aW9uIHBpeGVsVmFsdWVBdChjb250ZXh0LCB4 LCB5KSB7CisgICAgdmFyIGltYWdlRGF0YSA9IGNvbnRleHQuZ2V0SW1hZ2VEYXRhKHgsIHksIDEs IDEpOworICAgIHJldHVybiBpbWFnZURhdGEuZGF0YTsKK30KKworZnVuY3Rpb24gcGl4ZWxUb1N0 cmluZyhwKSB7CisgICAgcmV0dXJuICJbIiArIHBbMF0gKyAiLCAiICsgcFsxXSArICIsICIgKyBw WzJdICsgIiwgIiArIHBbM10gKyAiXSIKK30KKworZnVuY3Rpb24gcGl4ZWxTaG91bGRCZShjb250 ZXh0LCB4LCB5LCBleHBlY3RlZFBpeGVsU3RyaW5nKSB7CisgICAgdmFyIHBpeGVsID0gcGl4ZWxW YWx1ZUF0KGNvbnRleHQsIHgsIHkpOworICAgIHZhciBleHBlY3RlZFBpeGVsID0gZXZhbChleHBl Y3RlZFBpeGVsU3RyaW5nKTsKKworICAgIHZhciBwaXhlbFN0cmluZyA9ICJwaXhlbCAiICsgeCAr ICIsICIgKyB5OworICAgIGlmIChhcmVBcnJheXNFcXVhbChwaXhlbCwgZXhwZWN0ZWRQaXhlbCkp IHsKKyAgICAgICAgdGVzdFBhc3NlZChwaXhlbFN0cmluZyArICIgaXMgIiArIHBpeGVsVG9TdHJp bmcocGl4ZWwpKTsKKyAgICB9IGVsc2UgeworICAgICAgICB0ZXN0RmFpbGVkKHBpeGVsU3RyaW5n ICsgIiBzaG91bGQgYmUgIiArIHBpeGVsVG9TdHJpbmcoZXhwZWN0ZWRQaXhlbCkgKyAiIHdhcyAi ICsgcGl4ZWxUb1N0cmluZyhwaXhlbCkpOworICAgIH0KK30KKwordmFyIGNhbnZhcyA9IGRvY3Vt ZW50LmNyZWF0ZUVsZW1lbnQoImNhbnZhcyIpOworY2FudmFzLmhlaWdodCA9IDEwMDsKK2NhbnZh cy53aWR0aCA9IDUwMDsKK2NhbnZhcy5zdHlsZS5oZWlnaHQgPSAiMTAwIjsKK2NhbnZhcy5zdHls ZS53aWR0aCA9ICI1MDAiOworCitkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGNhbnZhcyk7CisK K3ZhciBjdHggPSBjYW52YXMuZ2V0Q29udGV4dCgnMmQnKTsKK2N0eC5maWxsU3R5bGUgPSAncmdi KDAsMjU1LDApJzsKK2N0eC5maWxsUmVjdCgwLCAwLCA1MDAsIDEwMCk7CitjdHguZmlsbFN0eWxl ID0gJ3JnYigwLDAsMCknOworY3R4LmZpbGxUZXh0KCJUaGlzIHRleHQgc2hvdWxkIGJlIHNlZW4i LCAyMCwgMjApOworY3R4LnRyYW5zbGF0ZSgwLCA1MCk7CitjdHguZm9udCA9ICIxMHB0IEFyaWFs IjsKK2N0eC5maWxsVGV4dCgiVGhpcyB0ZXh0IHNob3VsZCBOT1QgYmUgc2VlbiIsIDIwLCAyMCk7 CisvLyBJZiBmaWxsVGV4dCByZXNldHMgdGhlIGN1cnJlbnQgY29udGV4dCwgdGhpcyByZWN0YW5n bGUgd29uJ3QgaGlkZSB0aGUgdGV4dC4KK2N0eC5maWxsU3R5bGUgPSAncmdiKDAsMCwwKSc7Citj dHguZmlsbFJlY3QoMCwgMCwgNTAwLCA1MCk7CisKK3BpeGVsU2hvdWxkQmUoY3R4LCAwLCAwLCAi WzAsMjU1LDAsMjU1XSIpOworCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL3RyYW5zbGF0ZS10ZXh0LWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL3RyYW5zbGF0ZS10ZXh0LWV4cGVjdGVkLnR4dApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5iYzRjODhhCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvdHJhbnNsYXRlLXRleHQtZXhwZWN0ZWQudHh0 CkBAIC0wLDAgKzEsMTAgQEAKK1Rlc3QgZm9yIGNocm9taXVtJ3MgY2FudmFzIGJ1ZyB3aGVyZSBm aWxsVGV4dCByZXNldHMgdGhlIGN1cnJlbnQgY29udGV4dCBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjY0MzYgLiBZb3UgbXVzdCBzZWUgZ3JlZW4gYm94IHdpdGggbWVz c2FnZSAnVGhpcyB0ZXh0IHNob3VsZCBiZSBzZWVuJywgYW5kIGJsYWNrIGJveCBiZWxvdyB0aGUg Z3JlZW4gYm94LgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1Mi IG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBwaXhlbCAw LCAwIGlzIFswLCAyNTUsIDAsIDI1NV0KK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUK KworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy90 cmFuc2xhdGUtdGV4dC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvdHJhbnNsYXRlLXRl eHQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4zYWNkYjIyCi0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvdHJhbnNsYXRlLXRleHQuaHRt bApAQCAtMCwwICsxLDEzIEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBI VE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIu Li9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jl c291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwIGlk PSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8c2NyaXB0IHNy Yz0icmVzb3VyY2VzL3RyYW5zbGF0ZS10ZXh0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIu Li9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRt bD4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k ZXggZDM1Y2ZmMi4uMjczMzBjOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv V2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0wNi0xNiAgU2hpbmljaGly byBIYW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yNjQzNgorCisgICAgICAgIFdpbmRvd3MgQ2hyb21pdW0gYnVnIGZpeDogc2F2ZSBj b250ZXh0IG9mIGRlc3RpbmF0aW9uIGNhbnZhcyBpbgorICAgICAgICBUcmFuc3BhcmVuY3lXaW46 OmNvbXBvc2l0ZVRleHRDb21wb3NpdGUoKSBiZWZvcmUgdGhlIGZ1bmN0aW9uCisgICAgICAgIG1v ZGlmaWVzIHRoZSBjb250ZXh0LgorCisgICAgICAgIFRlc3Q6IGZhc3QvY2FudmFzL3RyYW5zbGF0 ZS10ZXh0Lmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1RyYW5z cGFyZW5jeVdpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUcmFuc3BhcmVuY3lXaW46OmNvbXBv c2l0ZVRleHRDb21wb3NpdGUpOgorCiAyMDA5LTA2LTE1ICBLZXZpbiBNY0N1bGxvdWdoICA8a21j Y3VsbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRpbSBIYXRjaGVyLgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9UcmFuc3BhcmVu Y3lXaW4uY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9UcmFuc3BhcmVu Y3lXaW4uY3BwCmluZGV4IGQzY2VkODEuLjI0ZjkyZDYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVHJhbnNwYXJlbmN5V2luLmNwcAorKysgYi9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1RyYW5zcGFyZW5jeVdpbi5jcHAKQEAgLTQ1MSw2 ICs0NTEsNyBAQCB2b2lkIFRyYW5zcGFyZW5jeVdpbjo6Y29tcG9zaXRlVGV4dENvbXBvc2l0ZSgp CiAKICAgICAvLyBOb3cgdGhlIGxheWVyIGhhcyB0ZXh0IHdpdGggdGhlIHByb3BlciBjb2xvciBh bmQgb3BhY2l0eS4KICAgICBTa0NhbnZhcyogZGVzdENhbnZhcyA9IGNhbnZhc0ZvckNvbnRleHQo Km1fZGVzdENvbnRleHQpOworICAgIGRlc3RDYW52YXMtPnNhdmUoKTsKIAogICAgIC8vIFdlIHdh bnQgdG8gdXNlIFVudHJhbnNmb3JtZWQgc3BhY2UgKHNlZSBhYm92ZSkKICAgICBTa01hdHJpeCBp ZGVudGl0eTsK