26433 2009-06-15 22:29:27 -0700 [V8] Exception from JavaScript propagates to main script 2009-08-25 12:31:58 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED http://webblaze.org/abarth/tests/jswrite/test3.html P2 Normal --- 1 abarth abarth abarth ap dglazkov japhet oldest_to_newest 126141 0 abarth 2009-06-15 22:29:27 -0700 If a script sets an iframe's src attribute to a JavaScript URL that throws an exception, then that exception is improperly propagated from the JavaScript URL to the main script. Test case: http://webblaze.org/abarth/tests/jswrite/test3.html 126416 1 ap 2009-06-17 01:43:17 -0700 I cannot reproduce this with Safari 3.2.3 or with a local debug build of r44713. 126467 2 abarth 2009-06-17 08:56:59 -0700 This bug appears to be specific to the V8 bindings. 127040 3 dglazkov 2009-06-19 14:18:26 -0700 I'll look. Thanks for the report. 128223 4 dglazkov 2009-06-25 11:27:52 -0700 Nate, can you check on this? 141710 5 abarth 2009-08-19 19:32:57 -0700 Any progress on this Nate? Should be an easy fix. 141794 6 abarth 2009-08-20 22:43:03 -0700 In the lost time, Nate made some progress getting to the root cause of this bug. He's going to touch base with the V8 folks and confirm his understanding. 142542 7 38536 ager 2009-08-25 01:43:36 -0700 Created attachment 38536 Patch to isolate compile time exceptions in javascript URLs The problem is that we only isolate runtime exceptions and not compile time exceptions in javascript URLs. 142590 8 38536 abarth 2009-08-25 09:17:06 -0700 Comment on attachment 38536 Patch to isolate compile time exceptions in javascript URLs This looks great. The only problem is you indented using two spaces instead of four. :) Someone can either fix this when landing manually, or you can post an updated patch that we can land automatically. 142669 9 abarth 2009-08-25 12:28:27 -0700 I'll land this manually. 142670 10 abarth 2009-08-25 12:31:58 -0700 Committed r47753: <http://trac.webkit.org/changeset/47753> 38536 2009-08-25 01:43:36 -0700 2009-08-25 09:17:06 -0700 Patch to isolate compile time exceptions in javascript URLs exception-isolation.txt text/plain 6486 ager SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0Nzc0MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMDgtMjUgIE1hZHMgQWdlciAgPGFnZXJAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtWOF0g RXhjZXB0aW9uIGZyb20gSmF2YVNjcmlwdCBwcm9wYWdhdGVzIHRvIG1haW4gc2NyaXB0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjQzMworCisgICAg ICAgIE1ha2Ugc3VyZSB0aGF0IGV4Y2VwdGlvbnMgdGhyb3duIGJvdGggYXQgY29tcGlsZSB0aW1l IGFuZCBhdAorICAgICAgICBydW50aW1lIGluIGphdmFzY3JpcHQgVVJMcyBhcmUgaXNvbGF0ZWQg ZnJvbSB0aGUgbWFpbiBzY3JpcHQuCisKKyAgICAgICAgVGVzdDogZmFzdC9kb20vamF2YXNjcmlw dC11cmwtZXhjZXB0aW9uLWlzb2xhdGlvbi5odG1sCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9W OFByb3h5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4UHJveHk6OmV2YWx1YXRlKToKKwogMjAw OS0wOC0yNSAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgSmFuIEFsb256by4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmNwcAkocmV2aXNpb24g NDc3NDIpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0zMzgsMjggKzMzOCwyOSBAQCB2ODo6TG9jYWw8djg6OlZhbHVlPiBWOFByb3h5OjpldmFs dWF0ZShjCiB7CiAgICAgQVNTRVJUKHY4OjpDb250ZXh0OjpJbkNvbnRleHQoKSk7CiAKLSAgICAv LyBDb21waWxlIHRoZSBzY3JpcHQuCi0gICAgdjg6OkxvY2FsPHY4OjpTdHJpbmc+IGNvZGUgPSB2 OEV4dGVybmFsU3RyaW5nKHNvdXJjZS5zb3VyY2UoKSk7Ci0gICAgQ2hyb21pdW1CcmlkZ2U6OnRy YWNlRXZlbnRCZWdpbigidjguY29tcGlsZSIsIG5vZGUsICIiKTsKLQotICAgIC8vIE5PVEU6IEZv ciBjb21wYXRpYmlsaXR5IHdpdGggV2ViQ29yZSwgU2NyaXB0U291cmNlQ29kZSdzIGxpbmUgc3Rh cnRzIGF0Ci0gICAgLy8gMSwgd2hlcmVhcyB2OCBzdGFydHMgYXQgMC4KLSAgICB2ODo6SGFuZGxl PHY4OjpTY3JpcHQ+IHNjcmlwdCA9IGNvbXBpbGVTY3JpcHQoY29kZSwgc291cmNlLnVybCgpLCBz b3VyY2Uuc3RhcnRMaW5lKCkgLSAxKTsKLSAgICBDaHJvbWl1bUJyaWRnZTo6dHJhY2VFdmVudEVu ZCgidjguY29tcGlsZSIsIG5vZGUsICIiKTsKLQotICAgIENocm9taXVtQnJpZGdlOjp0cmFjZUV2 ZW50QmVnaW4oInY4LnJ1biIsIG5vZGUsICIiKTsKICAgICB2ODo6TG9jYWw8djg6OlZhbHVlPiBy ZXN1bHQ7CiAgICAgewotICAgICAgICAvLyBJc29sYXRlIGV4Y2VwdGlvbnMgdGhhdCBvY2N1ciB3 aGVuIGV4ZWN1dGluZyB0aGUgY29kZS4gVGhlc2UKLSAgICAgICAgLy8gZXhjZXB0aW9ucyBzaG91 bGQgbm90IGludGVyZmVyZSB3aXRoIGphdmFzY3JpcHQgY29kZSB3ZSBtaWdodAotICAgICAgICAv LyBldmFsdWF0ZSBmcm9tIEMrKyB3aGVuIHJldHVybmluZyBmcm9tIGhlcmUuCi0gICAgICAgIHY4 OjpUcnlDYXRjaCB0cnlDYXRjaDsKLSAgICAgICAgdHJ5Q2F0Y2guU2V0VmVyYm9zZSh0cnVlKTsK LQotICAgICAgICAvLyBTZXQgaW5saW5lQ29kZSB0byB0cnVlIGZvciA8YSBocmVmPSJqYXZhc2Ny aXB0OmRvU29tZXRoaW5nKCkiPgotICAgICAgICAvLyBhbmQgZmFsc2UgZm9yIDxzY3JpcHQ+ZG9T b21ldGhpbmc8L3NjcmlwdD4uIFdlIG1ha2UgYSByb3VnaCBndWVzcyBhdAotICAgICAgICAvLyB0 aGlzIGJhc2VkIG9uIHdoZXRoZXIgdGhlIHNjcmlwdCBzb3VyY2UgaGFzIGEgVVJMLgotICAgICAg ICByZXN1bHQgPSBydW5TY3JpcHQoc2NyaXB0LCBzb3VyY2UudXJsKCkuc3RyaW5nKCkuaXNOdWxs KCkpOworICAgICAgLy8gSXNvbGF0ZSBleGNlcHRpb25zIHRoYXQgb2NjdXIgd2hlbiBjb21waWxp bmcgYW5kIGV4ZWN1dGluZworICAgICAgLy8gdGhlIGNvZGUuIFRoZXNlIGV4Y2VwdGlvbnMgc2hv dWxkIG5vdCBpbnRlcmZlcmUgd2l0aAorICAgICAgLy8gamF2YXNjcmlwdCBjb2RlIHdlIG1pZ2h0 IGV2YWx1YXRlIGZyb20gQysrIHdoZW4gcmV0dXJuaW5nCisgICAgICAvLyBmcm9tIGhlcmUuCisg ICAgICB2ODo6VHJ5Q2F0Y2ggdHJ5Q2F0Y2g7CisgICAgICB0cnlDYXRjaC5TZXRWZXJib3NlKHRy dWUpOworCisgICAgICAvLyBDb21waWxlIHRoZSBzY3JpcHQuCisgICAgICB2ODo6TG9jYWw8djg6 OlN0cmluZz4gY29kZSA9IHY4RXh0ZXJuYWxTdHJpbmcoc291cmNlLnNvdXJjZSgpKTsKKyAgICAg IENocm9taXVtQnJpZGdlOjp0cmFjZUV2ZW50QmVnaW4oInY4LmNvbXBpbGUiLCBub2RlLCAiIik7 CisKKyAgICAgIC8vIE5PVEU6IEZvciBjb21wYXRpYmlsaXR5IHdpdGggV2ViQ29yZSwgU2NyaXB0 U291cmNlQ29kZSdzIGxpbmUgc3RhcnRzIGF0CisgICAgICAvLyAxLCB3aGVyZWFzIHY4IHN0YXJ0 cyBhdCAwLgorICAgICAgdjg6OkhhbmRsZTx2ODo6U2NyaXB0PiBzY3JpcHQgPSBjb21waWxlU2Ny aXB0KGNvZGUsIHNvdXJjZS51cmwoKSwgc291cmNlLnN0YXJ0TGluZSgpIC0gMSk7CisgICAgICBD aHJvbWl1bUJyaWRnZTo6dHJhY2VFdmVudEVuZCgidjguY29tcGlsZSIsIG5vZGUsICIiKTsKKwor ICAgICAgQ2hyb21pdW1CcmlkZ2U6OnRyYWNlRXZlbnRCZWdpbigidjgucnVuIiwgbm9kZSwgIiIp OworICAgICAgLy8gU2V0IGlubGluZUNvZGUgdG8gdHJ1ZSBmb3IgPGEgaHJlZj0iamF2YXNjcmlw dDpkb1NvbWV0aGluZygpIj4KKyAgICAgIC8vIGFuZCBmYWxzZSBmb3IgPHNjcmlwdD5kb1NvbWV0 aGluZzwvc2NyaXB0Pi4gV2UgbWFrZSBhIHJvdWdoIGd1ZXNzIGF0CisgICAgICAvLyB0aGlzIGJh c2VkIG9uIHdoZXRoZXIgdGhlIHNjcmlwdCBzb3VyY2UgaGFzIGEgVVJMLgorICAgICAgcmVzdWx0 ID0gcnVuU2NyaXB0KHNjcmlwdCwgc291cmNlLnVybCgpLnN0cmluZygpLmlzTnVsbCgpKTsKICAg ICB9CiAgICAgQ2hyb21pdW1CcmlkZ2U6OnRyYWNlRXZlbnRFbmQoInY4LnJ1biIsIG5vZGUsICIi KTsKICAgICByZXR1cm4gcmVzdWx0OwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNDc3NDIpCisrKyBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0w OC0yNSAgTWFkcyBBZ2VyICA8YWdlckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1Y4XSBFeGNlcHRpb24gZnJvbSBKYXZhU2Ny aXB0IHByb3BhZ2F0ZXMgdG8gbWFpbiBzY3JpcHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTI2NDMzCisKKyAgICAgICAgVGVzdCB0aGF0IGJvdGggY29t cGlsZSB0aW1lIGFuZCBydW50aW1lIGV4Y2VwdGlvbnMgdGhyb3duIGluCisgICAgICAgIGphdmFz Y3JpcHQgVVJMcyBhcmUgaXNvbGF0ZWQgZnJvbSB0aGUgbWFpbiBzY3JpcHQuCisKKyAgICAgICAg KiBmYXN0L2RvbS9qYXZhc2NyaXB0LXVybC1leGNlcHRpb24taXNvbGF0aW9uLWV4cGVjdGVkLnR4 dDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20vamF2YXNjcmlwdC11cmwtZXhjZXB0aW9uLWlz b2xhdGlvbi5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9yZXNvdXJjZXMvamF2YXNj cmlwdC11cmwtZXhjZXB0aW9uLWlzb2xhdGlvbi5qczogQWRkZWQuCisKIDIwMDktMDgtMjQgIEhp cm9ub3JpIEJvbm8gIDxoYm9ub0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg QWRhbSBCYXJ0aC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL2phdmFzY3JpcHQtdXJsLWV4 Y2VwdGlvbi1pc29sYXRpb24tZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2Zhc3QvZG9tL2phdmFzY3JpcHQtdXJsLWV4Y2VwdGlvbi1pc29sYXRpb24tZXhwZWN0ZWQudHh0 CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vamF2YXNjcmlwdC11cmwtZXhj ZXB0aW9uLWlzb2xhdGlvbi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTMg QEAKK0NPTlNPTEUgTUVTU0FHRTogbGluZSAwOiA0MgorQ09OU09MRSBNRVNTQUdFOiBsaW5lIDE6 IFN5bnRheEVycm9yOiBQYXJzZSBlcnJvcgorRXhjZXB0aW9ucyB0aHJvd24gaW4gamF2YXNjcmlw dCBVUkxzIHNob3VsZCBub3QgcHJvcGFnYXRlIHRvIHRoZSBtYWluIHNjcmlwdC4KKworT24gc3Vj Y2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQg YnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgY2F1Z2h0RXhjZXB0aW9uIGlzIGZhbHNlCitQ QVNTIGNhdWdodEV4Y2VwdGlvbiBpcyBmYWxzZQorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMg dHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL2phdmFz Y3JpcHQtdXJsLWV4Y2VwdGlvbi1pc29sYXRpb24uaHRtbAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9mYXN0L2RvbS9qYXZhc2NyaXB0LXVybC1leGNlcHRpb24taXNvbGF0aW9uLmh0bWwJKHJl dmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9qYXZhc2NyaXB0LXVybC1leGNlcHRp b24taXNvbGF0aW9uLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTMgQEAKKzwhRE9DVFlQ RSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8 bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxl LmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3Nj cmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlk PSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvamF2YXNjcmlwdC11cmwt ZXhjZXB0aW9uLWlzb2xhdGlvbi5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVz b3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CkluZGV4 OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9yZXNvdXJjZXMvamF2YXNjcmlwdC11cmwtZXhjZXB0aW9u LWlzb2xhdGlvbi5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9yZXNvdXJj ZXMvamF2YXNjcmlwdC11cmwtZXhjZXB0aW9uLWlzb2xhdGlvbi5qcwkocmV2aXNpb24gMCkKKysr IExheW91dFRlc3RzL2Zhc3QvZG9tL3Jlc291cmNlcy9qYXZhc2NyaXB0LXVybC1leGNlcHRpb24t aXNvbGF0aW9uLmpzCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDI0IEBACitkZXNjcmlwdGlvbigi RXhjZXB0aW9ucyB0aHJvd24gaW4gamF2YXNjcmlwdCBVUkxzIHNob3VsZCBub3QgcHJvcGFnYXRl IHRvIHRoZSBtYWluIHNjcmlwdC4iKQorCit2YXIgc3ViZnJhbWUgPSBkb2N1bWVudC5jcmVhdGVF bGVtZW50KCJpZnJhbWUiKTsKK2RvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoc3ViZnJhbWUpOwor Cit2YXIgY2F1Z2h0RXhjZXB0aW9uID0gZmFsc2U7CisKKy8vIFJ1bnRpbWUgZXhjZXB0aW9uLgor dHJ5IHsKKyAgICBzdWJmcmFtZS5zcmMgPSAnamF2YXNjcmlwdDp0aHJvdyA0Mic7Cit9IGNhdGNo KGUpIHsKKyAgICBjYXVnaHRFeGNlcHRpb24gPSB0cnVlOworfQorc2hvdWxkQmVGYWxzZSgnY2F1 Z2h0RXhjZXB0aW9uJyk7CisKKy8vIENvbXBpbGUtdGltZSBleGNlcHRpb24uCit0cnkgeworICAg IHN1YmZyYW1lLnNyYyA9ICdqYXZhc2NyaXB0OjxodG1sPjwvaHRtbD4nOworfSBjYXRjaChlKSB7 CisgICAgY2F1Z2h0RXhjZXB0aW9uID0gdHJ1ZTsKK30KK3Nob3VsZEJlRmFsc2UoJ2NhdWdodEV4 Y2VwdGlvbicpOworCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsK