264325 2023-11-06 23:59:29 -0800 run-minibrowser --help seems incorrect about url-loading 2024-09-02 12:24:24 -0700 1 1 1 Unclassified WebKit Tools / Tests Safari 17 Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=255962 https://bugs.webkit.org/show_bug.cgi?id=256086 https://bugs.webkit.org/show_bug.cgi?id=247378 https://bugs.webkit.org/show_bug.cgi?id=278955 GoodFirstBug, InRadar P2 Normal --- 1 karlcow webkit-unassigned basuke g_squelart mcatanzaro philn webkit-bug-importer oldest_to_newest 1990467 0 karlcow 2023-11-06 23:59:29 -0800 Currently the help indicates that you can do run-minibrowser http://example.org/ That is not true. It requires run-minibrowser --url http://example.org/ This is an easy fix. 1990468 1 karlcow 2023-11-06 23:59:55 -0800 <rdar://117554821> 1990489 2 karlcow 2023-11-07 02:50:52 -0800 % run-minibrowser http://example.com options Namespace(platform='mac', configuration=None, architecture=None, model=None, url='http://example.com') % run-minibrowser --url http://example.com options Namespace(platform='mac', configuration=None, architecture=None, model=None, url='http://example.com') so far so good. But the example of the help menu says: MiniBrowser options: Pass them after two dashes. Example: run-minibrowser --wpe -- --platform=drm http://url.com Let's try: % run-minibrowser --wpe -- --platform=drm http://example.com options Namespace(platform='wpe', configuration=None, architecture=None, model=None, url='--platform=drm') This is not good. This is not what we are expecting. same with --url % run-minibrowser --wpe -- --platform=drm --url http://example.com options Namespace(platform='wpe', configuration=None, architecture=None, model=None, url='--platform=drm') This is slightly better % run-minibrowser http://example.com -- --platform=drm options Namespace(platform='mac', configuration=None, architecture=None, model=None, url='http://example.com') % run-minibrowser http://example.com -- --platform=drm options Namespace(platform='mac', configuration=None, architecture=None, model=None, url='http://example.com') % run-minibrowser http://example.com --platform=drm options Namespace(platform='drm', configuration=None, architecture=None, model=None, url='http://example.com') So there are issues with the current parsing of arguments. Note: Replace url.com by example.org in all examples. 1990495 3 karlcow 2023-11-07 03:11:07 -0800 See also https://github.com/WebKit/WebKit/pull/6049 1990652 4 philn 2023-11-07 14:08:43 -0800 run-minibrowser --wpe http://example.com -- --platform=drm ? 1990654 5 philn 2023-11-07 14:10:28 -0800 > Example: run-minibrowser --wpe -- --platform=drm http://url.com That example looks incorrect. The url should be before -- 1990676 6 mcatanzaro 2023-11-07 15:51:17 -0800 (In reply to Philippe Normand from comment #5) > That example looks incorrect. The url should be before -- I guess the -- is used to indicate the end of the list of arguments to run-minibrowser and start the list of arguments to MiniBrowser itself. And the URL to load is surely an argument for MiniBrowser. So I think Karl is probably right that the example matches the intended behavior? 1990701 7 karlcow 2023-11-07 17:40:51 -0800 (In reply to Philippe Normand from comment #5) > > Example: run-minibrowser --wpe -- --platform=drm http://url.com > > > That example looks incorrect. The url should be before -- Yes. Exactly, https://github.com/WebKit/WebKit/commit/63d0be648fd8f20ec94cadbb884a358bc6eba18b but that also means the code is not very robust to this kind of mistakes. If I have a bit of bandwidth, I will fix a couple of things there, but if someone else wants to do it.