264303 2023-11-06 15:57:35 -0800 [css-flex] Flex layout incorrectly dirties preferred width bits towards the end of layout 2023-12-20 10:33:58 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://github.com/web-platform-tests/wpt/pull/43652 https://bugs.webkit.org/show_bug.cgi?id=266601 InRadar P2 Normal --- 1 sgill26 sgill26 bfulgham qmmille simon.fraser webkit-bug-importer zalan oldest_to_newest 1990340 0 sgill26 2023-11-06 15:57:35 -0800 RenderFlexibleBox::layoutAndPlaceChildren will sometimes incorrectly dirty the preferred widths bit of flex items with a call to updateBlockChildDirtyBitsBeforeLayout. This is incorrect since this is down towards the end of layout and we never compute the preferred widths for flex items after this point. This dirtying should happen if the content of the flex item changes, since that is what the intrinsic sizes is based off of, or if there is some other related style change on the flexbox that could impact it (e.g. items with an aspect-ratio for the content based minimum size: https://drafts.csswg.org/css-flexbox-1/#content-based-minimum-size) 1990341 1 sgill26 2023-11-06 15:58:44 -0800 rdar://117181858 1990365 2 sgill26 2023-11-06 17:10:34 -0800 Pull request: https://github.com/WebKit/WebKit/pull/19807 1999345 3 ews-feeder 2023-12-13 11:26:37 -0800 Committed 271995@main (efb0cb853cc0): <https://commits.webkit.org/271995@main> Reviewed commits have been landed. Closing PR #19807 and removing active labels. 1999360 4 sgill26 2023-12-13 12:32:52 -0800 Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/43652 2001074 5 sgill26 2023-12-20 09:23:35 -0800 *** Bug 266601 has been marked as a duplicate of this bug. *** 2001100 6 sgill26 2023-12-20 10:33:58 -0800 For future context: The effects of this bug was first reported on https://www.amazon.com/stores/Jellycat/page/92DE52A7-85AC-40F4-A3A5-08B62869740E?ref_=ast_bln