264299 2023-11-06 15:41:14 -0800 [JSC] Use simpler helpers for repatching 2023-11-10 05:05:09 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki dpino dpino webkit-bug-importer oldest_to_newest 1990331 0 ysuzuki 2023-11-06 15:41:14 -0800 ... 1990332 1 webkit-bug-importer 2023-11-06 15:41:29 -0800 <rdar://problem/118023749> 1990333 2 ysuzuki 2023-11-06 15:43:08 -0800 Pull request: https://github.com/WebKit/WebKit/pull/20069 1990646 3 ews-feeder 2023-11-07 13:48:53 -0800 Committed 270351@main (f5d367e64491): <https://commits.webkit.org/270351@main> Reviewed commits have been landed. Closing PR #20069 and removing active labels. 1991099 4 dpino 2023-11-09 01:29:40 -0800 Debian 11 bot is failing witht the following error: https://build.webkit.org/#/builders/46/builds/34680 ./../../Source/JavaScriptCore/assembler/X86Assembler.h: In static member function ‘static void JSC::X86Assembler::replaceWithNops(void*, size_t)’: ../../../Source/JavaScriptCore/assembler/X86Assembler.h:6396:71: error: no matching function for call to ‘JSC::X86Assembler::fillNops<memcpy>(void*&, size_t&)’ 6396 | fillNops<memcpy>(instructionStart, memoryToFillWithNopsInBytes); | ^ ../../../Source/JavaScriptCore/assembler/X86Assembler.h:6513:17: note: candidate: ‘template<void* (& copy)(void*, const void*, size_t)> static void JSC::X86Assembler::fillNops(void*, size_t)’ 6513 | static void fillNops(void* base, size_t size) | ^~~~~~~~ ../../../Source/JavaScriptCore/assembler/X86Assembler.h:6513:17: note: template argument deduction/substitution failed: ../../../Source/JavaScriptCore/assembler/X86Assembler.h:6396:71: error: ‘(void* (&)(void*, const void*, size_t))memcpy’ is not a valid template argument for type ‘void* (&)(void*, const void*, size_t)’ {aka ‘void* (&)(void*, const void*, long unsigned int)’} 6396 | fillNops<memcpy>(instructionStart, memoryToFillWithNopsInBytes); 1991102 5 dpino 2023-11-09 01:34:10 -0800 Re-opening for pull request https://github.com/webkit/webkit/pull/20220 1991502 6 ews-feeder 2023-11-10 05:05:06 -0800 Committed 270526@main (32983feb344b): <https://commits.webkit.org/270526@main> Reviewed commits have been landed. Closing PR #20220 and removing active labels.