264297 2023-11-06 15:37:51 -0800 REGRESSION (270226@main): Profiling symbols missing from JavaScriptCore.framework 2023-11-06 20:00:59 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 263697 1 ddkilzer ddkilzer webkit-bug-importer oldest_to_newest 1990326 0 ddkilzer 2023-11-06 15:37:51 -0800 Profiling symbols missing from JavaScriptCore.framework. This happened after introducing `libJavaScriptCore.a` in 270226@main since these two lines were moved from `JavaScriptCore.xcconfig` to `libJavaScriptCore.xcconfig` instead of to `BaseTarget.xcconfig`, which caused `-fprofile-instr-generate` not to be included when linking `JavaScriptCore.framework`: ``` CLANG_INSTRUMENT_FOR_OPTIMIZATION_PROFILING = $(CLANG_INSTRUMENT_FOR_OPTIMIZATION_PROFILING_$(ENABLE_LLVM_PROFILE_GENERATION)); CLANG_INSTRUMENT_FOR_OPTIMIZATION_PROFILING_ENABLE_LLVM_PROFILE_GENERATION = YES; ``` 1990327 1 webkit-bug-importer 2023-11-06 15:38:13 -0800 <rdar://problem/118023550> 1990334 2 ddkilzer 2023-11-06 15:43:26 -0800 Pull request: https://github.com/WebKit/WebKit/pull/20070 1990417 3 ews-feeder 2023-11-06 20:00:58 -0800 Committed 270306@main (60d419eb1b25): <https://commits.webkit.org/270306@main> Reviewed commits have been landed. Closing PR #20070 and removing active labels.