26427 2009-06-15 21:20:28 -0700 Use consistent Windows GUID Comparison Functions 2009-06-16 09:44:57 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 bfulgham webkit-unassigned oldest_to_newest 126129 0 bfulgham 2009-06-15 21:20:28 -0700 There are a handful of places where GUIDs are being compared using standard equality operator. These should be changed to the SDK IsEqualGUID call. 126130 1 31331 bfulgham 2009-06-15 21:25:50 -0700 Created attachment 31331 Use IsEqualGUID 126144 2 31331 darin 2009-06-15 23:04:26 -0700 Comment on attachment 31331 Use IsEqualGUID > - if (IID_IUnknown==riid || IID_IDataObject==riid) > + if (IsEqualIID(riid, IID_IUnknown) || > + IsEqualIID(riid, IID_IDataObject)) { > *ppvObject=this; > + } I don't think you needed to break this into multiple lines. And when you did, I wish you had followed the WebKit coding style (see the Indentation section, item 6, and the Braces section, item 3). r=me 126214 3 bfulgham 2009-06-16 09:44:57 -0700 Fixed line break and braces while landing. Landed in http://trac.webkit.org/changeset/44723 31331 2009-06-15 21:25:50 -0700 2009-06-15 23:04:26 -0700 Use IsEqualGUID guid_patch.txt text/plain 2257 bfulgham SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NDcwOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDYtMTUgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VXNlIGNvbnNpc3RlbnQgR1VJRCBjb21wYXJpc29uIGZ1bmN0aW9ucy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2NDI3CisKKyAgICAgICAgKiBwbGF0 Zm9ybS93aW4vV0NEYXRhT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldDRGF0YU9iamVj dDo6UXVlcnlJbnRlcmZhY2UpOgorCiAyMDA5LTA2LTE1ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtp dC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJzIENhcmxzc29uLgpJbmRleDogV2Vi Q29yZS9wbGF0Zm9ybS93aW4vV0NEYXRhT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L3BsYXRmb3JtL3dpbi9XQ0RhdGFPYmplY3QuY3BwCShyZXZpc2lvbiA0NDcwNSkKKysrIFdlYkNv cmUvcGxhdGZvcm0vd2luL1dDRGF0YU9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3OCw4 ICsxNzgsMTAgQEAgV0NEYXRhT2JqZWN0Ojp+V0NEYXRhT2JqZWN0KCkKIFNURE1FVEhPRElNUCBX Q0RhdGFPYmplY3Q6OlF1ZXJ5SW50ZXJmYWNlKFJFRklJRCByaWlkLHZvaWQqKiBwcHZPYmplY3Qp CiB7CiAgICAgKnBwdk9iamVjdCA9IDA7Ci0gICAgaWYgKElJRF9JVW5rbm93bj09cmlpZCB8fCBJ SURfSURhdGFPYmplY3Q9PXJpaWQpCisgICAgaWYgKElzRXF1YWxJSUQocmlpZCwgSUlEX0lVbmtu b3duKSB8fCAKKyAgICAgICAgSXNFcXVhbElJRChyaWlkLCBJSURfSURhdGFPYmplY3QpKSB7CiAg ICAgICAgICpwcHZPYmplY3Q9dGhpczsKKyAgICB9CiAgICAgaWYgKCpwcHZPYmplY3QpIHsKICAg ICAgICAgQWRkUmVmKCk7CiAgICAgICAgIHJldHVybiBTX09LOwpJbmRleDogV2ViS2l0L3dpbi9D aGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ0 NzA4KQorKysgV2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx MyBAQAorMjAwOS0wNi0xNSAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGdtYWlsLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgY29uc2lz dGVudCBXaW5kb3dzIEdVSUQgQ29tcGFyaXNvbiBGdW5jdGlvbnMuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjQyNy4KKworICAgICAgICAqIFdlYlZp ZXcuY3BwOgorICAgICAgICAoRW51bVRleHRNYXRjaGVzOjpRdWVyeUludGVyZmFjZSk6CisKICAg ICAyMDA5LTA2LTE1ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgVGltIEhhdGNoZXIuCkluZGV4OiBXZWJLaXQvd2luL1dlYlZpZXcuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYktpdC93aW4vV2ViVmlldy5jcHAJKHJldmlzaW9uIDQ0NzA1KQorKysg V2ViS2l0L3dpbi9XZWJWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTIxMyw3ICs1MjEzLDcg QEAgcHVibGljOgogCiAgICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIFF1ZXJ5 SW50ZXJmYWNlKFJFRklJRCByaWlkLCB2b2lkKiogcHB2KQogICAgIHsKLSAgICAgICAgaWYgKHJp aWQgPT0gSUlEX0lVbmtub3duIHx8IHJpaWQgPT0gSUlEX0lFbnVtVGV4dE1hdGNoZXMpIHsKKyAg ICAgICAgaWYgKElzRXF1YWxHVUlEKHJpaWQsIElJRF9JVW5rbm93bikgfHwgSXNFcXVhbEdVSUQo cmlpZCwgSUlEX0lFbnVtVGV4dE1hdGNoZXMpKSB7CiAgICAgICAgICAgICAqcHB2ID0gdGhpczsK ICAgICAgICAgICAgIEFkZFJlZigpOwogICAgICAgICB9Cg==