26423 2009-06-15 16:12:56 -0700 Expanding profile call stacks broken after sorting 2009-09-24 19:21:05 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED http://webkit.org/misc/drosera/ P2 Major --- 1 timothy timothy aroben jberlin kmccullough timothy tolmasky oldest_to_newest 126077 0 timothy 2009-06-15 16:12:56 -0700 Sometimes expanding a call stack will not show any decendants. Steps: 1) Load http://webkit.org/misc/drosera/ 2) Enable profiling in the Inspector. 3) Click "Nested functions" button. 4) View the profile. 5) Expand then colapse the "rot" call. 6) Sort by Calls. 7) Try to expand the same "rot" call. Results: Disclosure triangle expands but no decendancts show up. Expected: The decendancts should show up in the rows below. This might be a bug in DataGrid.js. 149915 1 40096 jberlin 2009-09-24 18:34:25 -0700 Created attachment 40096 Tell collapsed grid nodes with children to refresh the children on the next expand 149917 2 40096 timothy 2009-09-24 18:40:26 -0700 Comment on attachment 40096 Tell collapsed grid nodes with children to refresh the children on the next expand Nice! (You have tabs in your ChangeLog.) 149919 3 jberlin 2009-09-24 19:21:05 -0700 Thanks! Removed the tabs and committed: http://trac.webkit.org/changeset/48742 40096 2009-09-24 18:34:25 -0700 2009-09-24 18:40:25 -0700 Tell collapsed grid nodes with children to refresh the children on the next expand fixProfileSortAndExpand.txt text/plain 1669 jberlin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjM1YjgyMS4uY2JhMWZhOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wOS0yNCAgSmVzc2llIEJlcmxp biAgPGpiZXJsaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworCUZpeCBleHBhbmRpbmcgcHJvZmlsZSBjYWxsIHN0YWNrcyBiZWluZyBicm9rZW4g YWZ0ZXIgc29ydGluZy4KKwlodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjY0MjMKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZURhdGFHcmlkVHJl ZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Qcm9maWxlRGF0YUdyaWROb2RlLnByb3RvdHlw ZS5zb3J0KToKKwlTZXQgc2hvdWxkUmVmcmVzaENoaWxkcmVuIHRvIHRydWUgb24gY29sbGFwc2Vk IG5vZGVzIHdpdGggY2hpbGRyZW4gc28gdGhhdCBleHBhbmRpbmcgaXQKKwljYXVzZXMgdGhlIGNo aWxkcmVuIHRvIGJlIHBsYWNlZCBpbiB0aGUgcmlnaHQgcG9zaXRpb25zLgorCiAyMDA5LTA5LTI0 ICBKZXJlbXkgT3Jsb3cgIDxqb3Jsb3dAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9Qcm9maWxlRGF0YUdyaWRUcmVlLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1Byb2ZpbGVEYXRhR3JpZFRyZWUuanMKaW5kZXggMzU2ZjU3ZC4uM2ZiMGUwMCAxMDA2NDQKLS0t IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVEYXRhR3JpZFRyZWUuanMKKysr IGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVEYXRhR3JpZFRyZWUuanMKQEAg LTE1Myw4ICsxNTMsMTEgQEAgV2ViSW5zcGVjdG9yLlByb2ZpbGVEYXRhR3JpZE5vZGUucHJvdG90 eXBlID0gewogCiAgICAgICAgICAgICAgICAgLy8gSWYgdGhlIGdyaWQgbm9kZSBpcyBjb2xsYXBz ZWQsIHRoZW4gZG9uJ3Qgc29ydCBjaGlsZHJlbiAoc2F2ZSBvcGVyYXRpb24gZm9yIGxhdGVyKS4K ICAgICAgICAgICAgICAgICAvLyBJZiB0aGUgZ3JpZCBub2RlIGhhcyB0aGUgc2FtZSBzb3J0aW5n IGFzIHByZXZpb3VzbHksIHRoZW4gdGhlcmUgaXMgbm8gcG9pbnQgaW4gc29ydGluZyBpdCBhZ2Fp bi4KLSAgICAgICAgICAgICAgICBpZiAoIWZvcmNlICYmICFncmlkTm9kZS5leHBhbmRlZCB8fCBn cmlkTm9kZS5sYXN0Q29tcGFyYXRvciA9PT0gY29tcGFyYXRvcikKKyAgICAgICAgICAgICAgICBp ZiAoIWZvcmNlICYmICFncmlkTm9kZS5leHBhbmRlZCB8fCBncmlkTm9kZS5sYXN0Q29tcGFyYXRv ciA9PT0gY29tcGFyYXRvcikgeworICAgICAgICAgICAgICAgICAgICBpZiAoZ3JpZE5vZGUuY2hp bGRyZW4ubGVuZ3RoKQorICAgICAgICAgICAgICAgICAgICAgICAgZ3JpZE5vZGUuc2hvdWxkUmVm cmVzaENoaWxkcmVuID0gdHJ1ZTsKICAgICAgICAgICAgICAgICAgICAgY29udGludWU7CisgICAg ICAgICAgICAgICAgfQogCiAgICAgICAgICAgICAgICAgZ3JpZE5vZGUubGFzdENvbXBhcmF0b3Ig PSBjb21wYXJhdG9yOwogCg==