<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>263967</bug_id>
          
          <creation_ts>2023-10-31 07:52:26 -0700</creation_ts>
          <short_desc>Incorrect documentation for webkit-cookie-manager-get-cookies-finish</short_desc>
          <delta_ts>2023-11-01 09:21:18 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="SyntevoAlex">alexandr.miloslavskiy</reporter>
          <assigned_to name="Michael Catanzaro">mcatanzaro</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1988833</commentid>
    <comment_count>0</comment_count>
    <who name="SyntevoAlex">alexandr.miloslavskiy</who>
    <bug_when>2023-10-31 07:52:26 -0700</bug_when>
    <thetext>These two functions:
* webkit_cookie_manager_get_cookies_finish
* webkit_cookie_manager_get_all_cookies_finish

are incorrectly documented to &quot;return value is a #GSList&quot;, whereas it actually returns GList.
This is not a mere typo, because GSList is also an existing type.

The incorrect documentation existed ever since the code was introduced in e07cfc0d.

This actually fooled some people, see for example:
https://github.com/eclipse-platform/eclipse.platform.swt/issues/842</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1988899</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2023-10-31 10:30:13 -0700</bug_when>
    <thetext>Thanks for reporting this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1988902</commentid>
    <comment_count>2</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2023-10-31 10:37:10 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/19782</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1989161</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-11-01 09:21:15 -0700</bug_when>
    <thetext>Committed 270058@main (e57b85e56c4c): &lt;https://commits.webkit.org/270058@main&gt;

Reviewed commits have been landed. Closing PR #19782 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>