26395 2009-06-14 20:01:41 -0700 REGRESSION (r40813-r40884): No caret after going back/forward to page with focused text field 2009-06-14 21:38:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar, Regression P1 Normal --- 1 mitz webkit-unassigned beidson oldest_to_newest 125865 0 mitz 2009-06-14 20:01:41 -0700 Steps to reproduce: 1) Go to <about:blank> 2) In the same tab, go to <data:text/html,%3Cinput%3E> 3) Click in the text field 4) Choose History > Back 5) Choose History > Forward Result: The text field is focused, but there is no caret and typing does not enter text in the field. 125866 1 mitz 2009-06-14 20:02:13 -0700 <rdar://problem/6971333> 125869 2 mitz 2009-06-14 20:23:28 -0700 The code that’s supposed to restore the selection is in CachedPage::restore(). However, in TOT, CachedPage::restore() is unreachable (I verified this by removing its definition and building WebCore successfully). 125870 3 mitz 2009-06-14 20:29:43 -0700 bisect-builds puts the regression between r40813 and r40884. Based on my previous comment, I think it was <http://trac.webkit.org/changeset/40870>. 125873 4 31277 mitz 2009-06-14 20:45:57 -0700 Created attachment 31277 Reinstate call to CachedPage::restore() 125876 5 mitz 2009-06-14 21:38:14 -0700 Fixed in <http://trac.webkit.org/projects/webkit/changeset/44676>. 31277 2009-06-14 20:45:57 -0700 2009-06-14 21:31:25 -0700 Reinstate call to CachedPage::restore() 6971333_r1.diff text/plain 1183 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NDY3NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMDYtMTQgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIGZp eCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjYzOTUKKyAgICAgICAg ICA8cmRhcjovL3Byb2JsZW0vNjk3MTMzMz4gUkVHUkVTU0lPTiAocjQwODEzLXI0MDg4NCk6IE5v IGNhcmV0IGFmdGVyCisgICAgICAgICAgZ29pbmcgYmFjay9mb3J3YXJkIHRvIHBhZ2Ugd2l0aCBm b2N1c2VkIHRleHQgZmllbGQKKworICAgICAgICBObyB0ZXN0LCBzaW5jZSB0aGUgYmFjay9mb3J3 YXJkIGNhY2hlIGlzIGRpc2FibGVkIGluIER1bXBSZW5kZXJUcmVlCisKKyAgICAgICAgKiBsb2Fk ZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6Om9wZW4p OiBBZGRlZCBhIGNhbGwgdG8gQ2FjaGVkUGFnZTo6cmVzdG9yZSgpLAorICAgICAgICB3aGljaCB3 YXMgcmVtb3ZlZCBpbiByNDA4NzAuCisKIDIwMDktMDYtMTQgIERhcmluIEFkbGVyICA8ZGFyaW5A YXBwbGUuY29tPgogCiAgICAgICAgICogZWRpdGluZy9UZXh0SXRlcmF0b3IuY3BwOgpJbmRleDog V2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvbG9h ZGVyL0ZyYW1lTG9hZGVyLmNwcAkocmV2aXNpb24gNDQ2NjEpCisrKyBXZWJDb3JlL2xvYWRlci9G cmFtZUxvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMwNTMsNiArMzA1Myw3IEBAIHZvaWQg RnJhbWVMb2FkZXI6Om9wZW4oQ2FjaGVkUGFnZSYgY2FjaGUKICAgICB9CiAKICAgICBvcGVuKCpj YWNoZWRQYWdlLmNhY2hlZE1haW5GcmFtZSgpKTsKKyAgICBjYWNoZWRQYWdlLnJlc3RvcmUobV9m cmFtZS0+cGFnZSgpKTsKIAogICAgIGNoZWNrQ29tcGxldGVkKCk7CiB9Cg==