26385 2009-06-14 10:53:26 -0700 Root SVG element is not checked on requiredFeatures, requiredExtension like other elements 2009-06-18 12:51:40 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P3 Normal --- 1 rwlbuis webkit-unassigned jeffschiller oldest_to_newest 125783 0 rwlbuis 2009-06-14 10:53:26 -0700 If on the root SVG element requiredFeatures or any of the other test attributes is set, they are not taken into account. I checked in FF and Opera and there they are taken into account. 125784 1 31266 rwlbuis 2009-06-14 10:58:24 -0700 Created attachment 31266 First attempt 126723 2 31266 zimmermann 2009-06-18 10:23:57 -0700 Comment on attachment 31266 First attempt Ouch, good catch! r=me. 126740 3 rwlbuis 2009-06-18 11:45:00 -0700 Thanks! Landed in r44808. 126741 4 darin 2009-06-18 11:46:37 -0700 This kind of virtual function override in a leaf class should normally be private rather than public. 31266 2009-06-14 10:58:24 -0700 2009-06-18 10:23:57 -0700 First attempt 26385.diff text/plain 3968 rwlbuis ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyNzViMzFiLi42M2E0ODNjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMDYt MTQgIFJvYiBCdWlzICA8cndsYnVpc0BnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdCBmb3I6CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjM4NQorICAgICAgICBSb290IFNWRyBlbGVt ZW50IGlzIG5vdCBjaGVja2VkIG9uIHJlcXVpcmVkRmVhdHVyZXMsIHJlcXVpcmVkRXh0ZW5zaW9u IGxpa2Ugb3RoZXIgZWxlbWVudHMKKworICAgICAgICBBbHNvIGRvIHRoZSBpc1ZhbGlkIGNoZWNr IGZvciBvdXRlciA8c3ZnPi4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9zdmcvY3VzdG9tL291 dGVyLXN2Zy11bmtub3duLWZlYXR1cmUtZXhwZWN0ZWQuY2hlY2tzdW06IEFkZGVkLgorICAgICAg ICAqIHBsYXRmb3JtL21hYy9zdmcvY3VzdG9tL291dGVyLXN2Zy11bmtub3duLWZlYXR1cmUtZXhw ZWN0ZWQucG5nOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvc3ZnL2N1c3RvbS9vdXRl ci1zdmctdW5rbm93bi1mZWF0dXJlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogc3Zn L2N1c3RvbS9vdXRlci1zdmctdW5rbm93bi1mZWF0dXJlLnN2ZzogQWRkZWQuCisKIDIwMDktMDYt MTMgIERpcmsgU2NodWx6ZSAgPGtyaXRAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9zdmcv Y3VzdG9tL291dGVyLXN2Zy11bmtub3duLWZlYXR1cmUtZXhwZWN0ZWQuY2hlY2tzdW0gYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMvc3ZnL2N1c3RvbS9vdXRlci1zdmctdW5rbm93bi1mZWF0dXJl LWV4cGVjdGVkLmNoZWNrc3VtCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmQ2 OWEzNzEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvc3ZnL2N1 c3RvbS9vdXRlci1zdmctdW5rbm93bi1mZWF0dXJlLWV4cGVjdGVkLmNoZWNrc3VtCkBAIC0wLDAg KzEgQEAKKzg1M2RlMDA1NjdkMTIxYmVhMGI3YmVjZTY2YTVkNjFjClwgTm8gbmV3bGluZSBhdCBl bmQgb2YgZmlsZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL3N2Zy9jdXN0 b20vb3V0ZXItc3ZnLXVua25vd24tZmVhdHVyZS1leHBlY3RlZC5wbmcgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMvc3ZnL2N1c3RvbS9vdXRlci1zdmctdW5rbm93bi1mZWF0dXJlLWV4cGVjdGVk LnBuZwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4xMmZkZTk1CkJpbmFyeSBm aWxlcyAvZGV2L251bGwgYW5kIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL3N2Zy9jdXN0b20v b3V0ZXItc3ZnLXVua25vd24tZmVhdHVyZS1leHBlY3RlZC5wbmcgZGlmZmVyCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvc3ZnL2N1c3RvbS9vdXRlci1zdmctdW5rbm93bi1m ZWF0dXJlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9zdmcvY3VzdG9t L291dGVyLXN2Zy11bmtub3duLWZlYXR1cmUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAuLmU1MDA2MWIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9tYWMvc3ZnL2N1c3RvbS9vdXRlci1zdmctdW5rbm93bi1mZWF0dXJlLWV4cGVj dGVkLnR4dApAQCAtMCwwICsxLDIgQEAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBS ZW5kZXJWaWV3IGF0ICgwLDApIHNpemUgODAweDYwMApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv c3ZnL2N1c3RvbS9vdXRlci1zdmctdW5rbm93bi1mZWF0dXJlLnN2ZyBiL0xheW91dFRlc3RzL3N2 Zy9jdXN0b20vb3V0ZXItc3ZnLXVua25vd24tZmVhdHVyZS5zdmcKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMC4uNzhkMmE0OQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L3N2Zy9jdXN0b20vb3V0ZXItc3ZnLXVua25vd24tZmVhdHVyZS5zdmcKQEAgLTAsMCArMSwzIEBA Cis8c3ZnIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgcmVxdWlyZWRGZWF0dXJl cz0idW5rbm93bl9mZWF0dXJlIj4KKyAgPHRleHQgeD0iMjAiIHk9IjIwIj5UaGlzIHNob3VsZCBu b3QgYmUgdmlzaWJsZTwvdGV4dD4KKzwvc3ZnPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VM b2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwYTI5OTU5Li5iNjlhZGI0IDEwMDY0NAotLS0g YS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDA5LTA2LTE0ICBSb2IgQnVpcyAgPHJ3bGJ1aXNAZ21haWwuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjM4NQorICAgICAgICBSb290IFNWRyBlbGVtZW50IGlz IG5vdCBjaGVja2VkIG9uIHJlcXVpcmVkRmVhdHVyZXMsIHJlcXVpcmVkRXh0ZW5zaW9uIGxpa2Ug b3RoZXIgZWxlbWVudHMKKworICAgICAgICBBbHNvIGRvIHRoZSBpc1ZhbGlkIGNoZWNrIGZvciBv dXRlciA8c3ZnPi4KKworICAgICAgICBUZXN0OiBzdmcvY3VzdG9tL291dGVyLXN2Zy11bmtub3du LWZlYXR1cmUuc3ZnCisKKyAgICAgICAgKiBzdmcvU1ZHRG9jdW1lbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6U1ZHRG9jdW1lbnQ6OmNoaWxkU2hvdWxkQ3JlYXRlUmVuZGVyZXIpOgorICAgICAg ICAqIHN2Zy9TVkdEb2N1bWVudC5oOgorCiAyMDA5LTA2LTEzICBQZXRlciBLYXN0aW5nICA8cGth c3RpbmdAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZXZpbiBPbGxpdmllci4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvc3ZnL1NWR0RvY3VtZW50LmNwcCBiL1dlYkNvcmUvc3ZnL1NW R0RvY3VtZW50LmNwcAppbmRleCA5MjQ0ODczLi5mZThhYjgwIDEwMDY0NAotLS0gYS9XZWJDb3Jl L3N2Zy9TVkdEb2N1bWVudC5jcHAKKysrIGIvV2ViQ29yZS9zdmcvU1ZHRG9jdW1lbnQuY3BwCkBA IC05OSw2ICs5OSwxMyBAQCB2b2lkIFNWR0RvY3VtZW50Ojp1cGRhdGVQYW4oY29uc3QgRmxvYXRQ b2ludCYgcG9zKSBjb25zdAogICAgIH0KIH0KIAorYm9vbCBTVkdEb2N1bWVudDo6Y2hpbGRTaG91 bGRDcmVhdGVSZW5kZXJlcihOb2RlKiBub2RlKSBjb25zdAoreworICAgIGlmIChub2RlLT5oYXNU YWdOYW1lKFNWR05hbWVzOjpzdmdUYWcpKQorICAgICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8U1ZH U1ZHRWxlbWVudCo+KG5vZGUpLT5pc1ZhbGlkKCk7CisgICAgcmV0dXJuIHRydWU7Cit9CisKIH0K IAogLy8gdmltOnRzPTQ6bm9ldApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9zdmcvU1ZHRG9jdW1lbnQu aCBiL1dlYkNvcmUvc3ZnL1NWR0RvY3VtZW50LmgKaW5kZXggMTQxMTAxNy4uMDJlMzY0OSAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9zdmcvU1ZHRG9jdW1lbnQuaAorKysgYi9XZWJDb3JlL3N2Zy9TVkdE b2N1bWVudC5oCkBAIC01Miw2ICs1Miw4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAg dm9pZCBzdGFydFBhbihjb25zdCBGbG9hdFBvaW50JiBzdGFydCk7CiAgICAgICAgIHZvaWQgdXBk YXRlUGFuKGNvbnN0IEZsb2F0UG9pbnQmIHBvcykgY29uc3Q7CiAKKyAgICAgICAgdmlydHVhbCBi b29sIGNoaWxkU2hvdWxkQ3JlYXRlUmVuZGVyZXIoTm9kZSopIGNvbnN0OworCiAgICAgcHJpdmF0 ZToKICAgICAgICAgU1ZHRG9jdW1lbnQoRnJhbWUqKTsKIAo=