263834 2023-10-28 14:41:44 -0700 HTML dialog ::backdrop ignores all CSS variables 2025-03-14 11:08:16 -0700 1 1 1 Unclassified WebKit CSS Safari Technology Preview Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=289800 GoodFirstBug, InRadar P2 Normal --- 263838 1 wes webkit-unassigned ahmad.saleem792 fotis.papadogeorgopoulos ntim webkit-bug-importer webkit oldest_to_newest 1988242 0 wes 2023-10-28 14:41:44 -0700 The spec was updated so that ::backdrop should inherit from originating element. This will allow CSS variables to work properly in ::backdrop selectors. See existing WPT for test case: https://wpt.fyi/results/html/semantics/interactive-elements/the-dialog-element/backdrop-inherits.html 1988287 1 ntim 2023-10-28 21:43:44 -0700 https://searchfox.org/wubkat/rev/85e40ad30a15e2dfcda4ebad64ed7f41292908a4/Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp#203-204 Should be as easy as changing `&renderer.view().style()` to `&renderer.style()` on that line (and the related comment). 1988492 2 ahmad.saleem792 2023-10-30 07:54:46 -0700 I think Keith has fix for this in his local branch: https://github.com/keithamus/WebKit/commit/09077ac5976fea157c74dd161c7e49f511157477#diff-7f18480073b63da9fd4d75c26e4e35d003a101498030d45587ab9b5241b2e2bf It just needs to be push on WebKit origin. 1988697 3 webkit 2023-10-30 16:23:50 -0700 Yep I've got a patch. I'm first resyncing the web platform tests for dialog (see https://bugs.webkit.org/show_bug.cgi?id=263838 & https://github.com/WebKit/WebKit/pull/19682). 1989997 4 webkit-bug-importer 2023-11-04 14:42:13 -0700 <rdar://problem/117949961> 1990041 5 ews-feeder 2023-11-05 08:33:49 -0800 Committed 270246@main (d23e04b12f79): <https://commits.webkit.org/270246@main> Reviewed commits have been landed. Closing PR #20007 and removing active labels.