<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>263775</bug_id>
          
          <creation_ts>2023-10-27 06:07:08 -0700</creation_ts>
          <short_desc>[Nicosia] Simplify NicosiaPlatformLayer</short_desc>
          <delta_ts>2023-10-30 23:01:15 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Garcia Campos">cgarcia</reporter>
          <assigned_to name="Carlos Garcia Campos">cgarcia</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1987973</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2023-10-27 06:07:08 -0700</bug_when>
    <thetext>We currently have generic classes that are created with a factory that creates the actual implementation. We only have one implementation, so we can just remove the unnecessary abstraction to save heap allocations, avoid casts and make the code easier to read.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1987977</commentid>
    <comment_count>1</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2023-10-27 06:14:23 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/19637</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1988771</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-10-30 23:00:02 -0700</bug_when>
    <thetext>Committed 269998@main (ee8fbcb55b4a): &lt;https://commits.webkit.org/269998@main&gt;

Reviewed commits have been landed. Closing PR #19637 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1988772</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-10-30 23:01:15 -0700</bug_when>
    <thetext>&lt;rdar://problem/117722993&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>