26377 2009-06-13 15:33:19 -0700 [GTK] Confusion about range of 'progress' property 2009-06-15 13:26:12 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 xan.lopez webkit-unassigned christian oldest_to_newest 125680 0 xan.lopez 2009-06-13 15:33:19 -0700 The definition of the property 'progress' in WebKitWebView says it goes from 0.0 to 1.0: g_object_class_install_property(objectClass, PROP_PROGRESS, g_param_spec_double("progress", "Progress", "Determines the current progress of the load", 0.0, 1.0, 1.0, WEBKIT_PARAM_READABLE)); But its actual implementation uses 0.0 to 100.0: gdouble webkit_web_view_get_progress(WebKitWebView* webView) { g_return_val_if_fail(WEBKIT_IS_WEB_VIEW(webView), 1.0); return lround(core(webView)->progress()->estimatedProgress() * 100); } Notice that even in the same function the error/default value is 1.0 ! 125948 1 31292 xan.lopez 2009-06-15 08:31:48 -0700 Created attachment 31292 progress.patch Do not multiply the value in get_progress by 100. 125953 2 31293 xan.lopez 2009-06-15 08:55:04 -0700 Created attachment 31293 progress.patch Ehm, get rid of the lround too, it's useless. 126015 3 31293 gustavo 2009-06-15 13:23:00 -0700 Comment on attachment 31293 progress.patch Yep! 126016 4 xan.lopez 2009-06-15 13:26:12 -0700 Thanks, landed as r44694. 31292 2009-06-15 08:31:48 -0700 2009-06-15 08:55:04 -0700 progress.patch progress.patch text/plain 3077 xan.lopez RnJvbSBjNjY1NTgxZDc0NzA5NTgxOWZmMTU3N2JhYzZiMWY4Mjk5ZGVhY2EzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiB4YW5Ad2Via2l0Lm9yZyA8eGFuQHdlYmtpdC5vcmdAMjY4ZjQ1 Y2MtY2QwOS0wNDEwLWFiM2MtZDUyNjkxYjRkYmZjPgpEYXRlOiBNb24sIDE1IEp1biAyMDA5IDE0 OjMxOjMzICswMDAwClN1YmplY3Q6IFtQQVRDSF0gMjAwOS0wNi0xNSAgWGFuIExvcGV6ICA8eGxv cGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IEd1c3Rhdm8gTm9yb25oYS4KCiAg ICAgICAgVmVyc2lvbiBidW1wIGluIHByZXBhcmF0aW9uIGZvciAxLjEuMTAgcmVsZWFzZS4KCiAg ICAgICAgKiBjb25maWd1cmUuYWM6CgpXZWJLaXQvZ3RrOgoKMjAwOS0wNi0xNSAgWGFuIExvcGV6 ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IEd1c3Rhdm8gTm9yb25o YS4KCiAgICAgICAgVXBkYXRlIE5FV1MgZm9yIDEuMS4xMCByZWxlYXNlLgoKICAgICAgICAqIE5F V1M6CgpnaXQtc3ZuLWlkOiBodHRwOi8vc3ZuLndlYmtpdC5vcmcvcmVwb3NpdG9yeS93ZWJraXQv dHJ1bmtANDQ2ODQgMjY4ZjQ1Y2MtY2QwOS0wNDEwLWFiM2MtZDUyNjkxYjRkYmZjCi0tLQogQ2hh bmdlTG9nICAgICAgICAgICAgfCAgICA4ICsrKysrKysrCiBXZWJLaXQvZ3RrL0NoYW5nZUxvZyB8 ICAgIDggKysrKysrKysKIFdlYktpdC9ndGsvTkVXUyAgICAgIHwgICAxNCArKysrKysrKysrKysr KwogY29uZmlndXJlLmFjICAgICAgICAgfCAgICA0ICsrLS0KIDQgZmlsZXMgY2hhbmdlZCwgMzIg aW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9D aGFuZ2VMb2cKaW5kZXggY2Y1N2Y4My4uODAyYTU2YiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisr KyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDExIEBACisyMDA5LTA2LTE1ICBYYW4gTG9wZXogIDx4 bG9wZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBHdXN0YXZvIE5vcm9uaGEu CisKKyAgICAgICAgVmVyc2lvbiBidW1wIGluIHByZXBhcmF0aW9uIGZvciAxLjEuMTAgcmVsZWFz ZS4KKworICAgICAgICAqIGNvbmZpZ3VyZS5hYzoKKwogMjAwOS0wNi0xMiAgVG9yIEFybmUgVmVz dGLDuCAgPHRvci5hcm5lLnZlc3Rib0Bub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg WGFuIExvcGV6LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgYi9XZWJLaXQvZ3Rr L0NoYW5nZUxvZwppbmRleCBhNjAxY2M0Li4yNDBjZTVlIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3Rr L0NoYW5nZUxvZworKysgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDExIEBACisy MDA5LTA2LTE1ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBHdXN0YXZvIE5vcm9uaGEuCisKKyAgICAgICAgVXBkYXRlIE5FV1MgZm9yIDEuMS4x MCByZWxlYXNlLgorCisgICAgICAgICogTkVXUzoKKwogMjAwOS0wNi0xMSAgR3VzdGF2byBOb3Jv bmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9w ZXouCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL05FV1MgYi9XZWJLaXQvZ3RrL05FV1MKaW5kZXgg NjVhOWZkZS4uMjNiODExNSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9ORVdTCisrKyBiL1dlYktp dC9ndGsvTkVXUwpAQCAtMSwzICsxLDE3IEBACis9PT09PT09PT09PT09PT09PQorV2ViS2l0R1RL KyAxLjEuMTAKKz09PT09PT09PT09PT09PT09CisKK1doYXQncyBuZXcgaW4gV2ViS2l0R1RLKyAx LjEuMTA/CisKKyAgLSBXZWJLaXROZXR3b3JrUmVxdWVzdCBoYXMgbm93IEdPYmplY3QgcHJvcGVy dGllcyBmb3IgaXRzIFVSSSBhbmQKKyAgICB0aGUgU291cE1lc3NhZ2UgdGhhdCBiYWNrcyBpdCB1 cC4KKyAgLSBGaXggQXRrVGV4dCBtZXRob2RzIGdldF9zZWxlY3Rpb24gYW5kIGdldF9uX3NlbGVj dGlvbnMgdG8gbm90IHVzZQorICAgIHRoZSBnbG9iYWwgc2VsZWN0aW9uIGJ1dCBvbmx5IHRoZSBz ZWxlY3Rpb24gdGhhdCBiZWxvbmdzIHRvIHRoZQorICAgIG9iamVjdCBiZWluZyB1c2VkLgorICAt IEZpeCBhIGNyYXNoZXIgd2hlbiBlbWl0dGluZyB0aGUgYTExeSBzaWduYWwgJ3RleHQtY2FyZXQt bW92ZWQnIGluCisgICAgc29tZSBzaXR1YXRpb25zIHdpdGggZGVidWcgYnVpbGRzLgorCiA9PT09 PT09PT09PT09PT09CiBXZWJLaXRHVEsrIDEuMS45CiA9PT09PT09PT09PT09PT09CmRpZmYgLS1n aXQgYS9jb25maWd1cmUuYWMgYi9jb25maWd1cmUuYWMKaW5kZXggM2NlYjRkMS4uYjcyMGE0MyAx MDA2NDQKLS0tIGEvY29uZmlndXJlLmFjCisrKyBiL2NvbmZpZ3VyZS5hYwpAQCAtMiw3ICsyLDcg QEAgQUNfUFJFUkVRKDIuNTkpCiAKIG00X2RlZmluZShbd2Via2l0X21ham9yX3ZlcnNpb25dLCBb MV0pCiBtNF9kZWZpbmUoW3dlYmtpdF9taW5vcl92ZXJzaW9uXSwgWzFdKQotbTRfZGVmaW5lKFt3 ZWJraXRfbWljcm9fdmVyc2lvbl0sIFs5XSkKK200X2RlZmluZShbd2Via2l0X21pY3JvX3ZlcnNp b25dLCBbMTBdKQogCiBBQ19JTklUKFtXZWJLaXRdLFt3ZWJraXRfbWFqb3JfdmVyc2lvbi53ZWJr aXRfbWlub3JfdmVyc2lvbi53ZWJraXRfbWljcm9fdmVyc2lvbl0sW2h0dHA6Ly9idWdzLndlYmtp dC5vcmcvXSkKIApAQCAtMjQsNyArMjQsNyBAQCBBQ19DT05GSUdfU1JDRElSKFtXZWJDb3JlL2Nv bmZpZy5oXSkKIAogZG5sICMgTGlidG9vbCBsaWJyYXJ5IHZlcnNpb24sIG5vdCB0byBjb25mdXNl IHdpdGggQVBJIHZlcnNpb24KIGRubCAjIHNlZSBodHRwOi8vd3d3LmdudS5vcmcvc29mdHdhcmUv bGlidG9vbC9tYW51YWwvaHRtbF9ub2RlL0xpYnRvb2wtdmVyc2lvbmluZy5odG1sI0xpYnRvb2wt dmVyc2lvbmluZwotTElCV0VCS0lUR1RLX1ZFUlNJT049ODoxOjYKK0xJQldFQktJVEdUS19WRVJT SU9OPTk6MDo3CiBBQ19TVUJTVChbTElCV0VCS0lUR1RLX1ZFUlNJT05dKQogCiBBTV9JTklUX0FV VE9NQUtFKFtmb3JlaWduIHN1YmRpci1vYmplY3RzIHRhci11c3Rhcl0pCi0tIAoxLjYuMy4xCgo= 31293 2009-06-15 08:55:04 -0700 2009-06-15 13:23:00 -0700 progress.patch progress.patch text/plain 1665 xan.lopez RnJvbSAwNTMxYjI0OTc5YjQzYWI0MTExNDhjMWE3ZjE3MzRjYmU2ZjNiMjFhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBN b24sIDE1IEp1biAyMDA5IDE4OjUzOjMyICswMzAwClN1YmplY3Q6IFtQQVRDSF0gMjAwOS0wNi0x NSAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKICAgICAgICBSYW5nZSBmb3IgdGhlIHByb2dyZXNzIHByb3BlcnR5IGlz IDAuMCAuLiAxLjAsIGRvbid0IG11bHRpcGx5IGl0CiAgICAgICAgYnkgMTAwIHRvIG1ha2UgaXQg YSBwZXJjZW50YWdlLgoKICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDoKICAgICAg ICAod2Via2l0X3dlYl92aWV3X2dldF9wcm9ncmVzcyk6Ci0tLQogV2ViS2l0L2d0ay9DaGFuZ2VM b2cgICAgICAgICAgICAgICAgfCAgIDEwICsrKysrKysrKysKIFdlYktpdC9ndGsvd2Via2l0L3dl YmtpdHdlYnZpZXcuY3BwIHwgICAgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCAxMSBpbnNlcnRpb25z KCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggMjQwY2U1ZS4uNmMxN2U1NyAxMDA2NDQKLS0tIGEv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsNSAr MSwxNSBAQAogMjAwOS0wNi0xNSAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CiAKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmFuZ2UgZm9yIHRo ZSBwcm9ncmVzcyBwcm9wZXJ0eSBpcyAwLjAgLi4gMS4wLCBkb24ndCBtdWx0aXBseSBpdAorICAg ICAgICBieSAxMDAgdG8gbWFrZSBpdCBhIHBlcmNlbnRhZ2UuCisKKyAgICAgICAgKiB3ZWJraXQv d2Via2l0d2Vidmlldy5jcHA6CisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfZ2V0X3Byb2dyZXNz KToKKworMjAwOS0wNi0xNSAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CisKICAgICAg ICAgUmV2aWV3ZWQgYnkgR3VzdGF2byBOb3JvbmhhLgogCiAgICAgICAgIFVwZGF0ZSBORVdTIGZv ciAxLjEuMTAgcmVsZWFzZS4KZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdl YnZpZXcuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggNDBj MzgyMi4uMmJiN2EwYiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmll dy5jcHAKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTMyODIs NyArMzI4Miw3IEBAIGdkb3VibGUgd2Via2l0X3dlYl92aWV3X2dldF9wcm9ncmVzcyhXZWJLaXRX ZWJWaWV3KiB3ZWJWaWV3KQogewogICAgIGdfcmV0dXJuX3ZhbF9pZl9mYWlsKFdFQktJVF9JU19X RUJfVklFVyh3ZWJWaWV3KSwgMS4wKTsKIAotICAgIHJldHVybiBscm91bmQoY29yZSh3ZWJWaWV3 KS0+cHJvZ3Jlc3MoKS0+ZXN0aW1hdGVkUHJvZ3Jlc3MoKSAqIDEwMCk7CisgICAgcmV0dXJuIGNv cmUod2ViVmlldyktPnByb2dyZXNzKCktPmVzdGltYXRlZFByb2dyZXNzKCk7CiB9CiAKIC8qKgot LSAKMS42LjMuMQoK