<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>263634</bug_id>
          
          <creation_ts>2023-10-24 22:59:30 -0700</creation_ts>
          <short_desc>[GTK] Build error in Debian stable after 269634@main</short_desc>
          <delta_ts>2023-10-30 09:38:37 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Diego Pino">dpino</reporter>
          <assigned_to name="Diego Pino">dpino</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1987321</commentid>
    <comment_count>0</comment_count>
    <who name="Diego Pino">dpino</who>
    <bug_when>2023-10-24 22:59:30 -0700</bug_when>
    <thetext>GTK-Linux-64-bit-Release-Debian-Stable-Build is failing with the following build error:

```
../../Source/WebKit/WebProcess/WebPage/gtk/AcceleratedSurfaceDMABuf.cpp: In static member function ‘static std::unique_ptr&lt;WebKit::AcceleratedSurfaceDMABuf::RenderTarget&gt; WebKit::AcceleratedSurfaceDMABuf::RenderTargetEGLImage::create(uint64_t, const WebCore::IntSize&amp;, const WebKit::DMABufRendererBufferFormat&amp;)’:
../../Source/WebKit/WebProcess/WebPage/gtk/AcceleratedSurfaceDMABuf.cpp:173:37: error: ‘gbm_bo_get_fd_for_plane’ was not declared in this scope; did you mean ‘gbm_bo_get_handle_for_plane’?
  173 |     fds.append(UnixFileDescriptor { gbm_bo_get_fd_for_plane(bo, planeIndex), UnixFileDescriptor::Adopt }); \
      |                                     ^~~~~~~~~~~~~~~~~~~~~~~
```

It seems `gbm_bo_get_fd_for_plane` is only available since Mesa 21 onwards and Debian Stable (Debian 11) only features Mesa 20. Debian 11 has support until 10th June 2024.

Perhaps is possible to work around this function, in case not it would be needed to install Mesa 21 in Debian 11 via system libraries (Debian and Ubuntu bots build with --no-experimental-features, thus using only system libraries). In case none of these solutions would be possible, then use flag USE_GBM=OFF in Debian.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1987355</commentid>
    <comment_count>1</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2023-10-25 02:48:18 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/19528</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1987393</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-10-25 07:35:17 -0700</bug_when>
    <thetext>Committed 269760@main (e5ec96108a23): &lt;https://commits.webkit.org/269760@main&gt;

Reviewed commits have been landed. Closing PR #19528 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1987394</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-10-25 07:36:15 -0700</bug_when>
    <thetext>&lt;rdar://problem/117474092&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1988462</commentid>
    <comment_count>4</comment_count>
    <who name="Diego Pino">dpino</who>
    <bug_when>2023-10-30 05:23:50 -0700</bug_when>
    <thetext>The build for Debian is still failing with error:

```
&lt;CXX&gt; -DBUILDING_GTK__=1 -DBUILDING_WEBKIT=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_WebKit -DDATADIR=\&quot;/usr/local/share\&quot; -DGETTEXT_PACKAGE=\&quot;WebKitGTK-4.1\&quot; -DHAVE_CONFIG_H=1 -DJSC_GLIB_API_ENABLED -DLIBDIR=\&quot;/usr/local/lib\&quot; -DLOCALEDIR=\&quot;/usr/local/share/locale\&quot; -DPAS_BMALLO
../../../Source/WebKit/WebProcess/WebPage/gtk/AcceleratedSurfaceDMABuf.cpp:188:9: error: use of undeclared identifier &apos;gbm_bo_get_fd_for_plane&apos;; did you mean &apos;gbm_bo_get_fd_for_plane2&apos;?
        ADD_PLANE_ATTRIBUTES(0);
        ^
```</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1988463</commentid>
    <comment_count>5</comment_count>
    <who name="Diego Pino">dpino</who>
    <bug_when>2023-10-30 05:24:53 -0700</bug_when>
    <thetext>Re-opening for pull request https://github.com/webkit/webkit/pull/19713</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1988528</commentid>
    <comment_count>6</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-10-30 09:38:35 -0700</bug_when>
    <thetext>Committed 269949@main (97784c574981): &lt;https://commits.webkit.org/269949@main&gt;

Reviewed commits have been landed. Closing PR #19713 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>