263615 2023-10-24 14:42:59 -0700 The URL move constructor doesn't invalidate the "moved-out" URL 2023-10-24 22:51:15 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=263574 InRadar P2 Normal --- 1 cdumez cdumez webkit-bug-importer oldest_to_newest 1987238 0 cdumez 2023-10-24 14:42:59 -0700 The URL move constructor doesn't invalidate the "moved-out" URL. This can lead WebKit code to do weird things. For example, URLKeepingBlobAlive contains a m_url data member and is often moved-out to pass to a lambda. The destructor of the "moved-out" URLKeepingBlobAlive then runs and calls `unregisterBlobURLHandleIfNecessary()`. `unregisterBlobURLHandleIfNecessary()` will try to use m_url after it's been moved out to see if the URL protocol is "blob". This causes URL::protocolIs() to try to do out-of-bound access in the underlying String (since the URL is marked as valid, even though it's m_string was moved out and other data members that are indexes into that string were not reset). Luckily, String's operator[] just returns nil when doing an out of bounds access at the moment. 1987244 1 cdumez 2023-10-24 15:12:24 -0700 Pull request: https://github.com/WebKit/WebKit/pull/19512 1987319 2 ews-feeder 2023-10-24 22:50:24 -0700 Committed 269750@main (e68882fc2467): <https://commits.webkit.org/269750@main> Reviewed commits have been landed. Closing PR #19512 and removing active labels. 1987320 3 webkit-bug-importer 2023-10-24 22:51:15 -0700 <rdar://problem/117454783>