263578 2023-10-23 20:33:56 -0700 Rename webrtc::pixelBufferFrom* functions to have 'create' in the name and fix a CVPixelBufferRef leak 2023-10-24 20:12:44 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser simon.fraser webkit-bug-importer youennf oldest_to_newest 1987053 0 simon.fraser 2023-10-23 20:33:56 -0700 These functions return retained values, so should have 'create' in the name: CVPixelBufferRef pixelBufferFromI420Buffer(const uint8_t* buffer, size_t length, size_t width, size_t height, I420BufferLayout) CF_RETURNS_RETAINED; CVPixelBufferRef pixelBufferFromI420ABuffer(const uint8_t* buffer, size_t length, size_t width, size_t height, I420ABufferLayout) CF_RETURNS_RETAINED; 1987054 1 webkit-bug-importer 2023-10-23 20:34:15 -0700 <rdar://problem/117388614> 1987055 2 simon.fraser 2023-10-23 20:35:50 -0700 Pull request: https://github.com/WebKit/WebKit/pull/19471 1987309 3 ews-feeder 2023-10-24 20:12:42 -0700 Committed 269747@main (11a2ba1a7a1c): <https://commits.webkit.org/269747@main> Reviewed commits have been landed. Closing PR #19471 and removing active labels.