26354 2009-06-12 13:42:14 -0700 [Gtk] GStreamer-CRITICAL's (and other warnings) on <video> 2009-11-24 10:55:26 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 bunk webkit-unassigned commit-queue gustavo jmalonzo pnormand oldest_to_newest 125518 0 bunk 2009-06-12 13:42:14 -0700 - Liferea 1.6 - WekKitGtk+ 1.1.9 - Debian unstable, only installed GStreamer packages are libgstreamer-plugins-base0.10-0 and libgstreamer0.10-0 - viewing http://macslow.net/?p=278 (contains an ogg/theora <video>) I'll attach the complete log of the warnings and the trace of the first warning. 125519 1 31210 bunk 2009-06-12 13:43:18 -0700 Created attachment 31210 warnings displayed 125520 2 31211 bunk 2009-06-12 13:44:05 -0700 Created attachment 31211 backtrace of the first GStreamer-CRITICAL 125522 3 bunk 2009-06-12 13:54:46 -0700 Note: I do not expect to see the video in this case, but some proper error handling. 149419 4 pnormand 2009-09-23 09:46:36 -0700 With git WebKitGtk+ and git GStreamer I don't see any warning, either when the page loads or when I play the video. 149447 5 bunk 2009-09-23 10:47:48 -0700 (In reply to comment #4) > With git WebKitGtk+ and git GStreamer I don't see any warning, either when the > page loads or when I play the video. When you are able to play the video you are obviously outside the scope of this bug. Please remove all GStreamer plugins except for the base ones and retry. 149698 6 pnormand 2009-09-24 01:43:47 -0700 (In reply to comment #5) > (In reply to comment #4) > > With git WebKitGtk+ and git GStreamer I don't see any warning, either when the > > page loads or when I play the video. > > When you are able to play the video you are obviously outside the scope of this > bug. > > Please remove all GStreamer plugins except for the base ones and retry. If I remove the gstreamer ogg plugin the page in MacSlow's blog still loads fine without gst warning. Can you test again please? I think this bug can be closed. 164368 7 bunk 2009-11-17 15:47:00 -0800 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > With git WebKitGtk+ and git GStreamer I don't see any warning, either when the > > > page loads or when I play the video. > > > > When you are able to play the video you are obviously outside the scope of this > > bug. > > > > Please remove all GStreamer plugins except for the base ones and retry. > > If I remove the gstreamer ogg plugin the page in MacSlow's blog still loads > fine without gst warning. Can you test again please? I think this bug can be > closed. No, it is still present with 1.1.16. You were trying to remove the wrong plugin. /usr/lib/gstreamer-0.10/libgstplaybin.so (just look at the trace in comment #2) is the file you have to remove for reproducing this bug. 166025 8 43757 pnormand 2009-11-24 02:10:05 -0800 Created attachment 43757 Implemented MediaPlayerPrivate::isAvailable by checking the presence of the playbin2 GStreamer element. 166030 9 43757 gustavo 2009-11-24 03:52:18 -0800 Comment on attachment 43757 Implemented MediaPlayerPrivate::isAvailable by checking the presence of the playbin2 GStreamer element. Good. Do you need someone to commit this, or you have commit privileges by now? Some nits:  163 bool available = false;  164 GstElementFactory* factory;  165  166 do_gst_init();  167 factory = gst_element_factory_find("playbin2"); factory should only be declared here, where it is first used. Perhaps you can also lose the available variable, and just return true inside the if (factory) check, returning false otherwise. 166031 10 pnormand 2009-11-24 04:01:07 -0800 (In reply to comment #9) > (From update of attachment 43757 [details]) > Good. Do you need someone to commit this, or you have commit privileges by now? > Received the invitation today, might take some time for the paper work to be done ;) > Some nits: > >  163 bool available = false; >  164 GstElementFactory* factory; >  165 >  166 do_gst_init(); >  167 factory = gst_element_factory_find("playbin2"); > > factory should only be declared here, where it is first used. Perhaps you can > also lose the available variable, and just return true inside the if (factory) > check, returning false otherwise. I used a factory variable because the return value of gst_element_factory_find needs to be unreffed after use. Do you want me to send a new patch? 166032 11 gustavo 2009-11-24 04:05:27 -0800 (In reply to comment #10) > > Some nits: > > > >  163 bool available = false; > >  164 GstElementFactory* factory; > >  165 > >  166 do_gst_init(); > >  167 factory = gst_element_factory_find("playbin2"); > > > > factory should only be declared here, where it is first used. Perhaps you can > > also lose the available variable, and just return true inside the if (factory) > > check, returning false otherwise. > > I used a factory variable because the return value of gst_element_factory_find > needs to be unreffed after use. Yeah. You do need factory. What you could do to it is use GOwnPtr. The variable I say you should lose is 'bool available'. You can just return true inside the if that checks for factory. If you can't commit, then yeah, please upload a new patch =) 166045 12 43763 pnormand 2009-11-24 05:55:28 -0800 Created attachment 43763 Implemented MediaPlayerPrivate::isAvailable by checking the presence of the playbin2 GStreamer element. 166046 13 43764 pnormand 2009-11-24 05:58:33 -0800 Created attachment 43764 Implemented MediaPlayerPrivate::isAvailable by checking the presence of the playbin2 GStreamer element. 166165 14 43764 gustavo 2009-11-24 10:41:41 -0800 Comment on attachment 43764 Implemented MediaPlayerPrivate::isAvailable by checking the presence of the playbin2 GStreamer element. Thanks. 166183 15 43764 commit-queue 2009-11-24 10:55:21 -0800 Comment on attachment 43764 Implemented MediaPlayerPrivate::isAvailable by checking the presence of the playbin2 GStreamer element. Clearing flags on attachment: 43764 Committed r51343: <http://trac.webkit.org/changeset/51343> 166184 16 commit-queue 2009-11-24 10:55:26 -0800 All reviewed patches have been landed. Closing bug. 31210 2009-06-12 13:43:18 -0700 2009-06-12 13:43:18 -0700 warnings displayed gst-warnings-no-ffmpeg text/plain 1484 bunk KGxpZmVyZWE6MTg2MzApOiBHU3RyZWFtZXItQ1JJVElDQUwgKio6IGdzdF9lbGVtZW50X2dldF9i dXM6IGFzc2VydGlvbiBgR1NUX0lTX0VMRU1FTlQgKGVsZW1lbnQpJyBmYWlsZWQKCihsaWZlcmVh OjE4NjMwKTogR1N0cmVhbWVyLUNSSVRJQ0FMICoqOiBnc3RfYnVzX2FkZF9zaWduYWxfd2F0Y2hf ZnVsbDogYXNzZXJ0aW9uIGBHU1RfSVNfQlVTIChidXMpJyBmYWlsZWQKCihsaWZlcmVhOjE4NjMw KTogR0xpYi1HT2JqZWN0LVdBUk5JTkcgKio6IGludmFsaWQgKE5VTEwpIHBvaW50ZXIgaW5zdGFu Y2UKCihsaWZlcmVhOjE4NjMwKTogR0xpYi1HT2JqZWN0LUNSSVRJQ0FMICoqOiBnX3NpZ25hbF9j b25uZWN0X2RhdGE6IGFzc2VydGlvbiBgR19UWVBFX0NIRUNLX0lOU1RBTkNFIChpbnN0YW5jZSkn IGZhaWxlZAoKKGxpZmVyZWE6MTg2MzApOiBHTGliLUdPYmplY3QtV0FSTklORyAqKjogaW52YWxp ZCAoTlVMTCkgcG9pbnRlciBpbnN0YW5jZQoKKGxpZmVyZWE6MTg2MzApOiBHTGliLUdPYmplY3Qt Q1JJVElDQUwgKio6IGdfc2lnbmFsX2Nvbm5lY3RfZGF0YTogYXNzZXJ0aW9uIGBHX1RZUEVfQ0hF Q0tfSU5TVEFOQ0UgKGluc3RhbmNlKScgZmFpbGVkCgoobGlmZXJlYToxODYzMCk6IEdMaWItR09i amVjdC1XQVJOSU5HICoqOiBpbnZhbGlkIChOVUxMKSBwb2ludGVyIGluc3RhbmNlCgoobGlmZXJl YToxODYzMCk6IEdMaWItR09iamVjdC1DUklUSUNBTCAqKjogZ19zaWduYWxfY29ubmVjdF9kYXRh OiBhc3NlcnRpb24gYEdfVFlQRV9DSEVDS19JTlNUQU5DRSAoaW5zdGFuY2UpJyBmYWlsZWQKCihs aWZlcmVhOjE4NjMwKTogR0xpYi1HT2JqZWN0LVdBUk5JTkcgKio6IGludmFsaWQgKE5VTEwpIHBv aW50ZXIgaW5zdGFuY2UKCihsaWZlcmVhOjE4NjMwKTogR0xpYi1HT2JqZWN0LUNSSVRJQ0FMICoq OiBnX3NpZ25hbF9jb25uZWN0X2RhdGE6IGFzc2VydGlvbiBgR19UWVBFX0NIRUNLX0lOU1RBTkNF IChpbnN0YW5jZSknIGZhaWxlZAoKKGxpZmVyZWE6MTg2MzApOiBHU3RyZWFtZXItQ1JJVElDQUwg Kio6IGdzdF9vYmplY3RfdW5yZWY6IGFzc2VydGlvbiBgb2JqZWN0ICE9IE5VTEwnIGZhaWxlZAoK KGxpZmVyZWE6MTg2MzApOiBHTGliLUdPYmplY3QtQ1JJVElDQUwgKio6IGdfb2JqZWN0X3NldDog YXNzZXJ0aW9uIGBHX0lTX09CSkVDVCAob2JqZWN0KScgZmFpbGVkCgoobGlmZXJlYToxODYzMCk6 IEdMaWItR09iamVjdC1DUklUSUNBTCAqKjogZ19vYmplY3Rfc2V0OiBhc3NlcnRpb24gYEdfSVNf T0JKRUNUIChvYmplY3QpJyBmYWlsZWQKCihsaWZlcmVhOjE4NjMwKTogR0xpYi1HT2JqZWN0LUNS SVRJQ0FMICoqOiBnX29iamVjdF9zZXQ6IGFzc2VydGlvbiBgR19JU19PQkpFQ1QgKG9iamVjdCkn IGZhaWxlZAoKKGxpZmVyZWE6MTg2MzApOiBHU3RyZWFtZXItQ1JJVElDQUwgKio6IGdzdF9lbGVt ZW50X3NldF9zdGF0ZTogYXNzZXJ0aW9uIGBHU1RfSVNfRUxFTUVOVCAoZWxlbWVudCknIGZhaWxl ZAo= 31211 2009-06-12 13:44:05 -0700 2009-06-12 13:44:05 -0700 backtrace of the first GStreamer-CRITICAL gst-bt-no-ffmpeg text/plain 2511 bunk IzAgIElBX19nX2xvZyAobG9nX2RvbWFpbj0weDdmNGVhZTMzOGM1OCAiR1N0cmVhbWVyIiwgCiAg ICBsb2dfbGV2ZWw9R19MT0dfTEVWRUxfQ1JJVElDQUwsIAogICAgZm9ybWF0PTB4N2Y0ZWIwMzkx NjVkICIlczogYXNzZXJ0aW9uIGAlcycgZmFpbGVkIikKICAgIGF0IC90bXAvYnVpbGRkL2dsaWIy LjAtMi4yMC4zL2dsaWIvZ21lc3NhZ2VzLmM6NTIyCiMxICAweDAwMDA3ZjRlYWUyZGRlYmQgaW4g Z3N0X2VsZW1lbnRfZ2V0X2J1cyAoKQogICBmcm9tIC91c3IvbGliL2xpYmdzdHJlYW1lci0wLjEw LnNvLjAKIzIgIDB4MDAwMDdmNGViNDAyNDkzZSBpbiBXZWJDb3JlOjpNZWRpYVBsYXllclByaXZh dGU6OmNyZWF0ZUdTVFBsYXlCaW4gKAogICAgdGhpcz0weDdmNGU5ZWMxN2Q4MCwgdXJsPURXQVJG LTIgZXhwcmVzc2lvbiBlcnJvcjogRFdfT1BfcmVnIG9wZXJhdGlvbnMgbXVzdCBiZSB1c2VkIGVp dGhlciBhbG9uZSBvciBpbiBjb25qdWN0aW9uIHdpdGggRFdfT1BfcGllY2UuCikKICAgIGF0IC4u L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ci5jcHA6NjI1CiMzICAweDAwMDA3ZjRlYjQwMjU4ODQgaW4gV2ViQ29yZTo6TWVkaWFQbGF5ZXJQ cml2YXRlOjpsb2FkICgKICAgIHRoaXM9MHg3ZjRlOWVjMTdkODAsIHVybD1AMHg3ZjRlOWViZmI1 ODgpCiAgICBhdCAuLi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclBy aXZhdGVHU3RyZWFtZXIuY3BwOjE3MQojNCAgMHgwMDAwN2Y0ZWIzZWVjODczIGluIFdlYkNvcmU6 Ok1lZGlhUGxheWVyOjpsb2FkICh0aGlzPTB4N2Y0ZTllYTZhMTAwLCAKICAgIHVybD1AMHg3ZjRl OWViZmI1ODgsIGNvbnRlbnRUeXBlPTx2YWx1ZSBvcHRpbWl6ZWQgb3V0PikKICAgIGF0IC4uL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3BwOjI0MQojNSAgMHgwMDAwN2Y0 ZWIzZWU3MjcwIGluIFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmxvYWRSZXNvdXJjZSAoCiAg ICB0aGlzPTB4N2Y0ZTllYmZiNDAwLCB1cmw9PHZhbHVlIG9wdGltaXplZCBvdXQ+LCAKICAgIGNv bnRlbnRUeXBlPUAweDdmZmYzZGIzMjUwMCkgYXQgLi4vV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVs ZW1lbnQuY3BwOjUwMAojNiAgMHgwMDAwN2Y0ZWIzZWVhMmU5IGluIFdlYkNvcmU6OkhUTUxNZWRp YUVsZW1lbnQ6OnNlbGVjdE1lZGlhUmVzb3VyY2UgKAogICAgdGhpcz0weDdmNGU5ZWJmYjQwMCkg YXQgLi4vV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOjQ1MQojNyAgMHgwMDAwN2Y0 ZWIzZWVhNWJlIGluIFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmxvYWRJbnRlcm5hbCAoCiAg ICB0aGlzPTB4N2Y0ZTllYmZiNDAwKSBhdCAuLi9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVu dC5jcHA6NDE1CiM4ICAweDAwMDA3ZjRlYjNkODNjZjMgaW4gV2ViQ29yZTo6VGhyZWFkVGltZXJz OjpmaXJlVGltZXJzICgKICAgIHRoaXM9MHg3ZjRlYTY3ZDM3NDAsIGZpcmVUaW1lPTx2YWx1ZSBv cHRpbWl6ZWQgb3V0PiwgCiAgICBmaXJpbmdUaW1lcnM9QDB4N2ZmZjNkYjMyNWQwKSBhdCAuLi9X ZWJDb3JlL3BsYXRmb3JtL1RocmVhZFRpbWVycy5jcHA6MTExCiM5ICAweDAwMDA3ZjRlYjNkODNk YTEgaW4gV2ViQ29yZTo6VGhyZWFkVGltZXJzOjpzaGFyZWRUaW1lckZpcmVkSW50ZXJuYWwgKAog ICAgdGhpcz0weDdmNGVhNjdkMzc0MCkgYXQgLi4vV2ViQ29yZS9wbGF0Zm9ybS9UaHJlYWRUaW1l cnMuY3BwOjE0MQojMTAgMHgwMDAwN2Y0ZWI0MDExOGYyIGluIHRpbWVvdXRfY2IgKCkKICAgIGF0 IC4uL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1NoYXJlZFRpbWVyR3RrLmNwcDo0OAojMTEgMHgwMDAw N2Y0ZWIwMzUwZjdhIGluIElBX19nX21haW5fY29udGV4dF9kaXNwYXRjaCAoY29udGV4dD0weDE4 OTllNjApCiAgICBhdCAvdG1wL2J1aWxkZC9nbGliMi4wLTIuMjAuMy9nbGliL2dtYWluLmM6MTgx NAojMTIgMHgwMDAwN2Y0ZWIwMzU0NWY4IGluIGdfbWFpbl9jb250ZXh0X2l0ZXJhdGUgKGNvbnRl eHQ9MHgxODk5ZTYwLCBibG9jaz0xLCAKICAgIGRpc3BhdGNoPTEsIHNlbGY9PHZhbHVlIG9wdGlt aXplZCBvdXQ+KQogICAgYXQgL3RtcC9idWlsZGQvZ2xpYjIuMC0yLjIwLjMvZ2xpYi9nbWFpbi5j OjI0NDUKIzEzIDB4MDAwMDdmNGViMDM1NGFlZCBpbiBJQV9fZ19tYWluX2xvb3BfcnVuIChsb29w PTB4MWViN2M3MCkKICAgIGF0IC90bXAvYnVpbGRkL2dsaWIyLjAtMi4yMC4zL2dsaWIvZ21haW4u YzoyNjUzCiMxNCAweDAwMDA3ZjRlYjI5NTU4NjcgaW4gSUFfX2d0a19tYWluICgpCiAgICBhdCAv aG9tZS9zbG9tby9wcm9qZWN0cy9kZWJpYW4vcGtnLWdub21lL2Rlc2t0b3AvdW5zdGFibGUvYnVp bGQtYXJlYS9ndGsrMi4wLTIuMTYuMi9ndGsvZ3RrbWFpbi5jOjEyMDUKIzE1IDB4MDAwMDAwMDAw MDQzNDEwMCBpbiBtYWluIChhcmdjPTEsIGFyZ3Y9MHg3ZmZmM2RiMzJjNjgpIGF0IG1haW4uYzoz NDQK 43757 2009-11-24 02:10:05 -0800 2009-11-24 05:55:28 -0800 Implemented MediaPlayerPrivate::isAvailable by checking the presence of the playbin2 GStreamer element. Implemented-MediaPlayerPrivateisAvailable-by-check.patch text/plain 2780 pnormand RnJvbSAwZDNhZWIwYmZkOGE5NTJjMTZlMGFlNTNmMDc3ZDdkY2M1YzU0MWNhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDI0IE5vdiAyMDA5IDExOjA2OjQxICswMTAwClN1YmplY3Q6IFtQQVRDSF0g SW1wbGVtZW50ZWQgTWVkaWFQbGF5ZXJQcml2YXRlOjppc0F2YWlsYWJsZSBieSBjaGVja2luZyB0 aGUgcHJlc2VuY2Ugb2YgdGhlIHBsYXliaW4yIEdTdHJlYW1lciBlbGVtZW50LgoKLS0tCiBXZWJD b3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTQgKysr KysrKysrKysrKysKIC4uLi9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy LmNwcCAgIHwgICAxNCArKysrKysrKysrKysrKwogLi4uL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXll clByaXZhdGVHU3RyZWFtZXIuaCAgICAgfCAgICAyICstCiAzIGZpbGVzIGNoYW5nZWQsIDI5IGlu c2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VM b2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwOTg1YTRhLi4yZDI4Y2M1IDEwMDY0NAotLS0g YS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDA5LTExLTI0ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR3RrXSBH U3RyZWFtZXItQ1JJVElDQUwncyAoYW5kIG90aGVyIHdhcm5pbmdzKSBvbiA8dmlkZW8+CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjM1NAorCisgICAg ICAgIEltcGxlbWVudGVkIE1lZGlhUGxheWVyUHJpdmF0ZTo6aXNBdmFpbGFibGUgYnkgY2hlY2tp bmcgdGhlCisgICAgICAgIHByZXNlbmNlIG9mIHRoZSBwbGF5YmluMiBHU3RyZWFtZXIgZWxlbWVu dC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlOjppc0F2 YWlsYWJsZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lci5oOgorCiAyMDA5LTExLTIzICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEu Z29tYm9zQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENo cmlzdGlhbnNlbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01l ZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IDRmODVmNzkuLjlkMGU1 MDcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVy UHJpdmF0ZUdTdHJlYW1lci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsv TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcApAQCAtMTU4LDYgKzE1OCwyMCBAQCBzdGF0 aWMgdm9pZCBkb19nc3RfaW5pdCgpCiAgICAgfQogfQogCitib29sIE1lZGlhUGxheWVyUHJpdmF0 ZTo6aXNBdmFpbGFibGUoKQoreworICAgIGJvb2wgYXZhaWxhYmxlID0gZmFsc2U7CisgICAgR3N0 RWxlbWVudEZhY3RvcnkqIGZhY3Rvcnk7CisKKyAgICBkb19nc3RfaW5pdCgpOworICAgIGZhY3Rv cnkgPSBnc3RfZWxlbWVudF9mYWN0b3J5X2ZpbmQoInBsYXliaW4yIik7CisgICAgaWYgKGZhY3Rv cnkpIHsKKyAgICAgICAgYXZhaWxhYmxlID0gdHJ1ZTsKKyAgICAgICAgZ3N0X29iamVjdF91bnJl ZihHU1RfT0JKRUNUKGZhY3RvcnkpKTsKKyAgICB9CisgICAgcmV0dXJuIGF2YWlsYWJsZTsKK30K KwogTWVkaWFQbGF5ZXJQcml2YXRlOjpNZWRpYVBsYXllclByaXZhdGUoTWVkaWFQbGF5ZXIqIHBs YXllcikKICAgICA6IG1fcGxheWVyKHBsYXllcikKICAgICAsIG1fcGxheUJpbigwKQpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyLmggYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZh dGVHU3RyZWFtZXIuaAppbmRleCAxZWNiYzQ2Li42YWI4ZWRiIDEwMDY0NAotLS0gYS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuaAorKysg Yi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXIuaApAQCAtMTA5LDcgKzEwOSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgICAgICAg ICAgc3RhdGljIHZvaWQgZ2V0U3VwcG9ydGVkVHlwZXMoSGFzaFNldDxTdHJpbmc+Jik7CiAgICAg ICAgICAgICBzdGF0aWMgTWVkaWFQbGF5ZXI6OlN1cHBvcnRzVHlwZSBzdXBwb3J0c1R5cGUoY29u c3QgU3RyaW5nJiB0eXBlLCBjb25zdCBTdHJpbmcmIGNvZGVjcyk7Ci0gICAgICAgICAgICBzdGF0 aWMgYm9vbCBpc0F2YWlsYWJsZSgpIHsgcmV0dXJuIHRydWU7IH0KKyAgICAgICAgICAgIHN0YXRp YyBib29sIGlzQXZhaWxhYmxlKCk7CiAKICAgICAgICAgICAgIHZvaWQgdXBkYXRlU3RhdGVzKCk7 CiAgICAgICAgICAgICB2b2lkIGNhbmNlbFNlZWsoKTsKLS0gCjEuNi4zLjM= 43763 2009-11-24 05:55:28 -0800 2009-11-24 05:58:33 -0800 Implemented MediaPlayerPrivate::isAvailable by checking the presence of the playbin2 GStreamer element. Implemented-MediaPlayerPrivateisAvailable-by-check.patch text/plain 2780 pnormand RnJvbSA0MWQ1NmQwNjViYTVlYjBlNGYxYWJjZGZmMDg1ZTFlYzZlOTFjZGNkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDI0IE5vdiAyMDA5IDExOjA2OjQxICswMTAwClN1YmplY3Q6IFtQQVRDSF0g SW1wbGVtZW50ZWQgTWVkaWFQbGF5ZXJQcml2YXRlOjppc0F2YWlsYWJsZSBieSBjaGVja2luZyB0 aGUgcHJlc2VuY2Ugb2YgdGhlIHBsYXliaW4yIEdTdHJlYW1lciBlbGVtZW50LgoKLS0tCiBXZWJD b3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTQgKysr KysrKysrKysrKysKIC4uLi9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy LmNwcCAgIHwgICAxNCArKysrKysrKysrKysrKwogLi4uL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXll clByaXZhdGVHU3RyZWFtZXIuaCAgICAgfCAgICAyICstCiAzIGZpbGVzIGNoYW5nZWQsIDI5IGlu c2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VM b2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwOTg1YTRhLi4yZDI4Y2M1IDEwMDY0NAotLS0g YS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDA5LTExLTI0ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR3RrXSBH U3RyZWFtZXItQ1JJVElDQUwncyAoYW5kIG90aGVyIHdhcm5pbmdzKSBvbiA8dmlkZW8+CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjM1NAorCisgICAg ICAgIEltcGxlbWVudGVkIE1lZGlhUGxheWVyUHJpdmF0ZTo6aXNBdmFpbGFibGUgYnkgY2hlY2tp bmcgdGhlCisgICAgICAgIHByZXNlbmNlIG9mIHRoZSBwbGF5YmluMiBHU3RyZWFtZXIgZWxlbWVu dC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlOjppc0F2 YWlsYWJsZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lci5oOgorCiAyMDA5LTExLTIzICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEu Z29tYm9zQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENo cmlzdGlhbnNlbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01l ZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IDRmODVmNzkuLjlkMGU1 MDcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVy UHJpdmF0ZUdTdHJlYW1lci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsv TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcApAQCAtMTU4LDYgKzE1OCwyMCBAQCBzdGF0 aWMgdm9pZCBkb19nc3RfaW5pdCgpCiAgICAgfQogfQogCitib29sIE1lZGlhUGxheWVyUHJpdmF0 ZTo6aXNBdmFpbGFibGUoKQoreworICAgIGJvb2wgYXZhaWxhYmxlID0gZmFsc2U7CisgICAgR3N0 RWxlbWVudEZhY3RvcnkqIGZhY3Rvcnk7CisKKyAgICBkb19nc3RfaW5pdCgpOworICAgIGZhY3Rv cnkgPSBnc3RfZWxlbWVudF9mYWN0b3J5X2ZpbmQoInBsYXliaW4yIik7CisgICAgaWYgKGZhY3Rv cnkpIHsKKyAgICAgICAgYXZhaWxhYmxlID0gdHJ1ZTsKKyAgICAgICAgZ3N0X29iamVjdF91bnJl ZihHU1RfT0JKRUNUKGZhY3RvcnkpKTsKKyAgICB9CisgICAgcmV0dXJuIGF2YWlsYWJsZTsKK30K KwogTWVkaWFQbGF5ZXJQcml2YXRlOjpNZWRpYVBsYXllclByaXZhdGUoTWVkaWFQbGF5ZXIqIHBs YXllcikKICAgICA6IG1fcGxheWVyKHBsYXllcikKICAgICAsIG1fcGxheUJpbigwKQpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyLmggYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZh dGVHU3RyZWFtZXIuaAppbmRleCAxZWNiYzQ2Li42YWI4ZWRiIDEwMDY0NAotLS0gYS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuaAorKysg Yi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXIuaApAQCAtMTA5LDcgKzEwOSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgICAgICAg ICAgc3RhdGljIHZvaWQgZ2V0U3VwcG9ydGVkVHlwZXMoSGFzaFNldDxTdHJpbmc+Jik7CiAgICAg ICAgICAgICBzdGF0aWMgTWVkaWFQbGF5ZXI6OlN1cHBvcnRzVHlwZSBzdXBwb3J0c1R5cGUoY29u c3QgU3RyaW5nJiB0eXBlLCBjb25zdCBTdHJpbmcmIGNvZGVjcyk7Ci0gICAgICAgICAgICBzdGF0 aWMgYm9vbCBpc0F2YWlsYWJsZSgpIHsgcmV0dXJuIHRydWU7IH0KKyAgICAgICAgICAgIHN0YXRp YyBib29sIGlzQXZhaWxhYmxlKCk7CiAKICAgICAgICAgICAgIHZvaWQgdXBkYXRlU3RhdGVzKCk7 CiAgICAgICAgICAgICB2b2lkIGNhbmNlbFNlZWsoKTsKLS0gCjEuNi4zLjM= 43764 2009-11-24 05:58:33 -0800 2009-11-24 10:55:21 -0800 Implemented MediaPlayerPrivate::isAvailable by checking the presence of the playbin2 GStreamer element. Implemented-MediaPlayerPrivateisAvailable-by-check.patch text/plain 2723 pnormand RnJvbSA3Mzg1OTFlZTRhMjhmNTBjOGY2MWMzM2YxZTAyNGE1MDM0MWQ5YTNhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDI0IE5vdiAyMDA5IDExOjA2OjQxICswMTAwClN1YmplY3Q6IFtQQVRDSF0g SW1wbGVtZW50ZWQgTWVkaWFQbGF5ZXJQcml2YXRlOjppc0F2YWlsYWJsZSBieSBjaGVja2luZyB0 aGUgcHJlc2VuY2Ugb2YgdGhlIHBsYXliaW4yIEdTdHJlYW1lciBlbGVtZW50LgoKLS0tCiBXZWJD b3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTQgKysr KysrKysrKysrKysKIC4uLi9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy LmNwcCAgIHwgICAxMSArKysrKysrKysrKwogLi4uL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclBy aXZhdGVHU3RyZWFtZXIuaCAgICAgfCAgICAyICstCiAzIGZpbGVzIGNoYW5nZWQsIDI2IGluc2Vy dGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cg Yi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwOTg1YTRhLi4yZDI4Y2M1IDEwMDY0NAotLS0gYS9X ZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBA CisyMDA5LTExLTI0ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR3RrXSBHU3Ry ZWFtZXItQ1JJVElDQUwncyAoYW5kIG90aGVyIHdhcm5pbmdzKSBvbiA8dmlkZW8+CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjM1NAorCisgICAgICAg IEltcGxlbWVudGVkIE1lZGlhUGxheWVyUHJpdmF0ZTo6aXNBdmFpbGFibGUgYnkgY2hlY2tpbmcg dGhlCisgICAgICAgIHByZXNlbmNlIG9mIHRoZSBwbGF5YmluMiBHU3RyZWFtZXIgZWxlbWVudC4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3Ry ZWFtZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlOjppc0F2YWls YWJsZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0 ZUdTdHJlYW1lci5oOgorCiAyMDA5LTExLTIzICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEuZ29t Ym9zQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlz dGlhbnNlbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0 ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IDRmODVmNzkuLmIzMjVkOGMg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVk aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcApAQCAtMTU4LDYgKzE1OCwxNyBAQCBzdGF0aWMg dm9pZCBkb19nc3RfaW5pdCgpCiAgICAgfQogfQogCitib29sIE1lZGlhUGxheWVyUHJpdmF0ZTo6 aXNBdmFpbGFibGUoKQoreworICAgIGRvX2dzdF9pbml0KCk7CisgICAgR3N0RWxlbWVudEZhY3Rv cnkqIGZhY3RvcnkgPSBnc3RfZWxlbWVudF9mYWN0b3J5X2ZpbmQoInBsYXliaW4yIik7CisgICAg aWYgKGZhY3RvcnkpIHsKKyAgICAgICAgZ3N0X29iamVjdF91bnJlZihHU1RfT0JKRUNUKGZhY3Rv cnkpKTsKKyAgICAgICAgcmV0dXJuIHRydWU7CisgICAgfQorICAgIHJldHVybiBmYWxzZTsKK30K KwogTWVkaWFQbGF5ZXJQcml2YXRlOjpNZWRpYVBsYXllclByaXZhdGUoTWVkaWFQbGF5ZXIqIHBs YXllcikKICAgICA6IG1fcGxheWVyKHBsYXllcikKICAgICAsIG1fcGxheUJpbigwKQpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyLmggYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZh dGVHU3RyZWFtZXIuaAppbmRleCAxZWNiYzQ2Li42YWI4ZWRiIDEwMDY0NAotLS0gYS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuaAorKysg Yi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXIuaApAQCAtMTA5LDcgKzEwOSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgICAgICAg ICAgc3RhdGljIHZvaWQgZ2V0U3VwcG9ydGVkVHlwZXMoSGFzaFNldDxTdHJpbmc+Jik7CiAgICAg ICAgICAgICBzdGF0aWMgTWVkaWFQbGF5ZXI6OlN1cHBvcnRzVHlwZSBzdXBwb3J0c1R5cGUoY29u c3QgU3RyaW5nJiB0eXBlLCBjb25zdCBTdHJpbmcmIGNvZGVjcyk7Ci0gICAgICAgICAgICBzdGF0 aWMgYm9vbCBpc0F2YWlsYWJsZSgpIHsgcmV0dXJuIHRydWU7IH0KKyAgICAgICAgICAgIHN0YXRp YyBib29sIGlzQXZhaWxhYmxlKCk7CiAKICAgICAgICAgICAgIHZvaWQgdXBkYXRlU3RhdGVzKCk7 CiAgICAgICAgICAgICB2b2lkIGNhbmNlbFNlZWsoKTsKLS0gCjEuNi4zLjM=