<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>263119</bug_id>
          
          <creation_ts>2023-10-13 05:44:28 -0700</creation_ts>
          <short_desc>[AutoInstall] prefer wheels whenever possible</short_desc>
          <delta_ts>2023-11-01 09:25:55 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=263392</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sam Sneddon [:gsnedders]">gsnedders</reporter>
          <assigned_to name="Jonathan Bedard">jbedard</assigned_to>
          <cc>bfan2</cc>
    
    <cc>jbedard</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1984859</commentid>
    <comment_count>0</comment_count>
    <who name="Sam Sneddon [:gsnedders]">gsnedders</who>
    <bug_when>2023-10-13 05:44:28 -0700</bug_when>
    <thetext>There&apos;s very little reason _not_ to prefer wheels in general; we might not always be able to use them (e.g., we may be on a platform where wheels are rarely provided, or even where packaging doesn&apos;t currently have any concept of the platform such as iOS), but we should use them when possible.

AIUI, we rely on some things (in tests?) which aren&apos;t in the Buildbot wheel (c.f. https://github.com/buildbot/buildbot/commit/2d351c2270a22302149eecd11265ea2ce3ec6617, https://github.com/buildbot/buildbot/commit/d34e1ccd3e62748b6d0c83965486774cdfb1dacc, https://github.com/buildbot/buildbot/commit/7d5c1b1ccb7ff2fc01b44b064851cea8fc7af74c), but maybe the 2021 change (shipped in 3.5.0) gives us enough of what we care about in the wheel? It sounds like prior to that they didn&apos;t really consider the testing API to be public, which meant there was little-to-no way to test Buildbot configurations.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1984860</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-10-13 05:44:37 -0700</bug_when>
    <thetext>&lt;rdar://problem/116915892&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1984861</commentid>
    <comment_count>2</comment_count>
    <who name="Sam Sneddon [:gsnedders]">gsnedders</who>
    <bug_when>2023-10-13 05:45:10 -0700</bug_when>
    <thetext>(I have a change locally for this, but need to step out for a bit; will upload PR once I&apos;m back.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1984869</commentid>
    <comment_count>3</comment_count>
    <who name="Sam Sneddon [:gsnedders]">gsnedders</who>
    <bug_when>2023-10-13 06:51:35 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/19045</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1987758</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-10-26 09:42:23 -0700</bug_when>
    <thetext>Committed 269817@main (dba0adf16439): &lt;https://commits.webkit.org/269817@main&gt;

Reviewed commits have been landed. Closing PR #19045 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1989138</commentid>
    <comment_count>5</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2023-11-01 07:59:15 -0700</bug_when>
    <thetext>Re-opening for pull request https://github.com/WebKit/WebKit/pull/19835</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1989163</commentid>
    <comment_count>6</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-11-01 09:25:50 -0700</bug_when>
    <thetext>Committed 270059@main (219eb0bb7b43): &lt;https://commits.webkit.org/270059@main&gt;

Reviewed commits have been landed. Closing PR #19835 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>