263081 2023-10-12 10:36:59 -0700 [popover] element within complex shadow DOM breaks light dismiss calculation 2023-10-20 15:16:34 -0700 1 1 1 Unclassified WebKit DOM Safari 17 Unspecified Unspecified RESOLVED FIXED https://github.com/web-platform-tests/wpt/pull/42651 https://codepen.io/Westbrook/pen/JjwVYmr BrowserCompat, InRadar P2 Normal --- 148695 250171 1 westbrook.johnson lwarlow karlcow lwarlow ntim stearns webkit-bug-importer oldest_to_newest 1984630 0 westbrook.johnson 2023-10-12 10:36:59 -0700 This issue is closely related to https://bugs.webkit.org/show_bug.cgi?id=259261 in that I would have expected the flattened tree calculation added there to have prevented this, but here again, we see the light dismiss calculation for a `[popover="auto"]` element going awry. As seen in https://codepen.io/Westbrook/pen/JjwVYmr Safari 17 and TP both overreach and close the root popover erroneously when opening the child popover. Steps: 1) Visit https://codepen.io/Westbrook/pen/JjwVYmr 2) Click the "Show" button. 3) See the "outer" [popover] element open at the center of the page. 4) Click the "Show" button within the initial [popover] element. 5) See the "outer" [popover] element closed due to the light dismiss calculation, preventing the "inner" [popover] element from becoming visible. If you run the same steps in Chrome, you'll see the "inner" [popover] open over the "outer" [popover] as expected. 1985235 1 karlcow 2023-10-15 19:12:13 -0700 Firefox Nightly Not working (after setting dom.element.popover.enabled to true in about:config) In Safari the second nested showPopover() fails silently. In chrome we can see it. 1985301 2 westbrook.johnson 2023-10-16 05:26:09 -0700 It seems that the DSD flag was maybe removed from Firefox nightly, but that feature was only leveraged for simplicity, it wasn't part of the larger issue. This demo exemplifies the issue with imperative Shadow DOM: https://codepen.io/Westbrook/pen/jOXooPB?editors=1010 1986177 3 webkit-bug-importer 2023-10-19 10:37:19 -0700 <rdar://problem/117214343> 1986248 4 ntim 2023-10-19 13:42:56 -0700 Here's another place that needs to use the flat tree: https://searchfox.org/wubkat/rev/c64f97a4afc2aa3f73f74f59630410234ca8a659/Source/WebCore/html/HTMLElement.cpp#1286 1986306 5 lwarlow 2023-10-19 15:28:57 -0700 I'm happy to take a look at this. I've got a WPT that covers it so shouldn't take long. 1986308 6 lwarlow 2023-10-19 15:41:39 -0700 Pull request: https://github.com/WebKit/WebKit/pull/19314 1986563 7 ews-feeder 2023-10-20 15:11:52 -0700 Committed 269596@main (4ab4d8351529): <https://commits.webkit.org/269596@main> Reviewed commits have been landed. Closing PR #19314 and removing active labels.