263051 2023-10-11 17:39:13 -0700 return a createCommaSeparated() in CSSPropertyBackgroundBlendMode 2023-10-13 15:47:53 -0700 1 1 1 Unclassified WebKit CSS Safari 17 Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=261552 https://bugs.webkit.org/show_bug.cgi?id=263115 InRadar P2 Normal --- 263104 1 karlcow karlcow ahmad.saleem792 webkit-bug-importer oldest_to_newest 1984481 0 468182 karlcow 2023-10-11 17:39:13 -0700 Created attachment 468182 testcase Currently the CSSPropertyBackgroundBlendMode, returns a space separated list instead of comma separated list - return CSSValueList::createSpaceSeparated(WTFMove(list)); + return CSSValueList::createCommaSeparated(WTFMove(list)); Uploaded Simple Test by Simon Fraser. It should return: "normal, luminosity" and not "normal luminosity" 1984482 1 webkit-bug-importer 2023-10-11 17:39:50 -0700 <rdar://problem/116838342> 1984484 2 karlcow 2023-10-11 17:51:20 -0700 Pull request: https://github.com/WebKit/WebKit/pull/18971 1984485 3 ahmad.saleem792 2023-10-11 17:56:19 -0700 @Karl - will it progress following three failing tests: https://wpt.fyi/results/css/compositing/parsing/background-blend-mode-computed.html?label=master&label=experimental&aligned=&q=safari%3Afail 1984488 4 karlcow 2023-10-11 18:01:13 -0700 See Bug 261552 (and my new coming comment there) ;) 1984490 5 ahmad.saleem792 2023-10-11 18:02:32 -0700 (In reply to Karl Dubost from comment #4) > See Bug 261552 (and my new coming comment there) ;) Sweet!! :-) 1984508 6 karlcow 2023-10-11 19:42:30 -0700 Note tests will be fixed/extended in https://github.com/web-platform-tests/wpt/issues/42496 1985012 7 ews-feeder 2023-10-13 15:47:51 -0700 Committed 269325@main (c7bdf3966172): <https://commits.webkit.org/269325@main> Reviewed commits have been landed. Closing PR #18971 and removing active labels. 468182 2023-10-11 17:39:13 -0700 2023-10-11 17:39:13 -0700 testcase computed-background-blend-mode.html text/html 850 karlcow PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KICAgIDxtZXRhIG5hbWU9InZpZXdwb3J0IiBj b250ZW50PSJ3aWR0aD1kZXZpY2Utd2lkdGgsIGluaXRpYWwtc2NhbGU9MSwgc2hyaW5rLXRvLWZp dD1ubyI+CiAgICA8dGl0bGU+PC90aXRsZT4KICAgIDxzdHlsZT4KICAgICAgICAuYm94IHsKICAg ICAgICAgICAgd2lkdGg6IDEwMHB4OwogICAgICAgICAgICBoZWlnaHQ6IDEwMHB4OwogICAgICAg ICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBibHVlOwogICAgICAgICAgICAvKiBiYWNrZ3JvdW5kLWlt YWdlOiB1cmwoZm9vLnBpbmcpOyAqLwogICAgICAgICAgIGJhY2tncm91bmQtaW1hZ2U6IHVybChm b28ucGluZyksIHVybChiYXIucG5nKTsKICAgICAgICAgICAgYmFja2dyb3VuZC1ibGVuZC1tb2Rl OiBub3JtYWwsIGx1bWlub3NpdHk7CiAgICAgICAgfQogICAgICAgIAogICAgPC9zdHlsZT4KICAg IDxzY3JpcHQ+CiAgICAgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCAoKSA9PiB7 CiAgICAgICAgICAgIGxldCBib3ggPSBkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCcuYm94Jyk7CiAg ICAgICAgICAgIGxldCBjb21wdXRlZFN0eWxlID0gd2luZG93LmdldENvbXB1dGVkU3R5bGUoYm94 KS5iYWNrZ3JvdW5kQmxlbmRNb2RlOwogICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgncmVzdWx0JykudGV4dENvbnRlbnQgPSBjb21wdXRlZFN0eWxlOwogICAgICAgIH0sIGZhbHNl KTsKICAgIDwvc2NyaXB0Pgo8L2hlYWQ+Cjxib2R5PgogICAgPGRpdiBjbGFzcz0iYm94Ij4KICAg IDwvZGl2PgogICAgPGRpdiBpZD0icmVzdWx0Ij48L2Rpdj4KPC9ib2R5Pgo8L2h0bWw+Cg==