<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>26289</bug_id>
          
          <creation_ts>2009-06-10 03:52:53 -0700</creation_ts>
          <short_desc>Current svn (rev 44556) fails to compile with --qt</short_desc>
          <delta_ts>2009-06-13 15:59:59 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Bernhard Rosenkraenzer">bero</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>125119</commentid>
    <comment_count>0</comment_count>
    <who name="Bernhard Rosenkraenzer">bero</who>
    <bug_when>2009-06-10 03:52:53 -0700</bug_when>
    <thetext>g++ -c -pipe -Wreturn-type -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-stack-protector -m32 -O2 -march=i586 -mtune=i686 -fomit-frame-pointer -fweb -frename-registers -Wl,-O2,-z,combreloc,-z,relro,--enable-new-dtags,--hash-style=gnu,--sort-common -fvisibility=hidden -fvisibility-inlines-hidden -D_REENTRANT -fPIC -DBUILDING_QT__=1 -DUSE_SYSTEM_MALLOC -DNDEBUG -DQT_MAKEDLL -DHAVE_STDINT_H -DBUILD_WEBKIT -DENABLE_JAVASCRIPT_DEBUGGER=1 -DENABLE_DATABASE=1 -DENABLE_OFFLINE_WEB_APPLICATIONS=1 -DENABLE_DOM_STORAGE=1 -DENABLE_ICONDATABASE=1 -DENABLE_SQLITE=1 -DENABLE_DASHBOARD_SUPPORT=0 -DENABLE_FILTERS=0 -DENABLE_XPATH=1 -DENABLE_XSLT=0 -DENABLE_WML=0 -DENABLE_WORKERS=1 -DENABLE_XHTMLMP=0 -DENABLE_SVG=1 -DENABLE_SVG_FONTS=1 -DENABLE_SVG_FOREIGN_OBJECT=1 -DENABLE_SVG_ANIMATION=1 -DENABLE_SVG_AS_IMAGE=1 -DENABLE_SVG_USE=1 -DENABLE_VIDEO=1 -DENABLE_NETSCAPE_PLUGIN_API=1 -DWTF_USE_JAVASCRIPTCORE_BINDINGS=1 -DWTF_CHANGES=1 -DBUILDING_QT__ -DBUILDING_JavaScriptCore -DBUILDING_WTF -DENABLE_JIT=1 -DENABLE_YARR=1 -DENABLE_YARR_JIT=1 -DENABLE_JIT_OPTIMIZE_CALL=1 -DENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS=1 -DENABLE_JIT_OPTIMIZE_ARITHMETIC=1 -DWTF_USE_JIT_STUB_ARGUMENT_VA_LIST=1 -DENABLE_PLUGIN_PACKAGE_SIMPLE_HASH=1 -DXP_UNIX -DQT_NO_DEBUG -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/lib/qt4/mkspecs/linux-g++ -I../../../WebCore -I/usr/lib/qt4/include/QtCore -I/usr/lib/qt4/include/QtNetwork -I/usr/lib/qt4/include/QtGui -I/usr/lib/qt4/include -I../../../WebCore/storage -I../../../WebCore -I../../../WebKit/qt/Api -Igenerated/release -I../../../JavaScriptCore -I../../../JavaScriptCore/parser -I../../../JavaScriptCore/bytecompiler -I../../../JavaScriptCore/debugger -I../../../JavaScriptCore/runtime -I../../../JavaScriptCore/wtf -I../../../JavaScriptCore/wtf/unicode -I../../../JavaScriptCore/interpreter -I../../../JavaScriptCore/jit -I../../../JavaScriptCore/profiler -I../../../JavaScriptCore/wrec -I../../../JavaScriptCore/yarr -I../../../JavaScriptCore/API -I../../../../WebKit -I../../../JavaScriptCore/ForwardingHeaders -I../../../JavaScriptCore/bytecode -I../../../JavaScriptCore/assembler -I../../../JavaScriptCore/pcre -I/mnt/space/src/ark/BUILD/WebKit/WebKitBuild/Release/JavaScriptCore/tmp -I../../../WebCore/platform/qt -I../../../WebCore/platform/network/qt -I../../../WebCore/platform/graphics/filters -I../../../WebCore/platform/graphics/transforms -I../../../WebCore/platform/graphics/qt -I../../../WebCore/page/qt -I../../../WebKit/qt/WebCoreSupport -I../../../WebCore/accessibility -I../../../WebCore/ForwardingHeaders -I../../../WebCore/platform -I../../../WebCore/platform/animation -I../../../WebCore/platform/network -I../../../WebCore/platform/graphics -I../../../WebCore/svg/animation -I../../../WebCore/svg/graphics -I../../../WebCore/svg/graphics/filters -I../../../WebCore/platform/sql -I../../../WebCore/platform/text -I../../../WebCore/loader -I../../../WebCore/loader/appcache -I../../../WebCore/loader/archive -I../../../WebCore/loader/icon -I../../../WebCore/css -I../../../WebCore/dom -I../../../WebCore/page -I../../../WebCore/page/animation -I../../../WebCore/editing -I../../../WebCore/rendering -I../../../WebCore/rendering/style -I../../../WebCore/history -I../../../WebCore/inspector -I../../../WebCore/xml -I../../../WebCore/html -I../../../WebCore/wml -I../../../WebCore/workers -I../../../WebCore/bindings/js -I../../../WebCore/svg -I../../../WebCore/platform/image-decoders -I../../../WebCore/plugins -I../../../WebCore/bridge -I../../../WebCore/bridge/c -I../../../WebCore/bridge/qt -I/usr/lib/qt4/src/3rdparty/sqlite/ -I/usr/lib/qt4/include/phonon -I/usr/X11R6/include -I. -I../../../WebCore -I. -o obj/release/ImageDecoderQt.o ../../../WebCore/platform/graphics/qt/ImageDecoderQt.cpp
../../../WebCore/platform/image-decoders/ImageDecoder.h: In member function &apos;void WebCore::ImageDecoderQt::reset()&apos;:
../../../WebCore/platform/image-decoders/ImageDecoder.h:237: error: &apos;bool WebCore::ImageDecoder::m_sizeAvailable&apos; is private
../../../WebCore/platform/graphics/qt/ImageDecoderQt.cpp:220: error: within this context
../../../WebCore/platform/image-decoders/ImageDecoder.h:236: error: &apos;WebCore::IntSize WebCore::ImageDecoder::m_size&apos; is private
../../../WebCore/platform/graphics/qt/ImageDecoderQt.cpp:222: error: within this context
../../../WebCore/platform/image-decoders/ImageDecoder.h: In member function &apos;virtual void WebCore::ImageDecoderQt::setData(const WTF::Vector&lt;char, 0u&gt;&amp;, bool)&apos;:
../../../WebCore/platform/image-decoders/ImageDecoder.h:237: error: &apos;bool WebCore::ImageDecoder::m_sizeAvailable&apos; is private
../../../WebCore/platform/graphics/qt/ImageDecoderQt.cpp:250: error: within this context
../../../WebCore/platform/image-decoders/ImageDecoder.h:236: error: &apos;WebCore::IntSize WebCore::ImageDecoder::m_size&apos; is private
../../../WebCore/platform/graphics/qt/ImageDecoderQt.cpp:251: error: within this context
../../../WebCore/platform/image-decoders/ImageDecoder.h: In member function &apos;virtual bool WebCore::ImageDecoderQt::isSizeAvailable() const&apos;:
../../../WebCore/platform/image-decoders/ImageDecoder.h:237: error: &apos;bool WebCore::ImageDecoder::m_sizeAvailable&apos; is private
../../../WebCore/platform/graphics/qt/ImageDecoderQt.cpp:268: error: within this context
../../../WebCore/platform/image-decoders/ImageDecoder.h:237: error: &apos;bool WebCore::ImageDecoder::m_sizeAvailable&apos; is private
../../../WebCore/platform/graphics/qt/ImageDecoderQt.cpp:269: error: within this context
make[1]: *** [obj/release/ImageDecoderQt.o] Error 1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>125121</commentid>
    <comment_count>1</comment_count>
      <attachid>31128</attachid>
    <who name="Bernhard Rosenkraenzer">bero</who>
    <bug_when>2009-06-10 04:22:54 -0700</bug_when>
    <thetext>Created attachment 31128
Fix

IMO this is the only way to fix it -- the Qt ImageDecoder actually writes to m_size and m_sizeAvailable</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>125686</commentid>
    <comment_count>2</comment_count>
    <who name="Peter Kasting">pkasting</who>
    <bug_when>2009-06-13 15:59:59 -0700</bug_when>
    <thetext>This was fixed already.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>31128</attachid>
            <date>2009-06-10 04:22:54 -0700</date>
            <delta_ts>2009-06-10 04:22:54 -0700</delta_ts>
            <desc>Fix</desc>
            <filename>WebKit-compilefix.patch</filename>
            <type>text/plain</type>
            <size>375</size>
            <attacher name="Bernhard Rosenkraenzer">bero</attacher>
            
              <data encoding="base64">LS0tIFdlYktpdC9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL0ltYWdlRGVjb2Rlci5o
LmFyawkyMDA5LTA2LTEwIDEyOjU4OjUxLjE3NTI5MTkwOCArMDIwMAorKysgV2ViS2l0L1dlYkNv
cmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvSW1hZ2VEZWNvZGVyLmgJMjAwOS0wNi0xMCAxMzow
Mjo0OC4xMzcyOTE4MDUgKzAyMDAKQEAgLTIzMyw2ICsyMzMsNyBAQCBuYW1lc3BhY2UgV2ViQ29y
ZSB7CiAgICAgICAgICAgICByZXR1cm4gdG90YWxfc2l6ZSA+ICgoMSA8PCAyOSkgLSAxKTsKICAg
ICAgICAgfQogCisgICAgcHJvdGVjdGVkOgogICAgICAgICBJbnRTaXplIG1fc2l6ZTsKICAgICAg
ICAgYm9vbCBtX3NpemVBdmFpbGFibGU7CiAgICAgfTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>