262887 2023-10-09 07:22:42 -0700 check-for-duplicated-platform-test-results can remove files that aren't expectations 2023-10-09 15:04:07 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 gsnedders gsnedders webkit-bug-importer oldest_to_newest 1983669 0 gsnedders 2023-10-09 07:22:42 -0700 Ignoring the fact that this shows we expect the tree to be clean before running check-for-duplicated-platform-test-results, this shows we're deleting a file that isn't a "test result" as the script is named. gsnedders@gsnedders-marsha WebKit % cp LayoutTests/media/video-test.js LayoutTests/platform/mac/media/video-test.js gsnedders@gsnedders-marsha WebKit % ./Tools/Scripts/check-for-duplicated-platform-test-results Checking search paths [platform/mac-ventura-wk1, platform/mac-ventura, platform/mac-wk1, platform/mac] Traceback (most recent call last): File "/Volumes/gsnedders/projects/Safari/WebKit/./Tools/Scripts/check-for-duplicated-platform-test-results", line 203, in <module> sys.exit(main()) File "/Volumes/gsnedders/projects/Safari/WebKit/./Tools/Scripts/check-for-duplicated-platform-test-results", line 188, in main total += check_platform(options, baseline_search_paths_checked) File "/Volumes/gsnedders/projects/Safari/WebKit/./Tools/Scripts/check-for-duplicated-platform-test-results", line 160, in check_platform host.scm().delete_list(duplicates) File "/Volumes/gsnedders/projects/Safari/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py", line 187, in delete_list return self._run_git(["rm", "-f"] + paths) File "/Volumes/gsnedders/projects/Safari/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py", line 111, in _run_git return self.run(full_command_args, **full_kwargs) File "/Volumes/gsnedders/projects/Safari/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py", line 73, in run return self._executive.run_command(args, File "/Volumes/gsnedders/projects/Safari/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 445, in run_command (error_handler or self.default_error_handler)(script_error) File "/Volumes/gsnedders/projects/Safari/WebKit/Tools/Scripts/webkitpy/common/system/abstractexecutive.py", line 98, in default_error_handler raise error webkitpy.common.system.executive.ScriptError: Failed to run "['git', 'rm', '-f', '/Volumes/gsnedders/projects/Safari/WebKit/LayoutTests/platform/mac/media/video-test.js']" exit_code: 128 cwd: /Volumes/gsnedders/projects/Safari/WebKit 1983670 1 webkit-bug-importer 2023-10-09 07:22:51 -0700 <rdar://problem/116676951> 1983672 2 gsnedders 2023-10-09 07:31:16 -0700 Pull request: https://github.com/WebKit/WebKit/pull/18837 1983836 3 ews-feeder 2023-10-09 15:04:04 -0700 Committed 269113@main (fc7d2c4aac46): <https://commits.webkit.org/269113@main> Reviewed commits have been landed. Closing PR #18837 and removing active labels.