<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>262866</bug_id>
          
          <creation_ts>2023-10-08 10:35:41 -0700</creation_ts>
          <short_desc>text-decoration-thickness should support percentages</short_desc>
          <delta_ts>2023-10-28 04:16:18 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>GoodFirstBug, InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tim Nguyen (:ntim)">ntim</reporter>
          <assigned_to name="ChangSeok Oh">changseok</assigned_to>
          <cc>changseok</cc>
    
    <cc>fantasai.bugs</cc>
    
    <cc>vitor.roriz</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1983581</commentid>
    <comment_count>0</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2023-10-08 10:35:41 -0700</bug_when>
    <thetext>This should be pretty simple to support given we already support ems.

Here are places that need changing:

https://searchfox.org/wubkat/rev/9709f5c78a15a0ae1e723096557a6a060822d868/Source/WebCore/css/CSSProperties.json#8301-8305

https://searchfox.org/wubkat/rev/9709f5c78a15a0ae1e723096557a6a060822d868/Source/WebCore/style/StyleBuilderConverter.h#881

https://searchfox.org/wubkat/rev/9709f5c78a15a0ae1e723096557a6a060822d868/Source/WebCore/rendering/style/TextDecorationThickness.h</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1983582</commentid>
    <comment_count>1</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2023-10-08 10:36:26 -0700</bug_when>
    <thetext>This should fix this WPT: 

imported/w3c/web-platform-tests/css/css-fonts/size-adjust-text-decoration.tentative.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1984635</commentid>
    <comment_count>2</comment_count>
    <who name="ChangSeok Oh">changseok</who>
    <bug_when>2023-10-12 10:49:41 -0700</bug_when>
    <thetext>I will take a look.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1984636</commentid>
    <comment_count>3</comment_count>
    <who name="ChangSeok Oh">changseok</who>
    <bug_when>2023-10-12 10:53:06 -0700</bug_when>
    <thetext>By the way, is the name of size-adjust-text-decoration.tentative.html a mistake? Its reference file name is size-adjust-text-decoration-tentative-ref.html. Yeah, I am talking about the dot just before &quot;tentative&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1985123</commentid>
    <comment_count>4</comment_count>
    <who name="ChangSeok Oh">changseok</who>
    <bug_when>2023-10-14 09:36:19 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/19085</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1985198</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-10-15 10:36:13 -0700</bug_when>
    <thetext>&lt;rdar://problem/116985587&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1985228</commentid>
    <comment_count>6</comment_count>
    <who name="ChangSeok Oh">changseok</who>
    <bug_when>2023-10-15 17:47:15 -0700</bug_when>
    <thetext>*** Bug 255868 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1988200</commentid>
    <comment_count>7</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-10-28 04:16:17 -0700</bug_when>
    <thetext>Committed 269886@main (4172b60326a8): &lt;https://commits.webkit.org/269886@main&gt;

Reviewed commits have been landed. Closing PR #19085 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>