<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>262837</bug_id>
          
          <creation_ts>2023-10-07 02:24:00 -0700</creation_ts>
          <short_desc>[GTK][WPE] Enable libbacktrace support</short_desc>
          <delta_ts>2023-10-08 08:24:43 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Philippe Normand">philn</reporter>
          <assigned_to name="Philippe Normand">philn</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>dpino</cc>
    
    <cc>emilio</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>vitaly</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1983436</commentid>
    <comment_count>0</comment_count>
    <who name="Philippe Normand">philn</who>
    <bug_when>2023-10-07 02:24:00 -0700</bug_when>
    <thetext>The BuildStream SDK now ships libbacktrace so the support can be enabled in CMake.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1983437</commentid>
    <comment_count>1</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2023-10-07 02:26:26 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/18807</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1983442</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-10-07 05:42:04 -0700</bug_when>
    <thetext>Committed 269037@main (343ea784deb2): &lt;https://commits.webkit.org/269037@main&gt;

Reviewed commits have been landed. Closing PR #18807 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1983447</commentid>
    <comment_count>3</comment_count>
    <who name="Philippe Normand">philn</who>
    <bug_when>2023-10-07 07:09:42 -0700</bug_when>
    <thetext>This broke https://build.webkit.org/#/builders/46

-- Could NOT find LibBacktrace (missing: LIBBACKTRACE_INCLUDE_DIR LIBBACKTRACE_LIBRARY) 
CMake Error at Source/cmake/OptionsGTK.cmake:478 (message):
  libbacktrace is required for USE_LIBBACKTRACE
Call Stack (most recent call first):
  Source/cmake/WebKitCommon.cmake:232 (include)
  CMakeLists.txt:21 (include)

Not sure what to do?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1983448</commentid>
    <comment_count>4</comment_count>
    <who name="Philippe Normand">philn</who>
    <bug_when>2023-10-07 07:11:13 -0700</bug_when>
    <thetext>https://build.webkit.org/#/builders/595 and https://build.webkit.org/#/builders/68 also red</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1983457</commentid>
    <comment_count>5</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2023-10-07 08:02:03 -0700</bug_when>
    <thetext>Well we either change the LTS bots&apos; configuration to build without libbacktrace, or install libbacktrace on the bots. I don&apos;t think this is urgent; they&apos;re not test bots, so it&apos;s not like we&apos;re losing test results every hour they are turned off. Can deal with it next week IMO.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1983568</commentid>
    <comment_count>6</comment_count>
    <who name="Diego Pino">dpino</who>
    <bug_when>2023-10-08 08:24:13 -0700</bug_when>
    <thetext>FYI, an interruption of the WebKitGTK Ubuntu LTS build bot will likely cause an interruption of WebKit Search (https://searchfox.org/wubkat/source/) as well, because both bots build WebKitGTK with a similar configuration (--no-experimental-features plus a few features disabled). While the other bots are not critical, I  think an interruption of WebKit Search is more important since many people use it daily.

I searched for a libbacktrace package in Ubuntu and it doesn&apos;t seem to exist (neither 20.04 or 22.04). Libbakctrace is installed directly from a git repository (https://github.com/WebKit/WebKit/blob/main/Tools/buildstream/elements/sdk/libbacktrace.bst). A potential fix could be to install this package as a JHBuild dependency, but that wouldn&apos;t be enough for bots that do not use JHBuild and build only using system libraries (--no-experimental-features). In this case, those bots have to build with --USE_LIBBACKTRACE=OFF. I can change the bots settings to build with this flag disabled.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>