26281 2009-06-09 14:38:42 -0700 REGRESSION: Copying from TextEdit/OmniGraffle and pasting into editable region loses images 2009-06-13 22:07:17 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 justin.garcia abarth abarth dwood mitz oldest_to_newest 125011 0 justin.garcia 2009-06-09 14:38:42 -0700 Create a new TextEdit document Add some text and images Copy everything Paste into a content editable region (Blot should be OK) Images are missing. This is because I'll 125014 1 justin.garcia 2009-06-09 14:42:34 -0700 This is because WebKit's _documentFragmentFromPasteboard prefers RTF over RTFD. 125091 2 31124 justin.garcia 2009-06-09 21:51:37 -0700 Created attachment 31124 patch 125095 3 mitz 2009-06-09 22:48:19 -0700 Is it possible to make an automated test for this bug? 125104 4 31124 eric 2009-06-10 00:41:29 -0700 Comment on attachment 31124 patch r=me. Can we please please fix all that copy/paste code in that function in a follow-up patch? It's so disgusting! A single static function which took a PboardType and returned a fragment would get rid of *all* those stupid lines! Heck, we could even make it just an Array of Pboard types so that the preferred order was much easier to read and this kind of bug wouldn't happen again. ;) Oh, and it should be possible to make a test for this... Admittedly, kinda hard, but I would expect event.dataTransfer.setData() to be able to test this. 125720 5 abarth 2009-06-13 20:38:19 -0700 Will land. 125734 6 abarth 2009-06-13 22:07:17 -0700 Sending WebKit/mac/ChangeLog Sending WebKit/mac/WebView/WebHTMLView.mm Transmitting file data .. Committed revision 44668. Next time, please base your patches in the root directory so we can use the awesome-sauce WebKitTools. 31124 2009-06-09 21:51:37 -0700 2009-06-10 00:41:29 -0700 patch 26281.txt text/plain 2083 justin.garcia SW5kZXg6IG1hYy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gbWFjL0NoYW5nZUxvZwkocmV2aXNp b24gNDQ1NTMpCisrKyBtYWMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYg QEAKKzIwMDktMDYtMDkgIEp1c3RpbiBHYXJjaWEgIDxqdXN0aW4uZ2FyY2lhQGFwcGxlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjI4MQorICAgICAgICBS RUdSRVNTSU9OOiBDb3B5aW5nIGZyb20gVGV4dEVkaXQvT21uaUdyYWZmbGUgYW5kIHBhc3Rpbmcg aW50byBlZGl0YWJsZSByZWdpb24gbG9zZXMgaW1hZ2VzCisgICAgICAgIAorICAgICAgICBQcmVm ZXIgUlRGRCAoUlRGIHdpdGggaW5saW5lIGltYWdlcykgb3ZlciBSVEYuICBJbiBodHRwOi8vdHJh Yy53ZWJraXQub3JnL2NoYW5nZXNldC8xOTc0NSBJIAorICAgICAgICBhY2NpZGVudGx5IHJldmVy c2VkIHRoZWlyIG9yZGVyLgorCisgICAgICAgICogV2ViVmlldy9XZWJIVE1MVmlldy5tbToKKyAg ICAgICAgKC1bV2ViSFRNTFZpZXcgX2RvY3VtZW50RnJhZ21lbnRGcm9tUGFzdGVib2FyZDppbkNv bnRleHQ6YWxsb3dQbGFpblRleHQ6XSk6IAorCiAyMDA5LTA2LTA4ICBEYW4gQmVybnN0ZWluICA8 bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgTWFyayBSb3dlLgpJ bmRleDogbWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gbWFjL1dlYlZp ZXcvV2ViSFRNTFZpZXcubW0JKHJldmlzaW9uIDQzNzQyKQorKysgbWFjL1dlYlZpZXcvV2ViSFRN TFZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTcyMCwxNiArNzIwLDE2IEBACiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdWJyZXNvdXJjZXM6MF0pKQogICAg ICAgICByZXR1cm4gZnJhZ21lbnQ7CiAgICAgCi0gICAgaWYgKFt0eXBlcyBjb250YWluc09iamVj dDpOU1JURlBib2FyZFR5cGVdICYmCisgICAgaWYgKFt0eXBlcyBjb250YWluc09iamVjdDpOU1JU RkRQYm9hcmRUeXBlXSAmJgogICAgICAgICAoZnJhZ21lbnQgPSBbc2VsZiBfZG9jdW1lbnRGcmFn bWVudEZyb21QYXN0ZWJvYXJkOnBhc3RlYm9hcmQgCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGZvclR5cGU6TlNSVEZQYm9hcmRUeXBlCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZvclR5cGU6TlNSVEZE UGJvYXJkVHlwZQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgaW5Db250ZXh0OmNvbnRleHQKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHN1YnJlc291cmNlczowXSkpCiAgICAgICAgIHJldHVybiBmcmFnbWVudDsKLQot ICAgIGlmIChbdHlwZXMgY29udGFpbnNPYmplY3Q6TlNSVEZEUGJvYXJkVHlwZV0gJiYKKyAgICAK KyAgICBpZiAoW3R5cGVzIGNvbnRhaW5zT2JqZWN0Ok5TUlRGUGJvYXJkVHlwZV0gJiYKICAgICAg ICAgKGZyYWdtZW50ID0gW3NlbGYgX2RvY3VtZW50RnJhZ21lbnRGcm9tUGFzdGVib2FyZDpwYXN0 ZWJvYXJkIAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBmb3JUeXBlOk5TUlRGRFBib2FyZFR5cGUKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgZm9yVHlwZTpOU1JURlBib2FyZFR5cGUKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluQ29udGV4dDpjb250ZXh0CiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdWJyZXNvdXJjZXM6 MF0pKQogICAgICAgICByZXR1cm4gZnJhZ21lbnQ7Cg==