262721 2023-10-05 12:57:29 -0700 Use a HashSet<CheckedRef<LocalFrame>> for Page::m_rootFrames 2023-10-06 14:32:56 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 262778 1 cdumez cdumez bfulgham commit-queue fujii jameshoward simon.fraser webkit-bug-importer zalan oldest_to_newest 1982933 0 cdumez 2023-10-05 12:57:29 -0700 Use a HashSet<WeakRef<LocalFrame>> for Page::m_rootFrames instead of a WeakHashSet<LocalFrame>. This map is used in a hot code path and using a WeakHashSet is unnecessarily inefficient. 1982934 1 cdumez 2023-10-05 12:59:18 -0700 Pull request: https://github.com/WebKit/WebKit/pull/18713 1983127 2 ews-feeder 2023-10-05 23:52:36 -0700 Committed 268974@main (86924d729527): <https://commits.webkit.org/268974@main> Reviewed commits have been landed. Closing PR #18713 and removing active labels. 1983128 3 webkit-bug-importer 2023-10-05 23:53:18 -0700 <rdar://problem/116565539> 1983151 4 jameshoward 2023-10-06 01:57:20 -0700 I think this change broke Debug builds, at least on my system (arm64, macOS 13.5.1, Xcode 14.3). All tests crash here: Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 JavaScriptCore 0x13730c204 WTFCrash + 20 (Assertions.cpp:333) 1 WebCore 0x282ac42b0 WTFCrashWithInfo(int, char const*, char const*, int) + 32 (Assertions.h:778) 2 WebCore 0x28480a570 WebCore::Page::removeRootFrame(WebCore::LocalFrame&) + 268 (Page.cpp:4510) 3 WebCore 0x2847747cc WebCore::LocalFrame::LocalFrame(WebCore::Page&, WTF::UniqueRef<WebCore::LocalFrameLoaderClient>&&, WebCore::ProcessQualified<WTF::ObjectIdentifierGeneric<WebCore::FrameIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits>>, WebCore::HTMLFrameOwnerElement*, WebCore::Frame*) + 504 (LocalFrame.cpp:174) ... If I revert the change locally, no more crash. 1983173 5 commit-queue 2023-10-06 04:55:34 -0700 Re-opened since this is blocked by bug 262778 1983198 6 cdumez 2023-10-06 07:22:05 -0700 Pull request: https://github.com/WebKit/WebKit/pull/18762 1983302 7 ews-feeder 2023-10-06 12:45:44 -0700 Committed 269009@main (75d236ee7095): <https://commits.webkit.org/269009@main> Reviewed commits have been landed. Closing PR #18762 and removing active labels.