262515 2023-10-02 16:56:41 -0700 Fix build break for ENABLE(MEDIA_SOURCE) && !ENABLE(MANAGED_MEDIA_SOURCE) after https://commits.webkit.org/268711@main 2023-10-09 16:57:19 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=262438 InRadar P2 Normal --- 1 jigen.zhou webkit-unassigned eric.carlson jean-yves.avenard tomoki.imai webkit-bug-importer Yousuke.Kimoto oldest_to_newest 1981917 0 jigen.zhou 2023-10-02 16:56:41 -0700 The code change in https://commits.webkit.org/268711@main works if both ENABLE(MEDIA_SOURCE) && ENABLE(MANAGED_MEDIA_SOURCE), but a compiling error can be caused by the generated code. 1982788 1 tomoki.imai 2023-10-05 01:25:10 -0700 The following code is a part of WebCore/DerivedSources/JSVideoTrack.cpp. It accesses "managedMediaSourceEnabled" without "#if ENABLE(ManagedMediaSourceEnabled)" block and causes a build failure if ENABLE(MEDIA_SOURCE) && !ENABLE(ManagedMediaSourceEnabled). #if ENABLE(MEDIA_SOURCE) if (!(downcast<Document>(jsCast<JSDOMGlobalObject*>(globalObject())->scriptExecutionContext())->settingsValues().mediaSourceEnabled || downcast<Document>(jsCast<JSDOMGlobalObject*>(globalObject())->scriptExecutionContext())->settingsValues().managedMediaSourceEnabled)) { hasDisabledRuntimeProperties = true; auto propertyName = Identifier::fromString(vm, "sourceBuffer"_s); VM::DeletePropertyModeScope scope(vm, VM::DeletePropertyMode::IgnoreConfigurable); DeletePropertySlot slot; JSObject::deleteProperty(this, globalObject(), propertyName, slot); } #endif 1982789 2 tomoki.imai 2023-10-05 01:35:45 -0700 In WebCore/DerivedSources/Settings.h, "managedMediaSourceEnabled" is blocked by " ENABLE(MANAGED_MEDIA_SOURCE)". class Settings : public SettingsBase, public RefCounted<Settings> { struct Values { ... #if ENABLE(MANAGED_MEDIA_SOURCE) bool managedMediaSourceEnabled : 1; #endif 1983864 3 webkit-bug-importer 2023-10-09 16:57:19 -0700 <rdar://problem/116707041>