262488 2023-10-02 09:37:28 -0700 Simplify range mapping computation in SVGTextQuery/SVGInlineTextBox 2023-10-17 14:00:06 -0700 1 1 1 Unclassified WebKit SVG Safari Technology Preview Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=261651 BrowserCompat, InRadar P2 Normal --- 1 ahmad.saleem792 webkit-unassigned karlcow sabouhallawa webkit-bug-importer zimmermann oldest_to_newest 1981775 0 ahmad.saleem792 2023-10-02 09:37:28 -0700 Simplify range mapping computation in SVGTextQuery/SVGInlineTextBox Blink Merge: https://src.chromium.org/viewvc/blink?view=revision&revision=193017 _________ bool SVGInlineTextBox::mapStartEndPositionsIntoFragmentCoordinates(const SVGTextFragment& fragment, unsigned& startPosition, unsigned& endPosition) const { unsigned fragmentOffsetInBox = fragment.characterOffset - start(); // Compute positions relative to the fragment. startPosition -= fragmentOffsetInBox; endPosition -= fragmentOffsetInBox; // Intersect with the fragment range. startPosition = std::max<unsigned>(startPosition, 0); endPosition = std::min<unsigned>(endPosition, fragment.length); return startPosition < endPosition; } ________ Just wanted to raise. 1981923 1 ahmad.saleem792 2023-10-02 17:55:18 -0700 This simplification require pre-requisite to make SVG Text code to respect RTL etc. By doing 1-1 merge as below PR, it will leads to two failures: https://github.com/WebKit/WebKit/pull/18514 Failing tests: imported/mozilla/svg/text/textpath-selection.svg imported/w3c/web-platform-tests/css/css-pseudo/textpath-selection-011.html ^ Both are genuine failures. I am letting my PR run through EWS fully to document failures (if any else) but I will look into further future merges and see what else I can do. 1983707 2 webkit-bug-importer 2023-10-09 09:38:17 -0700 <rdar://problem/116683897> 1985677 3 ews-feeder 2023-10-17 14:00:04 -0700 Committed 269425@main (8e69bb72e0ee): <https://commits.webkit.org/269425@main> Reviewed commits have been landed. Closing PR #18514 and removing active labels.