26241 2009-06-07 08:36:50 -0700 Form control state shouldn't be restored for hidden inputs. 2010-06-19 21:30:10 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 23346 40656 1 kato.kazuyoshi webkit-unassigned abfmwei ap commit-queue darin david-webkit dglazkov tkent oldest_to_newest 124689 0 kato.kazuyoshi 2009-06-07 08:36:50 -0700 Overview Description: WebKit save/restore value of a input element from WebCore::HistoryItem. But this behavior seems strange at non-bfcached page. Steps to Reproduce: 1) Create a simple "counter" app. that returns the following HTML. And #{count} is incremented by each access. <form method="get" action="/foo"> #{count} <input type="hidden" name="count" value="#{count}"/> <input type="submit" /> </form> <iframe src="http://webkit.org/"></iframe> 2) Access the page and press "Submit" button. New page is "/foo?count=1". 3) Press browser's "Back" button. WebKit requests the page agin because bfcache is disabled by the iframe. 4) The application *increments counter* and returns HTML again. 5) Press "Submit" again. Expected Results: New page is should be "/foo?count=2" because WebKit requests the page and the server returns new HTML. Actual Results: New page is "/foo?count=1". Because WebCore::FrameLoader::restoreDocumentState and WebCore::HTMLInputElement::restoreState replaced value of input elements by the old (saved) values. This behavior sometimes useful. When user input long (or complex) value, WebKit should save the value and user can notice when "restore" is wrong. But I think, WebKit don't need to save/restore value of <input type="hidden" .../> because user don't input the value and user can't notice WebKit's "restore". Index: WebCore/html/HTMLInputElement.cpp =================================================================== --- WebCore/html/HTMLInputElement.cpp (revision 44489) +++ WebCore/html/HTMLInputElement.cpp (working copy) @@ -422,7 +422,6 @@ case BUTTON: case EMAIL: case FILE: - case HIDDEN: case IMAGE: case ISINDEX: case NUMBER: @@ -440,6 +439,7 @@ setChecked(state == "on"); break; case PASSWORD: + case HIDDEN: break; } } 200297 1 dglazkov 2010-03-16 11:03:30 -0700 I think it's reasonable for hidden input state not to be restored. Darin, Alexey, WDYT? 200302 2 dglazkov 2010-03-16 11:07:05 -0700 I can prepare a patch/reduction if you think it's a good idea. 200308 3 darin 2010-03-16 11:10:40 -0700 The discussion here makes no mention of other web browsers or HTML5. Could you check to see what the behavior is in IE and Firefox and also whether the HTML5 specification prescribes specific behavior for this case? 200314 4 ap 2010-03-16 11:19:56 -0700 You may want to have a look at bug 23346 and bug 8613. These seem vague, with extremely unhelpful titles, but hopefully there is some insight anyway. Would be nice to re-title this bug, too. 200381 5 dglazkov 2010-03-16 12:55:12 -0700 (In reply to comment #3) > The discussion here makes no mention of other web browsers or HTML5. Could you > check to see what the behavior is in IE and Firefox and also whether the HTML5 > specification prescribes specific behavior for this case? Neither Firefox nor IE do this. HTML5 spec doesn't define behavior or restoring/saving form values on navigation. It just mentions that user agents may persist the form controls state: http://www.whatwg.org/specs/web-apps/current-work/multipage/history.html#history. 200386 6 ap 2010-03-16 13:09:29 -0700 Another possibly related issue: bug 31413. 200388 7 darin 2010-03-16 13:14:47 -0700 (In reply to comment #5) > (In reply to comment #3) > > The discussion here makes no mention of other web browsers or HTML5. Could you > > check to see what the behavior is in IE and Firefox and also whether the HTML5 > > specification prescribes specific behavior for this case? > > Neither Firefox nor IE do this. Neither restore form control state at all? Or neither restore form control state for <input type=hidden>? 206399 8 tkent 2010-03-31 00:59:53 -0700 It seems behavior of IE and Firefox is just restoring the whole DOM tree and clearing type=password. 206576 9 darin 2010-03-31 10:43:40 -0700 (In reply to comment #8) > It seems behavior of IE and Firefox is just restoring the whole DOM tree and > clearing type=password. Form values aren’t in the DOM tree, so I’m not sure what you mean exactly. 207093 10 tkent 2010-04-01 05:05:49 -0700 (In reply to comment #9) > (In reply to comment #8) > > It seems behavior of IE and Firefox is just restoring the whole DOM tree and > > clearing type=password. > > Form values aren’t in the DOM tree, so I’m not sure what you mean exactly. HTMLInputElement::value is a part of the DOM tree, isn't it? http://www.w3.org/TR/DOM-Level-2-HTML/html.html#ID-6043025 Anyway, I meant IE/Firefox had a cache for rendered pages. I guess they don't delete objects representing a page when a user leaves the page and visits another page. So their `Back' operation don't re-fetch the page, don't parse the HTML, and just show the objects on memory. 207476 11 darin 2010-04-01 16:34:28 -0700 (In reply to comment #10) > Anyway, I meant IE/Firefox had a cache for rendered pages. I guess they don't > delete objects representing a page when a user leaves the page and visits > another page. So their `Back' operation don't re-fetch the page, don't parse > the HTML, and just show the objects on memory. That may be true in some cases, but it's definitely not true in all cases. If that were true, then the browsers would have to keep all pages in your entire back history in memory, and I assure you they do not. 207786 12 52400 tkent 2010-04-02 01:03:54 -0700 Created attachment 52400 Proposed patch 207948 13 52400 commit-queue 2010-04-02 11:14:18 -0700 Comment on attachment 52400 Proposed patch Rejecting patch 52400 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12615 test cases. fast/forms/button-state-restore.html -> failed Exiting early after 1 failures. 6615 tests run. 109.28s total testing time 6614 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 2 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/1676001 207992 14 tkent 2010-04-02 12:12:16 -0700 (In reply to comment #13) > (From update of attachment 52400 [details]) > Rejecting patch 52400 from commit-queue. > > Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', > '--exit-after-n-failures=1', '--quiet']" exit_code: 1 > Running build-dumprendertree > Compiling Java tests > make: Nothing to be done for `default'. > Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests > Testing 12615 test cases. > fast/forms/button-state-restore.html -> failed I forgot to add button-state-restore.html to the patch... It's a simple change to follow the behavior change. I manually landed the patch with button-state-restore.html as r57013 208739 15 tkent 2010-04-05 15:25:21 -0700 *** Bug 37087 has been marked as a duplicate of this bug. *** 221065 16 tkent 2010-05-05 05:24:39 -0700 *** Bug 28380 has been marked as a duplicate of this bug. *** 52400 2010-04-02 01:03:54 -0700 2010-04-02 12:12:34 -0700 Proposed patch bug-26241-20100402170352.patch text/plain 6717 tkent ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlYjg0N2RlLi4zZWM3MWFmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQt MDIgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvcm0gY29udHJvbCBzdGF0ZSBzaG91bGRu J3QgYmUgcmVzdG9yZWQgZm9yIGhpZGRlbiBpbnB1dHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjI0MQorCisgICAgICAgICogZmFzdC9mb3Jtcy9z dGF0ZS1yZXN0b3JlLXRvLW5vbi1lZGl0ZWQtY29udHJvbHMtZXhwZWN0ZWQudHh0OiBBZGRlZC4K KyAgICAgICAgKiBmYXN0L2Zvcm1zL3N0YXRlLXJlc3RvcmUtdG8tbm9uLWVkaXRlZC1jb250cm9s cy5odG1sOiBBZGRlZC4KKwogMjAxMC0wNC0wMSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3 LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gUm9sbG91dCBvZiBodHRwOi8v dHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC81NjkzMApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9mb3Jtcy9zdGF0ZS1yZXN0b3JlLXRvLW5vbi1lZGl0ZWQtY29udHJvbHMtZXhwZWN0ZWQu dHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zdGF0ZS1yZXN0b3JlLXRvLW5vbi1lZGl0ZWQt Y29udHJvbHMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAu LmI2NzQ1ZmEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3N0YXRl LXJlc3RvcmUtdG8tbm9uLWVkaXRlZC1jb250cm9scy1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwx MiBAQAorVGVzdCB0byBOT1Qgc2F2ZSBzdGF0ZSBmb3Igbm9uLWVkaXRlZCBjb250cm9scworCitQ QVNTIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJidXR0b24iKS52YWx1ZSBpcyAiMiIKK1BBU1Mg ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImhpZGRlbiIpLnZhbHVlIGlzICIyIgorUEFTUyBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgiaW1hZ2UiKS52YWx1ZSBpcyAiMiIKK1BBU1MgZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoInJlc2V0IikudmFsdWUgaXMgIjIiCitQQVNTIGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJzdWJtaXQxIikudmFsdWUgaXMgIjIiCitQQVNTIGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJ0ZXh0MSIpLnZhbHVlIGlzICJlZGl0IgorUEFTUyBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgidGV4dDIiKS52YWx1ZSBpcyAiMiIKK1BBU1MgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo InRleHRhcmVhIikudmFsdWUgaXMgIjIiCisKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9mb3Jtcy9zdGF0ZS1yZXN0b3JlLXRvLW5vbi1lZGl0ZWQtY29udHJvbHMuaHRtbCBiL0xheW91 dFRlc3RzL2Zhc3QvZm9ybXMvc3RhdGUtcmVzdG9yZS10by1ub24tZWRpdGVkLWNvbnRyb2xzLmh0 bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZTJhYTdlOQotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc3RhdGUtcmVzdG9yZS10by1ub24tZWRp dGVkLWNvbnRyb2xzLmh0bWwKQEAgLTAsMCArMSw1OSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRt bD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi8uLi9mYXN0L2pzL3Jl c291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vLi4vZmFzdC9qcy9y ZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cD5U ZXN0IHRvIE5PVCBzYXZlIHN0YXRlIGZvciBub24tZWRpdGVkIGNvbnRyb2xzPC9wPgorPGRpdiBp ZD0iY29uc29sZSI+PC9kaXY+CisKKzxpbnB1dCBpZD1lbXB0eU9uRmlyc3RWaXNpdD4KKzxkaXYg aWQ9cGFyZW50PgorPC9kaXY+CisKKzxzY3JpcHQ+CisKK2Z1bmN0aW9uIG1ha2VGb3JtKHBhcmVu dCwgYnV0dG9uVmFsdWUsIGhpZGRlblZhbHVlLCBpbWFnZVZhbHVlLCByZXNldFZhbHVlLCBzdWJt aXRWYWx1ZSwgdGV4dFZhbHVlMSwgdGV4dFZhbHVlMiwgdGV4dEFyZWFWYWx1ZSkgeworICAgIHBh cmVudC5pbm5lckhUTUwgPSAnPGZvcm0gYWN0aW9uPSJkYXRhOnRleHQvaHRtbCw8c2NyaXB0Pmhp c3RvcnkuYmFjaygpJmx0Oy9zY3JpcHQ+IiBpZD1mb3JtMT4nCisgICAgICAgICsgJzxpbnB1dCBu YW1lPWJ1dHRvbiBpZD1idXR0b24gdHlwZT1idXR0b24gdmFsdWU9IicgKyBidXR0b25WYWx1ZSAr ICciPicKKyAgICAgICAgKyAnPGlucHV0IG5hbWU9aGlkZGVuIGlkPWhpZGRlbiB0eXBlPWhpZGRl biB2YWx1ZT0iJyArIGhpZGRlblZhbHVlICsgJyI+JworICAgICAgICArICc8aW5wdXQgbmFtZT1p bWFnZSBpZD1pbWFnZSB0eXBlPWltYWdlIHZhbHVlPSInICsgaW1hZ2VWYWx1ZSArICciPicKKyAg ICAgICAgKyAnPGlucHV0IG5hbWU9cmVzZXQgaWQ9cmVzZXQgdHlwZT1yZXNldCB2YWx1ZT0iJyAr IHJlc2V0VmFsdWUgKyAnIj4nCisgICAgICAgICsgJzxpbnB1dCBuYW1lPXN1Ym1pdDEgaWQ9c3Vi bWl0MSB0eXBlPXN1Ym1pdCB2YWx1ZT0iJyArIHN1Ym1pdFZhbHVlICsgJyI+JworICAgICAgICAr ICc8aW5wdXQgbmFtZT10ZXh0MSBpZD10ZXh0MSB0eXBlPXRleHQgdmFsdWU9IicgKyB0ZXh0VmFs dWUxICsgJyI+JworICAgICAgICArICc8aW5wdXQgbmFtZT10ZXh0MiBpZD10ZXh0MiB0eXBlPXRl eHQgdmFsdWU9IicgKyB0ZXh0VmFsdWUyICsgJyI+JworICAgICAgICArICc8dGV4dGFyZWEgbmFt ZT10ZXh0YXJlYSBpZD10ZXh0YXJlYT4nICsgdGV4dEFyZWFWYWx1ZSArICc8L3RleHRhcmVhPicK KyAgICAgICAgKyAnPC9mb3JtPic7Cit9CisKK3ZhciBwYXJlbnQgPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgncGFyZW50Jyk7Cit2YXIgc3RhdGUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgn ZW1wdHlPbkZpcnN0VmlzaXQnKTsKK2lmICghc3RhdGUudmFsdWUpIHsKKyAgICAvLyBGaXJzdCB2 aXNpdC4KKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICBsYXlv dXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CisgICAgc3RhdGUudmFsdWUgPSAndmlz aXRlZCc7CisgICAgbWFrZUZvcm0ocGFyZW50LCAnMScsICcxJywgJzEnLCAnMScsICcxJywgJzEn LCAnMScsICcxJyk7CisKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGV4dDEnKS52YWx1 ZSA9ICdlZGl0JzsKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnZm9ybTEnKS5zdWJtaXQo KTsKK30gZWxzZSB7CisgICAgLy8gU2Vjb25kIHZpc2l0LgorICAgIG1ha2VGb3JtKHBhcmVudCwg JzInLCAnMicsICcyJywgJzInLCAnMicsICcyJywgJzInLCAnMicpOworCisgICAgc2hvdWxkQmUo J2RvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJidXR0b24iKS52YWx1ZScsICciMiInKTsKKyAgICBz aG91bGRCZSgnZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImhpZGRlbiIpLnZhbHVlJywgJyIyIicp OworICAgIHNob3VsZEJlKCdkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiaW1hZ2UiKS52YWx1ZScs ICciMiInKTsKKyAgICBzaG91bGRCZSgnZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlc2V0Iiku dmFsdWUnLCAnIjIiJyk7CisgICAgc2hvdWxkQmUoJ2RvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJz dWJtaXQxIikudmFsdWUnLCAnIjIiJyk7CisgICAgc2hvdWxkQmUoJ2RvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJ0ZXh0MSIpLnZhbHVlJywgJyJlZGl0IicpOworICAgIHNob3VsZEJlKCdkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgidGV4dDIiKS52YWx1ZScsICciMiInKTsKKyAgICBzaG91bGRCZSgn ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRleHRhcmVhIikudmFsdWUnLCAnIjIiJyk7CisKKyAg ICBwYXJlbnQuaW5uZXJIVE1MID0gJyc7CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJv bGxlcikKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworfQorPC9z Y3JpcHQ+Cis8L2JvZHk+CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IDg4NDQ1YmIuLmRhMDgyNTggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hh bmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTAtMDQt MDIgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvcm0gY29udHJvbCBzdGF0ZSBzaG91bGRu J3QgYmUgcmVzdG9yZWQgZm9yIGhpZGRlbiBpbnB1dHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjI0MQorCisgICAgICAgIFRvIGZpeCB0aGlzIGlz c3VlLCB3ZSBkb24ndCBzYXZlIHZhbHVlcyBpZiBpdCBpcyBub3QgY2hhbmdlZCBmcm9tCisgICAg ICAgIHRoZSBkZWZhdWx0IHZhbHVlLgorCisgICAgICAgIFVwZGF0aW5nIHRoZSB2YWx1ZSBJREwg YXR0cmlidXRlIG9mIHNvbWUgY29udHJvbHMgc3VjaCBhcworICAgICAgICB0eXBlPWhpZGRlbiBh bHNvIHVwZGF0ZXMgdGhlIHZhbHVlIGNvbnRlbnQgYXR0cmlidXRlLCBhbmQgaXQncworICAgICAg ICBpbXBvc3NpYmxlIHRvIGRpc3Rpbmd1aXNoIHRoZSBpbml0aWFsIHZhbHVlIGFuZCB0aGUgY3Vy cmVudAorICAgICAgICB2YWx1ZS4gVGhlIHZhbHVlcyBvZiBzdWNoIGNvbnRyb2xzIGFyZSBub3Qg c2F2ZWQuIEl0IHdvbid0IGJlIGEKKyAgICAgICAgcHJvYmxlbSBiZWNhdXNlIHdlIHdhbnQgdG8g c2F2ZSBhbmQgcmVzdG9yZSB1c2VyLWVkaXRlZCB2YWx1ZXMuCisKKyAgICAgICAgVGVzdDogZmFz dC9mb3Jtcy9zdGF0ZS1yZXN0b3JlLXRvLW5vbi1lZGl0ZWQtY29udHJvbHMuaHRtbAorCisgICAg ICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxJ bnB1dEVsZW1lbnQ6OnNhdmVGb3JtQ29udHJvbFN0YXRlKToKKyAgICAgICAgICBEbyBub3Qgc2F2 ZSB0aGUgdmFsdWUgaWYgaXQgaXMgc2FtZSBhcyB0aGUgZGVmYXVsdCB2YWx1ZS4KKyAgICAgICAg KiBodG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRl eHRBcmVhRWxlbWVudDo6c2F2ZUZvcm1Db250cm9sU3RhdGUpOiBkaXR0by4KKwogMjAxMC0wNC0w MSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZC4gUm9sbG91dCBvZiBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC81 NjkzMApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwIGIvV2Vi Q29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCmluZGV4IDllNzE5MTguLjRkOWZiZmMgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAorKysgYi9XZWJDb3Jl L2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKQEAgLTkzNSw5ICs5MzUsMTMgQEAgYm9vbCBIVE1M SW5wdXRFbGVtZW50OjpzYXZlRm9ybUNvbnRyb2xTdGF0ZShTdHJpbmcmIHJlc3VsdCkgY29uc3QK ICAgICAgICAgY2FzZSBURVhUOgogICAgICAgICBjYXNlIFRJTUU6CiAgICAgICAgIGNhc2UgVVJM OgotICAgICAgICBjYXNlIFdFRUs6Ci0gICAgICAgICAgICByZXN1bHQgPSB2YWx1ZSgpOworICAg ICAgICBjYXNlIFdFRUs6IHsKKyAgICAgICAgICAgIFN0cmluZyBjdXJyZW50VmFsdWUgPSB2YWx1 ZSgpOworICAgICAgICAgICAgaWYgKGN1cnJlbnRWYWx1ZSA9PSBkZWZhdWx0VmFsdWUoKSkKKyAg ICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgICAgICByZXN1bHQgPSBjdXJyZW50 VmFsdWU7CiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgfQogICAgICAgICBjYXNl IENIRUNLQk9YOgogICAgICAgICBjYXNlIFJBRElPOgogICAgICAgICAgICAgcmVzdWx0ID0gY2hl Y2tlZCgpID8gIm9uIiA6ICJvZmYiOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUxUZXh0 QXJlYUVsZW1lbnQuY3BwIGIvV2ViQ29yZS9odG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuY3BwCmlu ZGV4IDBhZDI5OGUuLjM2ZTgzYmUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MVGV4dEFy ZWFFbGVtZW50LmNwcAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTFRleHRBcmVhRWxlbWVudC5jcHAK QEAgLTg2LDcgKzg2LDEwIEBAIGNvbnN0IEF0b21pY1N0cmluZyYgSFRNTFRleHRBcmVhRWxlbWVu dDo6Zm9ybUNvbnRyb2xUeXBlKCkgY29uc3QKIAogYm9vbCBIVE1MVGV4dEFyZWFFbGVtZW50Ojpz YXZlRm9ybUNvbnRyb2xTdGF0ZShTdHJpbmcmIHJlc3VsdCkgY29uc3QKIHsKLSAgICByZXN1bHQg PSB2YWx1ZSgpOworICAgIFN0cmluZyBjdXJyZW50VmFsdWUgPSB2YWx1ZSgpOworICAgIGlmIChj dXJyZW50VmFsdWUgPT0gZGVmYXVsdFZhbHVlKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKyAg ICByZXN1bHQgPSBjdXJyZW50VmFsdWU7CiAgICAgcmV0dXJuIHRydWU7CiB9CiAK