262356 2023-09-28 22:13:02 -0700 AX: Add debug description method for accessibility objects 2023-09-29 12:53:53 -0700 1 1 1 Unclassified WebKit Accessibility Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tyler_w tyler_w aboxhall andresg_22 apinheiro cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1981199 0 tyler_w 2023-09-28 22:13:02 -0700 ... 1981200 1 webkit-bug-importer 2023-09-28 22:13:20 -0700 <rdar://problem/116220179> 1981202 2 467972 tyler_w 2023-09-28 23:06:53 -0700 Created attachment 467972 Patch 1981203 3 467972 cfleizach 2023-09-28 23:24:37 -0700 Comment on attachment 467972 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=467972&action=review > Source/WebCore/accessibility/AccessibilityObject.cpp:115 > +String AccessibilityObject::dbg() const can we give this a proper name? or is this standard throughout webkit? in Cocoa it would be ::description() 1981204 4 tyler_w 2023-09-28 23:33:50 -0700 (In reply to chris fleizach from comment #3) > Comment on attachment 467972 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=467972&action=review > > > Source/WebCore/accessibility/AccessibilityObject.cpp:115 > > +String AccessibilityObject::dbg() const > > can we give this a proper name? or is this standard throughout webkit? > > in Cocoa it would be ::description() I think the standard name in WebKit is "debugDescription". But that's way more characters than dbg(), and I'm typing this very very often, and Xcode doesn't autocomplete C++ (at least in WebKit). So I recognize this goes against the style guide, but maybe that's OK for a function of this purpose? What do y'all think? 1981205 5 467972 cfleizach 2023-09-28 23:41:34 -0700 Comment on attachment 467972 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=467972&action=review >>> Source/WebCore/accessibility/AccessibilityObject.cpp:115 >>> +String AccessibilityObject::dbg() const >> >> can we give this a proper name? or is this standard throughout webkit? >> >> in Cocoa it would be ::description() > > I think the standard name in WebKit is "debugDescription". But that's way more characters than dbg(), and I'm typing this very very often, and Xcode doesn't autocomplete C++ (at least in WebKit). So I recognize this goes against the style guide, but maybe that's OK for a function of this purpose? What do y'all think? your reasoning makes sense should we wrap this in #if !NDEBUG 1981206 6 tyler_w 2023-09-28 23:44:44 -0700 (In reply to chris fleizach from comment #5) > Comment on attachment 467972 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=467972&action=review > > >>> Source/WebCore/accessibility/AccessibilityObject.cpp:115 > >>> +String AccessibilityObject::dbg() const > >> > >> can we give this a proper name? or is this standard throughout webkit? > >> > >> in Cocoa it would be ::description() > > > > I think the standard name in WebKit is "debugDescription". But that's way more characters than dbg(), and I'm typing this very very often, and Xcode doesn't autocomplete C++ (at least in WebKit). So I recognize this goes against the style guide, but maybe that's OK for a function of this purpose? What do y'all think? > > your reasoning makes sense > > should we wrap this in #if !NDEBUG It would be nice to have this method available in release, too, for times when debug builds are too slow. This also matches Node::debugDescription and RenderObject::debugDescription which are not guarded by !NDEBUG. 1981376 7 ews-feeder 2023-09-29 12:53:51 -0700 Committed 268666@main (613ac6287437): <https://commits.webkit.org/268666@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 467972. 467972 2023-09-28 23:06:53 -0700 2023-09-29 12:53:52 -0700 Patch bug-262356-20230928230653.patch text/plain 4616 tyler_w RnJvbSA4MjQxYTcyMWRiZWY4YTQ4Yzc1NjcxNzI2ZmE3ZDkxYjJmMDAyMjFiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUeWxlciBXaWxjb2NrIDx0eWxlcl93QGFwcGxlLmNvbT4KRGF0 ZTogVGh1LCAyOCBTZXAgMjAyMyAyMjoxNDowOSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIEFYOiBB ZGQgZGVidWcgZGVzY3JpcHRpb24gbWV0aG9kIGZvciBhY2Nlc3NpYmlsaXR5IG9iamVjdHMKIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjIzNTYgcmRhcjovL3Byb2Js ZW0vMTE2MjIwMTc5CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiogU291cmNlL1dlYkNv cmUvYWNjZXNzaWJpbGl0eS9BWENvcmVPYmplY3QuaDoKKiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwOgooV2ViQ29yZTo6QWNjZXNzaWJpbGl0eU9i amVjdDo6ZGJnIGNvbnN0KToKKiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2li aWxpdHlPYmplY3QuaDoKKiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJl ZS9BWElzb2xhdGVkT2JqZWN0LmNwcDoKKFdlYkNvcmU6OkFYSXNvbGF0ZWRPYmplY3Q6OmRiZyBj b25zdCk6CiogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29s YXRlZE9iamVjdC5oOgotLS0KIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhDb3JlT2Jq ZWN0LmggICAgICAgfCAgMSArCiAuLi4vV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxp dHlPYmplY3QuY3BwIHwgMTUgKysrKysrKysrKysrKysrCiAuLi4vV2ViQ29yZS9hY2Nlc3NpYmls aXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuaCAgIHwgIDEgKwogLi4uL2lzb2xhdGVkdHJlZS9BWElz b2xhdGVkT2JqZWN0LmNwcCAgICAgICAgICAgICB8ICA4ICsrKysrKysrCiAuLi4vYWNjZXNzaWJp bGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5oIHwgIDEgKwogNSBmaWxlcyBjaGFu Z2VkLCAyNiBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9BWENvcmVPYmplY3QuaCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhD b3JlT2JqZWN0LmgKaW5kZXggMjhlMWM1MmQ0MjY4Li5lN2FiMzM4MjVmMzAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhDb3JlT2JqZWN0LmgKKysrIGIvU291cmNl L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWENvcmVPYmplY3QuaApAQCAtODIxLDYgKzgyMSw3IEBA IHN0cnVjdCBBY2Nlc3NpYmlsaXR5SXNJZ25vcmVkRnJvbVBhcmVudERhdGEgewogY2xhc3MgQVhD b3JlT2JqZWN0IDogcHVibGljIFRocmVhZFNhZmVSZWZDb3VudGVkQW5kQ2FuTWFrZVRocmVhZFNh ZmVXZWFrUHRyPEFYQ29yZU9iamVjdD4gewogcHVibGljOgogICAgIHZpcnR1YWwgfkFYQ29yZU9i amVjdCgpID0gZGVmYXVsdDsKKyAgICB2aXJ0dWFsIFN0cmluZyBkYmcoKSBjb25zdCA9IDA7CiAK ICAgICB2b2lkIHNldE9iamVjdElEKEFYSUQgYXhJRCkgeyBtX2lkID0gYXhJRDsgfQogICAgIEFY SUQgb2JqZWN0SUQoKSBjb25zdCB7IHJldHVybiBtX2lkOyB9CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwIGIvU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcAppbmRleCAyMGZjNzMw YTA4YzUuLjdkMGY1NWI0MDkwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJp bGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwCkBAIC0xMTIsNiArMTEyLDIxIEBAIGlubGlu ZSBQcm9jZXNzSUQgQWNjZXNzaWJpbGl0eU9iamVjdDo6cHJvY2Vzc0lEKCkgY29uc3QKICAgICBy ZXR1cm4gcHJlc2VudGluZ0FwcGxpY2F0aW9uUElEKCk7CiB9CiAKK1N0cmluZyBBY2Nlc3NpYmls aXR5T2JqZWN0OjpkYmcoKSBjb25zdAoreworICAgIFN0cmluZyBiYWNraW5nRW50aXR5RGVzY3Jp cHRpb247CisgICAgaWYgKGF1dG8qIHJlbmRlcmVyID0gdGhpcy0+cmVuZGVyZXIoKSkKKyAgICAg ICAgYmFja2luZ0VudGl0eURlc2NyaXB0aW9uID0gbWFrZVN0cmluZygiLCAiLCByZW5kZXJlci0+ ZGVidWdEZXNjcmlwdGlvbigpKTsKKyAgICBlbHNlIGlmIChhdXRvKiBub2RlID0gdGhpcy0+bm9k ZSgpKQorICAgICAgICBiYWNraW5nRW50aXR5RGVzY3JpcHRpb24gPSBtYWtlU3RyaW5nKCIsICIs IG5vZGUtPmRlYnVnRGVzY3JpcHRpb24oKSk7CisKKyAgICByZXR1cm4gbWFrZVN0cmluZygKKyAg ICAgICAgIntyb2xlOiAiLCBhY2Nlc3NpYmlsaXR5Um9sZVRvU3RyaW5nKHJvbGVWYWx1ZSgpKSwK KyAgICAgICAgIiwgSUQgIiwgb2JqZWN0SUQoKS5sb2dnaW5nU3RyaW5nKCksCisgICAgICAgIGJh Y2tpbmdFbnRpdHlEZXNjcmlwdGlvbiwgIn0iCisgICAgKTsKK30KKwogdm9pZCBBY2Nlc3NpYmls aXR5T2JqZWN0OjpkZXRhY2hSZW1vdGVQYXJ0cyhBY2Nlc3NpYmlsaXR5RGV0YWNobWVudFR5cGUg ZGV0YWNobWVudFR5cGUpCiB7CiAgICAgLy8gTWVudSBjbG9zZSBldmVudHMgbmVlZCB0byBub3Rp ZnkgdGhlIHBsYXRmb3JtLiBObyBlbGVtZW50IGlzIHVzZWQgaW4gdGhlIG5vdGlmaWNhdGlvbiBi ZWNhdXNlIGl0J3MgYSBkZXN0cnVjdGlvbiBldmVudC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5oIGIvU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmgKaW5kZXggN2Q5YTIwNDk4MDIxLi5k MjlkYmNiYjIzZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNj ZXNzaWJpbGl0eU9iamVjdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNj ZXNzaWJpbGl0eU9iamVjdC5oCkBAIC03NCw2ICs3NCw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFs IH5BY2Nlc3NpYmlsaXR5T2JqZWN0KCk7CiAKICAgICBQcm9jZXNzSUQgcHJvY2Vzc0lEKCkgY29u c3Qgb3ZlcnJpZGU7CisgICAgU3RyaW5nIGRiZygpIGNvbnN0IGZpbmFsOwogCiAgICAgLy8gQWZ0 ZXIgY29uc3RydWN0aW5nIGFuIEFjY2Vzc2liaWxpdHlPYmplY3QsIGl0IG11c3QgYmUgZ2l2ZW4g YQogICAgIC8vIHVuaXF1ZSBJRCwgdGhlbiBhZGRlZCB0byBBWE9iamVjdENhY2hlLCBhbmQgZmlu YWxseSBpbml0KCkgbXVzdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkT2JqZWN0LmNwcAppbmRleCA2YTk4MTlm NzI4YjIuLjRlZWFlYzI0MDE1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJp bGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5jcHAKQEAgLTY4 LDYgKzY4LDE0IEBAIEFYSXNvbGF0ZWRPYmplY3Q6On5BWElzb2xhdGVkT2JqZWN0KCkKICAgICBB U1NFUlQoIXdyYXBwZXIoKSk7CiB9CiAKK1N0cmluZyBBWElzb2xhdGVkT2JqZWN0OjpkYmcoKSBj b25zdAoreworICAgIHJldHVybiBtYWtlU3RyaW5nKAorICAgICAgICAie3JvbGU6ICIsIGFjY2Vz c2liaWxpdHlSb2xlVG9TdHJpbmcocm9sZVZhbHVlKCkpLAorICAgICAgICAiLCBJRCAiLCBvYmpl Y3RJRCgpLmxvZ2dpbmdTdHJpbmcoKSwgIn0iCisgICAgKTsKK30KKwogdm9pZCBBWElzb2xhdGVk T2JqZWN0Ojppbml0aWFsaXplUHJvcGVydGllcyhjb25zdCBSZWY8QWNjZXNzaWJpbGl0eU9iamVj dD4mIGF4T2JqZWN0KQogewogICAgIGF1dG8mIG9iamVjdCA9IGF4T2JqZWN0LmdldCgpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29s YXRlZE9iamVjdC5oIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUv QVhJc29sYXRlZE9iamVjdC5oCmluZGV4IGFmOTk5NjViODNkOC4uNDdkM2U3YzZkN2M0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xh dGVkT2JqZWN0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRy ZWUvQVhJc29sYXRlZE9iamVjdC5oCkBAIC01Miw2ICs1Miw3IEBAIHB1YmxpYzoKICAgICB+QVhJ c29sYXRlZE9iamVjdCgpOwogCiAgICAgUHJvY2Vzc0lEIHByb2Nlc3NJRCgpIGNvbnN0IG92ZXJy aWRlIHsgcmV0dXJuIHRyZWUoKS0+cHJvY2Vzc0lEKCk7IH0KKyAgICBTdHJpbmcgZGJnKCkgY29u c3QgZmluYWw7CiAKICAgICB2b2lkIGF0dGFjaFBsYXRmb3JtV3JhcHBlcihBY2Nlc3NpYmlsaXR5 T2JqZWN0V3JhcHBlciopOwogICAgIGJvb2wgaXNEZXRhY2hlZCgpIGNvbnN0IG92ZXJyaWRlOwo=