262186 2023-09-27 07:39:20 -0700 [IFC][Ruby] Resize annotation renderer after inline layout when needed 2023-09-27 09:23:12 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1980507 0 zalan 2023-09-27 07:39:20 -0700 ssia 1980510 1 467900 zalan 2023-09-27 07:45:49 -0700 Created attachment 467900 Patch 1980513 2 467901 zalan 2023-09-27 07:57:34 -0700 Created attachment 467901 [fast-cq]Patch 1980514 3 467901 koivisto 2023-09-27 07:59:05 -0700 Comment on attachment 467901 [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=467901&action=review > Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:638 > + renderer.setOverridingLogicalWidthLength({ usedMarginBoxSize.width(), LengthType::Fixed }); amazing 1980528 4 zalan 2023-09-27 08:54:12 -0700 (In reply to Antti Koivisto from comment #3) > Comment on attachment 467901 [details] > [fast-cq]Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=467901&action=review > > > Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:638 > > + renderer.setOverridingLogicalWidthLength({ usedMarginBoxSize.width(), LengthType::Fixed }); > > amazing the best! 1980538 5 ews-feeder 2023-09-27 09:22:47 -0700 Committed 268512@main (178cde2d00a3): <https://commits.webkit.org/268512@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 467901. 1980539 6 webkit-bug-importer 2023-09-27 09:23:12 -0700 <rdar://problem/116125323> 467900 2023-09-27 07:45:49 -0700 2023-09-27 07:57:32 -0700 Patch bug-262186-20230927074548.patch text/plain 2929 zalan RnJvbSA1Y2FjNmEwZDJkY2Y3ZGJhNzMwOGNkNmFmODNlOTc3NDE0Y2ZiZGFjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IFdlZCwgMjcgU2VwIDIwMjMgMDc6Mzk6MjkgLTA3MDAKU3ViamVjdDogW1BBVENIXSBbSUZDXVtS dWJ5XSBSZXNpemUgYW5ub3RhdGlvbiByZW5kZXJlciBhZnRlciBpbmxpbmUgbGF5b3V0CiB3aGVu IG5lZWRlZCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjYyMTg2CgpS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCldoZW4gYW5ub3RhdGlvbiBib3ggZ2V0cyByZXNp emVkIGR1cmluZyBydWJ5IGxheW91dCAoZS5nLiBiYXNlIHN0cmV0Y2hlcyB0aGUgcnVieSBjb2x1 bW4pIHdlIGhhdmUgdG8KbWFrZSBzdXJlIHRoZSBhc3NvY2lhdGVkIHJlbmRlcmVyIGdldHMgcmVz aXplZCB0b28uIFdlIGFsc28gbmVlZCB0byBpbml0aWF0ZSBhIGxheW91dCBvbiB0aGUgYW5ub3Rh dGlvbgpjb250ZW50IHRvIGVuc3VyZSBwcm9wZXIgY29udGVudCBhbGlnbm1lbnQuCihUaGlzIGlz IGEgdGVtcG9yYXJ5IHdvcmthcm91bmQgYW5kIGdlbmVyYXRpbmcgaW5saW5lIGJveGVzIChhbmQg bm90IGlubGluZS1ibG9ja3MpIGZvciBhbm5vdGF0aW9ucyB3aWxsIHJlbmRlciBpdCByZWR1bmRh bnQuKQoKKiBTb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vaW5saW5lL0xheW91dElu dGVncmF0aW9uTGluZUxheW91dC5jcHA6CihXZWJDb3JlOjpMYXlvdXRJbnRlZ3JhdGlvbjo6TGlu ZUxheW91dDo6dXBkYXRlUmVuZGVyVHJlZVBvc2l0aW9ucyk6Ci0tLQogLi4uL2lubGluZS9MYXlv dXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwICAgICAgfCAxNyArKysrKysrKysrKysrKystLQog MSBmaWxlIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL2lubGluZS9MYXlvdXRJbnRl Z3JhdGlvbkxpbmVMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9u L2lubGluZS9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwCmluZGV4IDk5ODIwZGY5M2U5 YS4uZGRmZWVkNzE3NDcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdy YXRpb24vaW5saW5lL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL2lubGluZS9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVM YXlvdXQuY3BwCkBAIC02MTUsOCArNjE1LDcgQEAgdm9pZCBMaW5lTGF5b3V0Ojp1cGRhdGVSZW5k ZXJUcmVlUG9zaXRpb25zKGNvbnN0IFZlY3RvcjxMaW5lQWRqdXN0bWVudD4mIGxpbmVBZGoKICAg ICAgICAgICAgIGNvbnRpbnVlOwogCiAgICAgICAgIGF1dG8mIGxheW91dEJveCA9IGJveC5sYXlv dXRCb3goKTsKLQotICAgICAgICBpZiAoIWxheW91dEJveC5pc0F0b21pY0lubGluZUxldmVsQm94 KCkgJiYgIWxheW91dEJveC5pc1J1YnlBbm5vdGF0aW9uQm94KCkpCisgICAgICAgIGlmICghbGF5 b3V0Qm94LmlzQXRvbWljSW5saW5lTGV2ZWxCb3goKSkKICAgICAgICAgICAgIGNvbnRpbnVlOwog CiAgICAgICAgIGF1dG8mIHJlbmRlcmVyID0gZG93bmNhc3Q8UmVuZGVyQm94PihtX2JveFRyZWUu cmVuZGVyZXJGb3JMYXlvdXRCb3gobGF5b3V0Qm94KSk7CkBAIC02MjcsNiArNjI2LDIwIEBAIHZv aWQgTGluZUxheW91dDo6dXBkYXRlUmVuZGVyVHJlZVBvc2l0aW9ucyhjb25zdCBWZWN0b3I8TGlu ZUFkanVzdG1lbnQ+JiBsaW5lQWRqCiAgICAgICAgIGF1dG8gYWRqdXN0bWVudE9mZnNldCA9IHZp c3VhbEFkanVzdG1lbnRPZmZzZXQoYm94LmxpbmVJbmRleCgpKTsKIAogICAgICAgICByZW5kZXJl ci5zZXRMb2NhdGlvbihMYXlvdXQ6OkJveEdlb21ldHJ5Ojpib3JkZXJCb3hSZWN0KGxvZ2ljYWxH ZW9tZXRyeSkudG9wTGVmdCgpICsgYWRqdXN0bWVudE9mZnNldCk7CisgICAgICAgIGF1dG8gcmVs YXlvdXRSdWJ5QW5ub3RhdGlvbklmTmVlZGVkID0gWyZdIHsKKyAgICAgICAgICAgIC8vIEFubm90 YXRpb24gaW5saW5lLWJsb2NrIG1heSBnZXQgcmVzaXplZCBkdXJpbmcgaW5saW5lIGxheW91dCAo d2hlbiBiYXNlIGlzIHdpZGVyKSBhbmQKKyAgICAgICAgICAgIC8vIHdlIG5lZWQgdG8gYXBwbHkg dGhpcyBuZXcgc2l6ZSBvbiB0aGUgYW5ub3RhdGlvbiBjb250ZW50IGJ5IHJ1bm5pbmcgbGF5b3V0 LgorICAgICAgICAgICAgaWYgKCFsYXlvdXRCb3guaXNSdWJ5QW5ub3RhdGlvbkJveCgpKQorICAg ICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIGF1dG8gdXNlZE1hcmdpbkJveFNpemUg PSBMYXlvdXQ6OkJveEdlb21ldHJ5OjptYXJnaW5Cb3hSZWN0KGxvZ2ljYWxHZW9tZXRyeSkuc2l6 ZSgpOworICAgICAgICAgICAgaWYgKHVzZWRNYXJnaW5Cb3hTaXplID09IHJlbmRlcmVyLnNpemUo KSkKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICByZW5kZXJlci5zZXRTaXpl KHVzZWRNYXJnaW5Cb3hTaXplKTsKKyAgICAgICAgICAgIHJlbmRlcmVyLnNldE92ZXJyaWRpbmdM b2dpY2FsV2lkdGhMZW5ndGgoeyB1c2VkTWFyZ2luQm94U2l6ZS53aWR0aCgpLCBMZW5ndGhUeXBl OjpGaXhlZCB9KTsKKyAgICAgICAgICAgIHJlbmRlcmVyLnNldE5lZWRzTGF5b3V0KE1hcmtPbmx5 VGhpcyk7CisgICAgICAgICAgICByZW5kZXJlci5sYXlvdXRJZk5lZWRlZCgpOworICAgICAgICB9 OworICAgICAgICByZWxheW91dFJ1YnlBbm5vdGF0aW9uSWZOZWVkZWQoKTsKICAgICB9CiAKICAg ICBIYXNoTWFwPENoZWNrZWRSZWY8Y29uc3QgTGF5b3V0OjpCb3g+LCBMYXlvdXRTaXplPiBmbG9h dFBhZ2luYXRpb25PZmZzZXRNYXA7Cg== 467901 2023-09-27 07:57:34 -0700 2023-09-27 09:22:49 -0700 [fast-cq]Patch bug-262186-20230927075733.patch text/plain 2988 zalan RnJvbSA1NTgzNDlmMGUxOGZkYzUwYWYyM2JkODJkMjhmZTQ3NDNjMGVkOTY4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IFdlZCwgMjcgU2VwIDIwMjMgMDc6Mzk6MjkgLTA3MDAKU3ViamVjdDogW1BBVENIXSBbSUZDXVtS dWJ5XSBSZXNpemUgYW5ub3RhdGlvbiByZW5kZXJlciBhZnRlciBpbmxpbmUgbGF5b3V0CiB3aGVu IG5lZWRlZCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjYyMTg2CgpS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCldoZW4gYW5ub3RhdGlvbiBib3ggZ2V0cyByZXNp emVkIGR1cmluZyBydWJ5IGxheW91dCAoZS5nLiBiYXNlIHN0cmV0Y2hlcyB0aGUgcnVieSBjb2x1 bW4pIHdlIGhhdmUgdG8KbWFrZSBzdXJlIHRoZSBhc3NvY2lhdGVkIHJlbmRlcmVyIGdldHMgcmVz aXplZCB0b28uIFdlIGFsc28gbmVlZCB0byBpbml0aWF0ZSBhIGxheW91dCBvbiB0aGUgYW5ub3Rh dGlvbgpjb250ZW50IHRvIGVuc3VyZSBwcm9wZXIgY29udGVudCBhbGlnbm1lbnQuCihUaGlzIGlz IGEgdGVtcG9yYXJ5IHdvcmthcm91bmQgYW5kIGdlbmVyYXRpbmcgaW5saW5lIGJveGVzIChhbmQg bm90IGlubGluZS1ibG9ja3MpIGZvciBhbm5vdGF0aW9ucyB3aWxsIHJlbmRlciBpdCByZWR1bmRh bnQuKQoKKiBTb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vaW5saW5lL0xheW91dElu dGVncmF0aW9uTGluZUxheW91dC5jcHA6CihXZWJDb3JlOjpMYXlvdXRJbnRlZ3JhdGlvbjo6TGlu ZUxheW91dDo6dXBkYXRlUmVuZGVyVHJlZVBvc2l0aW9ucyk6Ci0tLQogLi4uL2lubGluZS9MYXlv dXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwICAgICB8IDE4ICsrKysrKysrKysrKysrKystLQog MSBmaWxlIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL2lubGluZS9MYXlvdXRJbnRl Z3JhdGlvbkxpbmVMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9u L2lubGluZS9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwCmluZGV4IDk5ODIwZGY5M2U5 YS4uNzVkZTgxYjBlZjJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdy YXRpb24vaW5saW5lL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL2lubGluZS9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVM YXlvdXQuY3BwCkBAIC02MTUsOCArNjE1LDcgQEAgdm9pZCBMaW5lTGF5b3V0Ojp1cGRhdGVSZW5k ZXJUcmVlUG9zaXRpb25zKGNvbnN0IFZlY3RvcjxMaW5lQWRqdXN0bWVudD4mIGxpbmVBZGoKICAg ICAgICAgICAgIGNvbnRpbnVlOwogCiAgICAgICAgIGF1dG8mIGxheW91dEJveCA9IGJveC5sYXlv dXRCb3goKTsKLQotICAgICAgICBpZiAoIWxheW91dEJveC5pc0F0b21pY0lubGluZUxldmVsQm94 KCkgJiYgIWxheW91dEJveC5pc1J1YnlBbm5vdGF0aW9uQm94KCkpCisgICAgICAgIGlmICghbGF5 b3V0Qm94LmlzQXRvbWljSW5saW5lTGV2ZWxCb3goKSkKICAgICAgICAgICAgIGNvbnRpbnVlOwog CiAgICAgICAgIGF1dG8mIHJlbmRlcmVyID0gZG93bmNhc3Q8UmVuZGVyQm94PihtX2JveFRyZWUu cmVuZGVyZXJGb3JMYXlvdXRCb3gobGF5b3V0Qm94KSk7CkBAIC02MjcsNiArNjI2LDIxIEBAIHZv aWQgTGluZUxheW91dDo6dXBkYXRlUmVuZGVyVHJlZVBvc2l0aW9ucyhjb25zdCBWZWN0b3I8TGlu ZUFkanVzdG1lbnQ+JiBsaW5lQWRqCiAgICAgICAgIGF1dG8gYWRqdXN0bWVudE9mZnNldCA9IHZp c3VhbEFkanVzdG1lbnRPZmZzZXQoYm94LmxpbmVJbmRleCgpKTsKIAogICAgICAgICByZW5kZXJl ci5zZXRMb2NhdGlvbihMYXlvdXQ6OkJveEdlb21ldHJ5Ojpib3JkZXJCb3hSZWN0KGxvZ2ljYWxH ZW9tZXRyeSkudG9wTGVmdCgpICsgYWRqdXN0bWVudE9mZnNldCk7CisgICAgICAgIGF1dG8gcmVs YXlvdXRSdWJ5QW5ub3RhdGlvbklmTmVlZGVkID0gWyZdIHsKKyAgICAgICAgICAgIC8vIEFubm90 YXRpb24gaW5saW5lLWJsb2NrIG1heSBnZXQgcmVzaXplZCBkdXJpbmcgaW5saW5lIGxheW91dCAo d2hlbiBiYXNlIGlzIHdpZGVyKSBhbmQKKyAgICAgICAgICAgIC8vIHdlIG5lZWQgdG8gYXBwbHkg dGhpcyBuZXcgc2l6ZSBvbiB0aGUgYW5ub3RhdGlvbiBjb250ZW50IGJ5IHJ1bm5pbmcgbGF5b3V0 LgorICAgICAgICAgICAgaWYgKCFsYXlvdXRCb3guaXNSdWJ5QW5ub3RhdGlvbkJveCgpKQorICAg ICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIGF1dG8gdXNlZE1hcmdpbkJveFNpemUg PSBMYXlvdXQ6OkJveEdlb21ldHJ5OjptYXJnaW5Cb3hSZWN0KGxvZ2ljYWxHZW9tZXRyeSkuc2l6 ZSgpOworICAgICAgICAgICAgaWYgKHVzZWRNYXJnaW5Cb3hTaXplID09IHJlbmRlcmVyLnNpemUo KSkKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICByZW5kZXJlci5zZXRTaXpl KHVzZWRNYXJnaW5Cb3hTaXplKTsKKyAgICAgICAgICAgIHJlbmRlcmVyLnNldE92ZXJyaWRpbmdM b2dpY2FsV2lkdGhMZW5ndGgoeyB1c2VkTWFyZ2luQm94U2l6ZS53aWR0aCgpLCBMZW5ndGhUeXBl OjpGaXhlZCB9KTsKKyAgICAgICAgICAgIHJlbmRlcmVyLnNldE5lZWRzTGF5b3V0KE1hcmtPbmx5 VGhpcyk7CisgICAgICAgICAgICByZW5kZXJlci5sYXlvdXRJZk5lZWRlZCgpOworICAgICAgICAg ICAgcmVuZGVyZXIuY2xlYXJPdmVycmlkaW5nTG9naWNhbFdpZHRoTGVuZ3RoKCk7CisgICAgICAg IH07CisgICAgICAgIHJlbGF5b3V0UnVieUFubm90YXRpb25JZk5lZWRlZCgpOwogICAgIH0KIAog ICAgIEhhc2hNYXA8Q2hlY2tlZFJlZjxjb25zdCBMYXlvdXQ6OkJveD4sIExheW91dFNpemU+IGZs b2F0UGFnaW5hdGlvbk9mZnNldE1hcDsK