26218 2009-06-05 09:30:47 -0700 REGRESSION (r44385): LayoutTests/fast/dom/Window/orphaned-frame-access.html fails on Debug builds 2009-06-15 01:52:12 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED LayoutTestFailure, NeedsReduction, Regression P2 Normal --- 1 ddkilzer webkit-unassigned ap aroben dglazkov mrowe pfeldman timothy yurys oldest_to_newest 124528 0 ddkilzer 2009-06-05 09:30:47 -0700 * SUMMARY LayoutTests/fast/dom/Window/orphaned-frame-access.html fails on the Leopard buildbot: http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/1769 and when run under guard malloc. * STEPS TO REPRODUCE $ ./WebKitTools/Scripts/build-webkit --debug $ ./WebKitTools/Scripts/run-webkit-tests --debug -g fast/dom/Window * RESULTS Test fails thusly: -property: PASS ... array: PASS ... missing property: PASS. +property: PASS ... array: PASS ... [object CommentConstructor] * REGRESSION This seems to be a recent regression. 124530 1 ddkilzer 2009-06-05 09:37:18 -0700 Actually, this doesn't require running under guard malloc to reproduce, just a Debug build: $ ./WebKitTools/Scripts/run-webkit-tests --debug fast/dom/Window/orphaned-frame-access.html 124682 2 ddkilzer 2009-06-07 06:14:18 -0700 An internal build bisect reveals: Works: r44383 Fails: r44388 124687 3 ddkilzer 2009-06-07 06:58:53 -0700 (In reply to comment #2) > An internal build bisect reveals: > > Works: r44383 Fails: r44388 However improbable this seems, a git-bisect reveals that this broke with a Debug build of r44385. <http://trac.webkit.org/changeset/44385> 124688 4 ddkilzer 2009-06-07 07:06:36 -0700 (In reply to comment #3) > (In reply to comment #2) > > An internal build bisect reveals: > > > > Works: r44383 Fails: r44388 > > However improbable this seems, a git-bisect reveals that this broke with a > Debug build of r44385. > > <http://trac.webkit.org/changeset/44385> Note that I had to apply the build fix in r44388 to both r44384 and r44385 to test this. <http://trac.webkit.org/changeset/44388> 124927 5 pfeldman 2009-06-09 06:25:14 -0700 I confirm that 44385 is breaking the test, Yury has a fix on its way. 124928 6 31090 yurys 2009-06-09 06:33:33 -0700 Created attachment 31090 When checking for main resource loading make sure that loader's frame is the main one. 124974 7 31090 mitz 2009-06-09 10:48:02 -0700 Comment on attachment 31090 When checking for main resource loading make sure that loader's frame is the main one. > +bool InspectorController::isMainResourceLoader(DocumentLoader* loader, const KURL& requestUrl) { > + return loader->frame() == m_inspectedPage->mainFrame() && requestUrl == loader->requestURL(); > +} The opening brace at the beginning of a function definition should go on a separate line. 125045 8 bfulgham 2009-06-09 17:26:14 -0700 Landed in @r44549. 125087 9 ddkilzer 2009-06-09 21:41:22 -0700 (In reply to comment #8) > Landed in @r44549. http://trac.webkit.org/changeset./44549 125088 10 ddkilzer 2009-06-09 21:41:40 -0700 (In reply to comment #8) > Landed in @r44549. http://trac.webkit.org/changeset/44549 125907 11 ap 2009-06-15 01:52:12 -0700 +bool InspectorController::isMainResourceLoader(DocumentLoader* loader, const KURL& requestUrl) +{ + return loader->frame() == m_inspectedPage->mainFrame() && requestUrl == loader->requestURL(); +} This looks like a bad misnomer to me. Our MainResourceLoader class is used for any frame's main resource, so the words "main resource" are not appropriate here. Could you please make a patch to fix this (in a new bug)? 31090 2009-06-09 06:33:33 -0700 2009-06-09 10:01:54 -0700 When checking for main resource loading make sure that loader's frame is the main one. main-frame-check.patch text/plain 3114 yurys SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NDUzMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMDYtMDkgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2hlbiBjaGVja2luZyBpZiB0aGUgbG9hZGVyIGlzIHRoZSBtYWluIHJlc291cmNlIGxvYWRl ciBtYWtlIHN1cmUgdGhhdCB0aGUgbG9hZGVyJ3MgZnJhbWUgaXMgdGhlIG1haW4gZnJhbWUuIAor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjIxOAor CisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SW5zcGVjdG9yQ29udHJvbGxlcjo6ZGlkTG9hZFJlc291cmNlRnJvbU1lbW9yeUNh Y2hlKToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNvbnRyb2xsZXI6OmlkZW50aWZpZXJG b3JJbml0aWFsUmVxdWVzdCk6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDb250cm9sbGVy Ojppc01haW5SZXNvdXJjZUxvYWRlcik6CisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckNv bnRyb2xsZXIuaDoKKwogMjAwOS0wNi0wOSAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFu bkBub2tpYS5jb20+CiAKICAgICAgICAgRml4IHRoZSBRdCBidWlsZCwgdGhlIHRpbWUgZnVuY3Rp b25zIG1vdmVkIGludG8gdGhlIFdURiBuYW1lc3BhY2UuCkluZGV4OiBXZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAkocmV2aXNpb24gNDQ1MzMpCisrKyBXZWJDb3JlL2lu c3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODE0LDcg KzgxNCw3IEBAIHZvaWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6ZGlkTG9hZFJlc291cmMKICAgICAg ICAgcmV0dXJuOwogCiAgICAgQVNTRVJUKG1faW5zcGVjdGVkUGFnZSk7Ci0gICAgYm9vbCBpc01h aW5SZXNvdXJjZSA9IGxvYWRlci0+ZnJhbWUoKSA9PSBtX2luc3BlY3RlZFBhZ2UtPm1haW5GcmFt ZSgpICYmIGNhY2hlZFJlc291cmNlLT51cmwoKSA9PSBsb2FkZXItPnJlcXVlc3RVUkwoKTsKKyAg ICBib29sIGlzTWFpblJlc291cmNlID0gaXNNYWluUmVzb3VyY2VMb2FkZXIobG9hZGVyLCBLVVJM KGNhY2hlZFJlc291cmNlLT51cmwoKSkpOwogICAgIGVuc3VyZVJlc291cmNlVHJhY2tpbmdTZXR0 aW5nc0xvYWRlZCgpOwogICAgIGlmICghaXNNYWluUmVzb3VyY2UgJiYgIW1fcmVzb3VyY2VUcmFj a2luZ0VuYWJsZWQpCiAgICAgICAgIHJldHVybjsKQEAgLTgzOCw3ICs4MzgsNyBAQCB2b2lkIElu c3BlY3RvckNvbnRyb2xsZXI6OmlkZW50aWZpZXJGb3JJCiAgICAgICAgIHJldHVybjsKICAgICBB U1NFUlQobV9pbnNwZWN0ZWRQYWdlKTsKIAotICAgIGJvb2wgaXNNYWluUmVzb3VyY2UgPSBtX2lu c3BlY3RlZFBhZ2UtPm1haW5GcmFtZSgpICYmIHJlcXVlc3QudXJsKCkgPT0gbG9hZGVyLT5yZXF1 ZXN0VVJMKCk7CisgICAgYm9vbCBpc01haW5SZXNvdXJjZSA9IGlzTWFpblJlc291cmNlTG9hZGVy KGxvYWRlciwgcmVxdWVzdC51cmwoKSk7CiAgICAgZW5zdXJlUmVzb3VyY2VUcmFja2luZ1NldHRp bmdzTG9hZGVkKCk7CiAgICAgaWYgKCFpc01haW5SZXNvdXJjZSAmJiAhbV9yZXNvdXJjZVRyYWNr aW5nRW5hYmxlZCkKICAgICAgICAgcmV0dXJuOwpAQCAtODU4LDYgKzg1OCwxMCBAQCB2b2lkIElu c3BlY3RvckNvbnRyb2xsZXI6OmlkZW50aWZpZXJGb3JJCiAgICAgICAgIHJlc291cmNlLT5jcmVh dGVTY3JpcHRPYmplY3QobV9mcm9udGVuZC5nZXQoKSk7CiB9CiAKK2Jvb2wgSW5zcGVjdG9yQ29u dHJvbGxlcjo6aXNNYWluUmVzb3VyY2VMb2FkZXIoRG9jdW1lbnRMb2FkZXIqIGxvYWRlciwgY29u c3QgS1VSTCYgcmVxdWVzdFVybCkgeworICAgIHJldHVybiBsb2FkZXItPmZyYW1lKCkgPT0gbV9p bnNwZWN0ZWRQYWdlLT5tYWluRnJhbWUoKSAmJiByZXF1ZXN0VXJsID09IGxvYWRlci0+cmVxdWVz dFVSTCgpOworfQorCiB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6OndpbGxTZW5kUmVxdWVzdChE b2N1bWVudExvYWRlciosIHVuc2lnbmVkIGxvbmcgaWRlbnRpZmllciwgUmVzb3VyY2VSZXF1ZXN0 JiByZXF1ZXN0LCBjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiByZWRpcmVjdFJlc3BvbnNlKQogewog ICAgIGlmICghZW5hYmxlZCgpIHx8ICFtX3Jlc291cmNlVHJhY2tpbmdFbmFibGVkKQpJbmRleDog V2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuaAkocmV2aXNpb24gNDQ1MzMpCisr KyBXZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmgJKHdvcmtpbmcgY29weSkK QEAgLTYwLDYgKzYwLDcgQEAgY2xhc3MgSW5zcGVjdG9yQ2xpZW50OwogY2xhc3MgSW5zcGVjdG9y RnJvbnRlbmQ7CiBjbGFzcyBKYXZhU2NyaXB0Q2FsbEZyYW1lOwogY2xhc3MgU3RvcmFnZUFyZWE7 CitjbGFzcyBLVVJMOwogY2xhc3MgTm9kZTsKIGNsYXNzIFBhZ2U7CiBzdHJ1Y3QgUmVzb3VyY2VS ZXF1ZXN0OwpAQCAtMjk3LDYgKzI5OCw3IEBAIHByaXZhdGU6CiAKICAgICB2b2lkIHNob3dXaW5k b3coKTsKIAorICAgIGJvb2wgaXNNYWluUmVzb3VyY2VMb2FkZXIoRG9jdW1lbnRMb2FkZXIqIGxv YWRlciwgY29uc3QgS1VSTCYgcmVxdWVzdFVybCk7CiAKICAgICBQYWdlKiBtX2luc3BlY3RlZFBh Z2U7CiAgICAgSW5zcGVjdG9yQ2xpZW50KiBtX2NsaWVudDsK