262169 2023-09-27 01:10:08 -0700 [GTK] build breaks with -DUSE_OPENGL_OR_ES=OFF: epoxy/egl.h no such file or directory 2023-09-29 08:03:11 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thomas.devoogdt webkit-unassigned bugs-noreply oldest_to_newest 1980423 0 thomas.devoogdt 2023-09-27 01:10:08 -0700 This new bug report was proposed in https://bugs.webkit.org/show_bug.cgi?id=261637#c4. webkitgtk-2.42.0/Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp:39:10: fatal error: epoxy/egl.h: No such file or directory 39 | #include <epoxy/egl.h> | ^~~~~~~~~~~~~ If USE_OPENGL_OR_ES=OFF, then we can't assume that EGL will be present. So the include + all it's usages should be guarded with e.g. USE(EGL). 1980426 1 thomas.devoogdt 2023-09-27 01:12:10 -0700 Note that the same does apply to AcceleratedSurfaceDMABuf. 1980906 2 thomas.devoogdt 2023-09-28 04:37:00 -0700 It seems that commit https://commits.webkit.org/265188@main introduced the problems. The USE(GBM) checks were dropped but should have been replaced by USE(EGL). 1980945 3 thomas.devoogdt 2023-09-28 06:53:06 -0700 PR: main: https://github.com/WebKit/WebKit/pull/18346 2.42: https://github.com/WebKit/WebKit/pull/18347 1981043 4 ews-feeder 2023-09-28 11:22:40 -0700 Committed 268598@main (c124153d271b): <https://commits.webkit.org/268598@main> Reviewed commits have been landed. Closing PR #18346 and removing active labels. 1981277 5 ews-feeder 2023-09-29 08:03:11 -0700 Committed 266719.76@bugfix/USE_EGL-2.42 (b751733c75f7): <https://commits.webkit.org/266719.76@bugfix/USE_EGL-2.42> Reviewed commits have been landed. Closing PR #18347 and removing active labels.