26215 2009-06-05 03:50:54 -0700 chromium build breakage with webkit 44439 2009-06-05 07:53:56 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 ukai webkit-unassigned oldest_to_newest 124506 0 ukai 2009-06-05 03:50:54 -0700 GlyphPageTreeNodeChromiumWin.cpp c:\b\slave\win\build\src\third_party\WebKit\WebCore\platform\graphics\chromium\GlyphPageTreeNodeChromiumWin.cpp(75) : error C2039: 'm_font' : is not a member of 'WebCore::SimpleFontData' c:\b\slave\win\build\src\third_party\WebKit\WebCore\platform\graphics\SimpleFontData.h(58) : see declaration of 'WebCore::SimpleFontData' c:\b\slave\win\build\src\third_party\WebKit\WebCore\platform\graphics\chromium\GlyphPageTreeNodeChromiumWin.cpp(75) : error C2228: left of '.hfont' must have class/struct/union c:\b\slave\win\build\src\third_party\WebKit\WebCore\platform\graphics\chromium\GlyphPageTreeNodeChromiumWin.cpp(83) : error C2039: 'm_font' : is not a member of 'WebCore::SimpleFontData' c:\b\slave\win\build\src\third_party\WebKit\WebCore\platform\graphics\SimpleFontData.h(58) : see declaration of 'WebCore::SimpleFontData' c:\b\slave\win\build\src\third_party\WebKit\WebCore\platform\graphics\chromium\GlyphPageTreeNodeChromiumWin.cpp(83) : error C2228: left of '.hfont' must have class/struct/union c:\b\slave\win\build\src\third_party\WebKit\WebCore\platform\graphics\chromium\GlyphPageTreeNodeChromiumWin.cpp(194) : error C2039: 'm_font' : is not a member of 'WebCore::SimpleFontData' c:\b\slave\win\build\src\third_party\WebKit\WebCore\platform\graphics\SimpleFontData.h(58) : see declaration of 'WebCore::SimpleFontData' c:\b\slave\win\build\src\third_party\WebKit\WebCore\platform\graphics\chromium\GlyphPageTreeNodeChromiumWin.cpp(194) : error C2228: left of '.hfont' must have class/struct/union c:\b\slave\win\build\src\third_party\WebKit\WebCore\platform\graphics\chromium\GlyphPageTreeNodeChromiumWin.cpp(195) : error C2039: 'm_font' : is not a member of 'WebCore::SimpleFontData' c:\b\slave\win\build\src\third_party\WebKit\WebCore\platform\graphics\SimpleFontData.h(58) : see declaration of 'WebCore::SimpleFontData' c:\b\slave\win\build\src\third_party\WebKit\WebCore\platform\graphics\chromium\GlyphPageTreeNodeChromiumWin.cpp(195) : error C2228: left of '.scriptCache' must have class/struct/union c:\b\slave\win\build\src\third_party\WebKit\WebCore\platform\graphics\chromium\GlyphPageTreeNodeChromiumWin.cpp(196) : error C2039: 'm_font' : is not a member of 'WebCore::SimpleFontData' c:\b\slave\win\build\src\third_party\WebKit\WebCore\platform\graphics\SimpleFontData.h(58) : see declaration of 'WebCore::SimpleFontData' c:\b\slave\win\build\src\third_party\WebKit\WebCore\platform\graphics\chromium\GlyphPageTreeNodeChromiumWin.cpp(196) : error C2228: left of '.scriptFontProperties' must have class/struct/union 124508 1 31001 ukai 2009-06-05 04:52:20 -0700 Created attachment 31001 Fix the chromium build WebCore/ChangeLog | 11 +++++++++++ .../chromium/GlyphPageTreeNodeChromiumWin.cpp | 10 +++++----- 2 files changed, 16 insertions(+), 5 deletions(-) 124517 2 31001 dglazkov 2009-06-05 07:49:55 -0700 Comment on attachment 31001 Fix the chromium build Will land. 124519 3 dglazkov 2009-06-05 07:53:56 -0700 Landed as http://trac.webkit.org/changeset/44471. 31001 2009-06-05 04:52:20 -0700 2009-06-05 07:49:55 -0700 Fix the chromium build Fix-the-chromium-build.patch text/plain 2367 ukai ZTkxNGU1YmFiYTM2MGJlN2M3YzEyZjY5MGFjNjA1NmE4OGJjYTc5NgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5NTRiNDk3Li44MWQ4ODFl IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE0IEBACisyMDA5LTA2LTA1ICBGdW1pdG9zaGkgVWthaSAgPHVrYWlAZ29vZ2xl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjYyMTUKKyAgICAgICAgVHJ5 IHRvIGZpeCB0aGUgQ2hyb21pdW0gYnVpbGQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9HbHlwaFBhZ2VUcmVlTm9kZUNocm9taXVtV2luLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OmZpbGxCTVBHbHlwaHMpOgorICAgICAgICAoV2ViQ29yZTo6ZmlsbE5vbkJNUEdseXBo cyk6CisKIDIwMDktMDYtMDUgIFhhbiBMb3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgogCiAgICAg ICAgIE1vcmUgYnVpbGQgZml4ZXMuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL0dseXBoUGFnZVRyZWVOb2RlQ2hyb21pdW1XaW4uY3BwIGIvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9HbHlwaFBhZ2VUcmVlTm9kZUNocm9taXVtV2luLmNw cAppbmRleCAzMWM1MjU2Li4yY2IxY2M1IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL0dseXBoUGFnZVRyZWVOb2RlQ2hyb21pdW1XaW4uY3BwCisrKyBiL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vR2x5cGhQYWdlVHJlZU5vZGVDaHJvbWl1 bVdpbi5jcHAKQEAgLTcyLDcgKzcyLDcgQEAgc3RhdGljIGJvb2wgZmlsbEJNUEdseXBocyh1bnNp Z25lZCBvZmZzZXQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgIGJvb2wgcmVjdXJzZSkKIHsK ICAgICBIREMgZGMgPSBHZXREQygoSFdORCkwKTsKLSAgICBIR0RJT0JKIG9sZEZvbnQgPSBTZWxl Y3RPYmplY3QoZGMsIGZvbnREYXRhLT5tX2ZvbnQuaGZvbnQoKSk7CisgICAgSEdESU9CSiBvbGRG b250ID0gU2VsZWN0T2JqZWN0KGRjLCBmb250RGF0YS0+cGxhdGZvcm1EYXRhKCkuaGZvbnQoKSk7 CiAKICAgICBURVhUTUVUUklDIHRtID0gezB9OwogICAgIGlmICghR2V0VGV4dE1ldHJpY3MoZGMs ICZ0bSkpIHsKQEAgLTgwLDcgKzgwLDcgQEAgc3RhdGljIGJvb2wgZmlsbEJNUEdseXBocyh1bnNp Z25lZCBvZmZzZXQsCiAgICAgICAgIFJlbGVhc2VEQygwLCBkYyk7CiAKICAgICAgICAgaWYgKHJl Y3Vyc2UpIHsKLSAgICAgICAgICAgIGlmIChDaHJvbWl1bUJyaWRnZTo6ZW5zdXJlRm9udExvYWRl ZChmb250RGF0YS0+bV9mb250Lmhmb250KCkpKQorICAgICAgICAgICAgaWYgKENocm9taXVtQnJp ZGdlOjplbnN1cmVGb250TG9hZGVkKGZvbnREYXRhLT5wbGF0Zm9ybURhdGEoKS5oZm9udCgpKSkK ICAgICAgICAgICAgICAgICByZXR1cm4gZmlsbEJNUEdseXBocyhvZmZzZXQsIGxlbmd0aCwgYnVm ZmVyLCBwYWdlLCBmb250RGF0YSwgZmFsc2UpOwogICAgICAgICAgICAgZWxzZSB7CiAgICAgICAg ICAgICAgICAgZmlsbEVtcHR5R2x5cGhzKHBhZ2UpOwpAQCAtMTkxLDkgKzE5MSw5IEBAIHN0YXRp YyBib29sIGZpbGxOb25CTVBHbHlwaHModW5zaWduZWQgb2Zmc2V0LAogICAgIGJvb2wgaGF2ZUds eXBocyA9IGZhbHNlOwogCiAgICAgVW5pc2NyaWJlSGVscGVyVGV4dFJ1biBzdGF0ZShidWZmZXIs IGxlbmd0aCAqIDIsIGZhbHNlLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZm9u dERhdGEtPm1fZm9udC5oZm9udCgpLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Zm9udERhdGEtPm1fZm9udC5zY3JpcHRDYWNoZSgpLAotICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgZm9udERhdGEtPm1fZm9udC5zY3JpcHRGb250UHJvcGVydGllcygpKTsKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZvbnREYXRhLT5wbGF0Zm9ybURhdGEoKS5oZm9u dCgpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZm9udERhdGEtPnBsYXRmb3Jt RGF0YSgpLnNjcmlwdENhY2hlKCksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBm b250RGF0YS0+cGxhdGZvcm1EYXRhKCkuc2NyaXB0Rm9udFByb3BlcnRpZXMoKSk7CiAgICAgc3Rh dGUuc2V0SW5oaWJpdExpZ2F0ZSh0cnVlKTsKICAgICBzdGF0ZS5zZXREaXNhYmxlRm9udEZhbGxi YWNrKHRydWUpOwogICAgIHN0YXRlLmluaXQoKTsK