<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>26200</bug_id>
          
          <creation_ts>2009-06-04 17:16:08 -0700</creation_ts>
          <short_desc>[Chromium] Auto Spell Correct in Chromium makes cursor jump arbitrarily in text boxes already having text</short_desc>
          <delta_ts>2009-06-24 15:05:36 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>HTML Editing</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Siddhartha Chattopadhyay">sidchat</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>124415</commentid>
    <comment_count>0</comment_count>
    <who name="Siddhartha Chattopadhyay">sidchat</who>
    <bug_when>2009-06-04 17:16:08 -0700</bug_when>
    <thetext>In order to repro this in Chromium, click on a reply email in Gmail and type in a mispelled word. The curson jumps to an arbitrary position.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>124418</commentid>
    <comment_count>1</comment_count>
      <attachid>30976</attachid>
    <who name="Siddhartha Chattopadhyay">sidchat</who>
    <bug_when>2009-06-04 17:21:58 -0700</bug_when>
    <thetext>Created attachment 30976
Patch to fix cursor behavior</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>124444</commentid>
    <comment_count>2</comment_count>
      <attachid>30976</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-06-04 20:16:13 -0700</bug_when>
    <thetext>Comment on attachment 30976
Patch to fix cursor behavior

This needs a manual test.
Your ChangeLog has tabs in it (which makes it unlandable).
Your ChangeLog shoudl have a better description of what is actually being fixed here :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>124543</commentid>
    <comment_count>3</comment_count>
      <attachid>31003</attachid>
    <who name="Siddhartha Chattopadhyay">sidchat</who>
    <bug_when>2009-06-05 10:41:20 -0700</bug_when>
    <thetext>Created attachment 31003
Patch 2 to fix caret position after auto correction of word</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>124548</commentid>
    <comment_count>4</comment_count>
      <attachid>31004</attachid>
    <who name="Siddhartha Chattopadhyay">sidchat</who>
    <bug_when>2009-06-05 10:47:30 -0700</bug_when>
    <thetext>Created attachment 31004
Patch 2 to fix caret position after auto correct</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>125492</commentid>
    <comment_count>5</comment_count>
      <attachid>31004</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-06-12 11:32:24 -0700</bug_when>
    <thetext>Comment on attachment 31004
Patch 2 to fix caret position after auto correct

This only needs one ChangeLog.  It also needs a manual test still.  WebCore/manual-tests.  Also, patches won&apos;t get reviewed until they&apos;re marked r=?  see http://webkit.org/coding/contributing.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>125574</commentid>
    <comment_count>6</comment_count>
      <attachid>31221</attachid>
    <who name="Siddhartha Chattopadhyay">sidchat</who>
    <bug_when>2009-06-12 16:41:07 -0700</bug_when>
    <thetext>Created attachment 31221
Also add a manual test</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>125758</commentid>
    <comment_count>7</comment_count>
      <attachid>31221</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-06-14 02:27:49 -0700</bug_when>
    <thetext>Comment on attachment 31221
Also add a manual test

Looks fine.  Seems we might need to start adding a platform/ directory to the manual-tests :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>125987</commentid>
    <comment_count>8</comment_count>
    <who name="Siddhartha Chattopadhyay">sidchat</who>
    <bug_when>2009-06-15 10:58:49 -0700</bug_when>
    <thetext>Great - if it is alright with you, could you please submit the patch for me? I do not have commit access. Thanks.

-Sid

(In reply to comment #7)
&gt; (From update of attachment 31221 [review])
&gt; Looks fine.  Seems we might need to start adding a platform/ directory to the
&gt; manual-tests :)
&gt; 

</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>126780</commentid>
    <comment_count>9</comment_count>
      <attachid>31221</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-06-18 14:47:29 -0700</bug_when>
    <thetext>Comment on attachment 31221
Also add a manual test

LGTM.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>127859</commentid>
    <comment_count>10</comment_count>
      <attachid>31221</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-06-24 01:06:07 -0700</bug_when>
    <thetext>Comment on attachment 31221
Also add a manual test

Tabs in the ChangeLog.  Will have to land this manually.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>127865</commentid>
    <comment_count>11</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-06-24 01:12:28 -0700</bug_when>
    <thetext>Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/editing/Editor.cpp
	A	WebCore/manual-tests/textarea-caret-position-after-auto-spell-correct.html
Committed r45075
http://trac.webkit.org/changeset/45075</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>128010</commentid>
    <comment_count>12</comment_count>
    <who name="Siddhartha Chattopadhyay">sidchat</who>
    <bug_when>2009-06-24 15:05:36 -0700</bug_when>
    <thetext>Thanx !

(In reply to comment #11)
&gt; Committing to http://svn.webkit.org/repository/webkit/trunk ...
&gt;         M       WebCore/ChangeLog
&gt;         M       WebCore/editing/Editor.cpp
&gt;         A      
&gt; WebCore/manual-tests/textarea-caret-position-after-auto-spell-correct.html
&gt; Committed r45075
&gt; http://trac.webkit.org/changeset/45075
&gt; </thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>30976</attachid>
            <date>2009-06-04 17:21:58 -0700</date>
            <delta_ts>2009-06-05 10:41:20 -0700</delta_ts>
            <desc>Patch to fix cursor behavior</desc>
            <filename>patch1.txt</filename>
            <type>text/plain</type>
            <size>1255</size>
            <attacher name="Siddhartha Chattopadhyay">sidchat</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA0NDQzOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTEgQEAKKzIwMDktMDYtMDQgIFNpZGRoYXJ0aGEgQ2hhdHRvcGFkaHlheSAgPHNp
ZGNoYXRAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworCQkgRml4IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjYy
MDAgd2hpY2ggSSBpbnRyb2R1Y2VkIGVhcmxpZXIuCisgICAgICAgICogZWRpdGluZy9FZGl0b3Iu
Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yOjptYXJrTWlzc3BlbGxpbmdzQWZ0ZXJUeXBp
bmdUb1Bvc2l0aW9uKToKKwogMjAwOS0wNi0wNCAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUu
Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBXZWJDb3JlL2Vk
aXRpbmcvRWRpdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNw
cAkocmV2aXNpb24gNDQ0MzgpCisrKyBXZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcAkod29ya2lu
ZyBjb3B5KQpAQCAtMjIwNCw3ICsyMjA0LDcgQEAgdm9pZCBFZGl0b3I6Om1hcmtNaXNzcGVsbGlu
Z3NBZnRlclR5cGluZwogCiAgICAgICAgIGlmICghZnJhbWUoKS0+ZWRpdG9yKCktPnNob3VsZElu
c2VydFRleHQoYXV0b2NvcnJlY3RlZFN0cmluZywgbWlzc3BlbGxpbmdSYW5nZS5nZXQoKSwgRWRp
dG9ySW5zZXJ0QWN0aW9uVHlwZWQpKQogICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICBmcmFt
ZSgpLT5lZGl0b3IoKS0+cmVwbGFjZVNlbGVjdGlvbldpdGhUZXh0KGF1dG9jb3JyZWN0ZWRTdHJp
bmcsIGZhbHNlLCB0cnVlKTsKKyAgICAgICAgZnJhbWUoKS0+ZWRpdG9yKCktPnJlcGxhY2VTZWxl
Y3Rpb25XaXRoVGV4dChhdXRvY29ycmVjdGVkU3RyaW5nLCBmYWxzZSwgZmFsc2UpOwogCiAgICAg
ICAgIC8vIFJlc2V0IHRoZSBjaGFyZXQgb25lIGNoYXJhY3RlciBmdXJ0aGVyLgogICAgICAgICBm
cmFtZSgpLT5zZWxlY3Rpb24oKS0+bW92ZVRvKGZyYW1lKCktPnNlbGVjdGlvbigpLT5lbmQoKSk7
Cg==
</data>
<flag name="review"
          id="15748"
          type_id="1"
          status="-"
          setter="eric"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>31003</attachid>
            <date>2009-06-05 10:41:20 -0700</date>
            <delta_ts>2009-06-05 10:47:30 -0700</delta_ts>
            <desc>Patch 2 to fix caret position after auto correction of word</desc>
            <filename>patch2.txt</filename>
            <type>text/plain</type>
            <size>2058</size>
            <attacher name="Siddhartha Chattopadhyay">sidchat</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ0NDcy
KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTAgQEAKKzIwMDktMDYt
MDUgIHNpZGNoYXQgIDxzZXQgRU1BSUxfQUREUkVTUyBlbnZpcm9ubWVudCB2YXJpYWJsZT4KKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYkNvcmUv
ZWRpdGluZy9FZGl0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yOjptYXJrTWlzc3Bl
bGxpbmdzQWZ0ZXJUeXBpbmdUb1Bvc2l0aW9uKToKKwogMjAwOS0wNS0yOSAgR3VzdGF2byBOb3Jv
bmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBKYW4gQWxv
bnpvLgpJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFu
Z2VMb2cJKHJldmlzaW9uIDQ0NDcyKQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w
eSkKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wNi0wNSAgU2lkZGhhcnRoYSBDaGF0dG9wYWRoeWF5
ICA8c2lkY2hhdEBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q
UyEpLgorCisgICAgICAgIEZpeCBmb3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTI2MjAwIHdoaWNoIEkgaW50cm9kdWNlZCBlYXJsaWVyLiBJIGhhZAorCQl0aGUgc21h
cnRSZXBsYWNlIHNldCBUUlVFIGluaXRpYWxseSwgd2hpY2ggd2FzIHdyb25nIHNpbmNlIHRoZSBw
dXJwb3NlIG9mIHRoaXMgY2FsbCBpcworCQl0byBqdXN0IHJlcGxhY2UgdGhlIHNlbGVjdGlvbiwg
YW5kIHBsYWNlIHRoZSBjYXJldCBhdCB0aGUgZW5kIG9mIHRoZSBzZWxlY3Rpb24gaXQgcmVwbGFj
ZWQuCisJCUFmdGVyIHJlcGxhY2luZywgdGhlIGNoYXJldCBpcyBtYWRlIHRvIG1vdmUgZm9yd2Fy
ZCBvbmUgY2hhcmFjdGVyIGdyYW51bGFyaXR5LCB0cmlnZ2VyZWQKKwkJYnkgdGhlIG5leHQgdHdv
IGxpbmVzIG9mIGNvZGUuCisKKyAgICAgICAgKiBlZGl0aW5nL0VkaXRvci5jcHA6CisgICAgICAg
IChXZWJDb3JlOjpFZGl0b3I6Om1hcmtNaXNzcGVsbGluZ3NBZnRlclR5cGluZ1RvUG9zaXRpb24p
OgorCiAyMDA5LTA2LTA1ICBUb3IgQXJuZSBWZXN0YsO4ICA8dG9yLmFybmUudmVzdGJvQG5va2lh
LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KSW5kZXg6IFdlYkNv
cmUvZWRpdGluZy9FZGl0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZWRpdGluZy9FZGl0
b3IuY3BwCShyZXZpc2lvbiA0NDQzOCkKKysrIFdlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCSh3
b3JraW5nIGNvcHkpCkBAIC0yMjA0LDcgKzIyMDQsNyBAQCB2b2lkIEVkaXRvcjo6bWFya01pc3Nw
ZWxsaW5nc0FmdGVyVHlwaW5nCiAKICAgICAgICAgaWYgKCFmcmFtZSgpLT5lZGl0b3IoKS0+c2hv
dWxkSW5zZXJ0VGV4dChhdXRvY29ycmVjdGVkU3RyaW5nLCBtaXNzcGVsbGluZ1JhbmdlLmdldCgp
LCBFZGl0b3JJbnNlcnRBY3Rpb25UeXBlZCkpCiAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAg
IGZyYW1lKCktPmVkaXRvcigpLT5yZXBsYWNlU2VsZWN0aW9uV2l0aFRleHQoYXV0b2NvcnJlY3Rl
ZFN0cmluZywgZmFsc2UsIHRydWUpOworICAgICAgICBmcmFtZSgpLT5lZGl0b3IoKS0+cmVwbGFj
ZVNlbGVjdGlvbldpdGhUZXh0KGF1dG9jb3JyZWN0ZWRTdHJpbmcsIGZhbHNlLCBmYWxzZSk7CiAK
ICAgICAgICAgLy8gUmVzZXQgdGhlIGNoYXJldCBvbmUgY2hhcmFjdGVyIGZ1cnRoZXIuCiAgICAg
ICAgIGZyYW1lKCktPnNlbGVjdGlvbigpLT5tb3ZlVG8oZnJhbWUoKS0+c2VsZWN0aW9uKCktPmVu
ZCgpKTsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>31004</attachid>
            <date>2009-06-05 10:47:30 -0700</date>
            <delta_ts>2009-06-12 16:41:07 -0700</delta_ts>
            <desc>Patch 2 to fix caret position after auto correct</desc>
            <filename>patch2.txt</filename>
            <type>text/plain</type>
            <size>2517</size>
            <attacher name="Siddhartha Chattopadhyay">sidchat</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ0NDcy
KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDYt
MDUgIFNpZGRoYXJ0aGEgQ2hhdHRvcGFkaHlheSAgPHNpZGNoYXRAZ29vZ2xlLmNvbT4KKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwkJCisgICAgICAgIEZpeCBmb3IgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2MjAwIHdoaWNoIEkgaW50cm9k
dWNlZCBlYXJsaWVyLiBJIGhhZAorICAgICAgICB0aGUgc21hcnRSZXBsYWNlIHNldCBUUlVFIGlu
aXRpYWxseSwgd2hpY2ggd2FzIHdyb25nIHNpbmNlIHRoZSBwdXJwb3NlIG9mIHRoaXMgY2FsbCBp
cworICAgICAgICB0byBqdXN0IHJlcGxhY2UgdGhlIHNlbGVjdGlvbiwgYW5kIHBsYWNlIHRoZSBj
YXJldCBhdCB0aGUgZW5kIG9mIHRoZSBzZWxlY3Rpb24gaXQgcmVwbGFjZWQuCisgICAgICAgIEFm
dGVyIHJlcGxhY2luZywgdGhlIGNoYXJldCBpcyBtYWRlIHRvIG1vdmUgZm9yd2FyZCBvbmUgY2hh
cmFjdGVyIGdyYW51bGFyaXR5LCB0cmlnZ2VyZWQKKyAgICAgICAgYnkgdGhlIG5leHQgdHdvIGxp
bmVzIG9mIGNvZGUuCisJCQorICAgICAgICAqIFdlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwOgor
ICAgICAgICAoV2ViQ29yZTo6RWRpdG9yOjptYXJrTWlzc3BlbGxpbmdzQWZ0ZXJUeXBpbmdUb1Bv
c2l0aW9uKToKKwogMjAwOS0wNS0yOSAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdub21l
Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBKYW4gQWxvbnpvLgpJbmRleDogV2ViQ29yZS9D
aGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ0NDcy
KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAor
MjAwOS0wNi0wNSAgU2lkZGhhcnRoYSBDaGF0dG9wYWRoeWF5ICA8c2lkY2hhdEBnb29nbGUuY29t
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBm
b3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2MjAwIHdoaWNoIEkg
aW50cm9kdWNlZCBlYXJsaWVyLiBJIGhhZAorICAgICAgICB0aGUgc21hcnRSZXBsYWNlIHNldCBU
UlVFIGluaXRpYWxseSwgd2hpY2ggd2FzIHdyb25nIHNpbmNlIHRoZSBwdXJwb3NlIG9mIHRoaXMg
Y2FsbCBpcworICAgICAgICB0byBqdXN0IHJlcGxhY2UgdGhlIHNlbGVjdGlvbiwgYW5kIHBsYWNl
IHRoZSBjYXJldCBhdCB0aGUgZW5kIG9mIHRoZSBzZWxlY3Rpb24gaXQgcmVwbGFjZWQuCisgICAg
ICAgIEFmdGVyIHJlcGxhY2luZywgdGhlIGNoYXJldCBpcyBtYWRlIHRvIG1vdmUgZm9yd2FyZCBv
bmUgY2hhcmFjdGVyIGdyYW51bGFyaXR5LCB0cmlnZ2VyZWQKKyAgICAgICAgYnkgdGhlIG5leHQg
dHdvIGxpbmVzIG9mIGNvZGUuCisKKyAgICAgICAgKiBlZGl0aW5nL0VkaXRvci5jcHA6CisgICAg
ICAgIChXZWJDb3JlOjpFZGl0b3I6Om1hcmtNaXNzcGVsbGluZ3NBZnRlclR5cGluZ1RvUG9zaXRp
b24pOgorCiAyMDA5LTA2LTA1ICBUb3IgQXJuZSBWZXN0YsO4ICA8dG9yLmFybmUudmVzdGJvQG5v
a2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KSW5kZXg6IFdl
YkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZWRpdGluZy9F
ZGl0b3IuY3BwCShyZXZpc2lvbiA0NDQzOCkKKysrIFdlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3Bw
CSh3b3JraW5nIGNvcHkpCkBAIC0yMjA0LDcgKzIyMDQsNyBAQCB2b2lkIEVkaXRvcjo6bWFya01p
c3NwZWxsaW5nc0FmdGVyVHlwaW5nCiAKICAgICAgICAgaWYgKCFmcmFtZSgpLT5lZGl0b3IoKS0+
c2hvdWxkSW5zZXJ0VGV4dChhdXRvY29ycmVjdGVkU3RyaW5nLCBtaXNzcGVsbGluZ1JhbmdlLmdl
dCgpLCBFZGl0b3JJbnNlcnRBY3Rpb25UeXBlZCkpCiAgICAgICAgICAgICByZXR1cm47Ci0gICAg
ICAgIGZyYW1lKCktPmVkaXRvcigpLT5yZXBsYWNlU2VsZWN0aW9uV2l0aFRleHQoYXV0b2NvcnJl
Y3RlZFN0cmluZywgZmFsc2UsIHRydWUpOworICAgICAgICBmcmFtZSgpLT5lZGl0b3IoKS0+cmVw
bGFjZVNlbGVjdGlvbldpdGhUZXh0KGF1dG9jb3JyZWN0ZWRTdHJpbmcsIGZhbHNlLCBmYWxzZSk7
CiAKICAgICAgICAgLy8gUmVzZXQgdGhlIGNoYXJldCBvbmUgY2hhcmFjdGVyIGZ1cnRoZXIuCiAg
ICAgICAgIGZyYW1lKCktPnNlbGVjdGlvbigpLT5tb3ZlVG8oZnJhbWUoKS0+c2VsZWN0aW9uKCkt
PmVuZCgpKTsK
</data>
<flag name="review"
          id="15911"
          type_id="1"
          status="-"
          setter="eric"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>31221</attachid>
            <date>2009-06-12 16:41:07 -0700</date>
            <delta_ts>2009-06-18 14:47:29 -0700</delta_ts>
            <desc>Also add a manual test</desc>
            <filename>patch2.txt</filename>
            <type>text/plain</type>
            <size>2882</size>
            <attacher name="Siddhartha Chattopadhyay">sidchat</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA0NDYzNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTUgQEAKKzIwMDktMDYtMTIgIFNpZGRoYXJ0aGEgQ2hhdHRvcGFkaHlheSAgPHNp
ZGNoYXRAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KKwkJ
CisgICAgICAgIEZpeCBmb3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTI2MjAwIHdoaWNoIEkgaW50cm9kdWNlZCBlYXJsaWVyLiBJIGhhZAorICAgICAgICB0aGUgc21h
cnRSZXBsYWNlIHNldCBUUlVFIGluaXRpYWxseSwgd2hpY2ggd2FzIHdyb25nIHNpbmNlIHRoZSBw
dXJwb3NlIG9mIHRoaXMgY2FsbCBpcworICAgICAgICB0byBqdXN0IHJlcGxhY2UgdGhlIHNlbGVj
dGlvbiwgYW5kIHBsYWNlIHRoZSBjYXJldCBhdCB0aGUgZW5kIG9mIHRoZSBzZWxlY3Rpb24gaXQg
cmVwbGFjZWQuCisKKyAgICAgICAgKiBlZGl0aW5nL0VkaXRvci5jcHA6CisgICAgICAgIChXZWJD
b3JlOjpFZGl0b3I6Om1hcmtNaXNzcGVsbGluZ3NBZnRlclR5cGluZ1RvUG9zaXRpb24pOgorICAg
ICAgICAqIG1hbnVhbC10ZXN0cy90ZXh0YXJlYS1jYXJldC1wb3NpdGlvbi1hZnRlci1hdXRvLXNw
ZWxsLWNvcnJlY3QuaHRtbDogQWRkZWQuCisKIDIwMDktMDYtMTIgIGpvcmxvdyAgPGpvcmxvd0Bj
aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCkluZGV4OiBX
ZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2VkaXRpbmcv
RWRpdG9yLmNwcAkocmV2aXNpb24gNDQ2MzYpCisrKyBXZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNw
cAkod29ya2luZyBjb3B5KQpAQCAtMjIwNCw3ICsyMjA0LDcgQEAgdm9pZCBFZGl0b3I6Om1hcmtN
aXNzcGVsbGluZ3NBZnRlclR5cGluZwogCiAgICAgICAgIGlmICghZnJhbWUoKS0+ZWRpdG9yKCkt
PnNob3VsZEluc2VydFRleHQoYXV0b2NvcnJlY3RlZFN0cmluZywgbWlzc3BlbGxpbmdSYW5nZS5n
ZXQoKSwgRWRpdG9ySW5zZXJ0QWN0aW9uVHlwZWQpKQogICAgICAgICAgICAgcmV0dXJuOwotICAg
ICAgICBmcmFtZSgpLT5lZGl0b3IoKS0+cmVwbGFjZVNlbGVjdGlvbldpdGhUZXh0KGF1dG9jb3Jy
ZWN0ZWRTdHJpbmcsIGZhbHNlLCB0cnVlKTsKKyAgICAgICAgZnJhbWUoKS0+ZWRpdG9yKCktPnJl
cGxhY2VTZWxlY3Rpb25XaXRoVGV4dChhdXRvY29ycmVjdGVkU3RyaW5nLCBmYWxzZSwgZmFsc2Up
OwogCiAgICAgICAgIC8vIFJlc2V0IHRoZSBjaGFyZXQgb25lIGNoYXJhY3RlciBmdXJ0aGVyLgog
ICAgICAgICBmcmFtZSgpLT5zZWxlY3Rpb24oKS0+bW92ZVRvKGZyYW1lKCktPnNlbGVjdGlvbigp
LT5lbmQoKSk7CkluZGV4OiBXZWJDb3JlL21hbnVhbC10ZXN0cy90ZXh0YXJlYS1jYXJldC1wb3Np
dGlvbi1hZnRlci1hdXRvLXNwZWxsLWNvcnJlY3QuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl
L21hbnVhbC10ZXN0cy90ZXh0YXJlYS1jYXJldC1wb3NpdGlvbi1hZnRlci1hdXRvLXNwZWxsLWNv
cnJlY3QuaHRtbAkocmV2aXNpb24gMCkKKysrIFdlYkNvcmUvbWFudWFsLXRlc3RzL3RleHRhcmVh
LWNhcmV0LXBvc2l0aW9uLWFmdGVyLWF1dG8tc3BlbGwtY29ycmVjdC5odG1sCShyZXZpc2lvbiAw
KQpAQCAtMCwwICsxLDE0IEBACis8aHRtbD4gDQorPGJvZHk+DQorPHA+VGVzdHMgYnVnIDxhIGhy
ZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjIwMCI+MjYyMDA8
L2E+IHdoZXJlIHRoZSBjYXJldCBwb3NpdGlvbiBqdW1wcyBvZmYgdG8gYW4gaW5jb3JyZWN0IHBv
c2l0aW9uIGFmdGVyIGF1dG8tY29ycmVjdGluZyBhIG1pc3NwZWxsZWQgd29yZC48L3A+DQorPHA+
T3BlbiB0aGlzIGZpbGUgaW4gR29vZ2xlIENocm9taXVtICh2ZXJzaW9uIDMuMCArKSwgaW4gV2lu
ZG93cywgYW5kIGVuYWJsZSB0aGUgLS1hdXRvLXNwZWxsLWNvcnJlY3QgZmxhZy4gSW5zZXJ0IHRo
ZSB3b3JkICd0ZWgnIGJldHdlZW4gYW55IHR3byB3b3JkcyBpbiB0aGUgcGFyYWdyYXBoIGJlbG93
LjwvcD4NCis8cD5TVUNDRVNTOiAgQWZ0ZXIgaGl0dGluZyBzcGFjZSwgJ3RlaCcgaXMgYXV0by1j
b3JyZWN0ZWQgdG8gJ3RoZScsIGFuZCB0aGUgY2FyZXQgc3RheXMgb24gaW4gdGhlIHBsYWNlIGl0
IGlzIHN1cHBvc2VkIHRvIGJlIGluIGFmdGVyIHR5cGluZyB0aGUgd29yZCBhbmQgaGl0dGluZyBz
cGFjZS48L3A+DQorPHRleHRhcmVhIHJvd3M9IjYiIGNvbHM9IjM1Ij4NCitUaGlzIGlzIGFuIGVu
Z2xpc2ggc3RhdGVtZW50Lg0KK1RoaXMgaXMgYW4gZW5nbGlzaCBzdGF0ZW1lbnQuDQorVGhpcyBp
cyBhbiBlbmdsaXNoIHN0YXRlbWVudC4NCitUaGlzIGlzIGFuIGVuZ2xpc2ggc3RhdGVtZW50Lg0K
K1RoaXMgaXMgYW4gZW5nbGlzaCBzdGF0ZW1lbnQuDQorPC90ZXh0YXJlYT4NCis8L2JvZHk+DQor
PGh0bWw+DQoKUHJvcGVydHkgY2hhbmdlcyBvbjogV2ViQ29yZS9tYW51YWwtdGVzdHMvdGV4dGFy
ZWEtY2FyZXQtcG9zaXRpb24tYWZ0ZXItYXV0by1zcGVsbC1jb3JyZWN0Lmh0bWwKX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
XwpBZGRlZDogc3ZuOmV4ZWN1dGFibGUKICAgKyAqCgo=
</data>
<flag name="review"
          id="15926"
          type_id="1"
          status="+"
          setter="eric"
    />
          </attachment>
      

    </bug>

</bugzilla>