26194 2009-06-04 12:32:47 -0700 DeprecatedPtrList should be removed 2009-08-06 12:17:13 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Mac OS X 10.5 RESOLVED DUPLICATE 17425 P2 Normal --- 1 eric webkit-unassigned sam oldest_to_newest 124354 0 eric 2009-06-04 12:32:47 -0700 DeprecatedPtrList should be removed The last client is on RenderBlock: DeprecatedPtrList<FloatingObject>* m_floatingObjects; And the only times its used, it would work as well or better as a Vector. See the attached list of uses in the code. Note that we never insert or remove from the middle of the list. A vector will be more space efficient! I'll post a patch to do this tomorrow if no one beats me to it. 124355 1 30953 eric 2009-06-04 12:33:23 -0700 Created attachment 30953 list of places that DeprecatedPtrList is used 124356 2 eric 2009-06-04 12:37:09 -0700 Ok, I lied. There is one removeRef call in: void RenderBlock::removeFloatingObject(RenderBox* o) which does remove from the middle of the list. That's called from: void RenderBlock::markAllDescendantsWithFloatsForLayout(RenderBox* floatToRemove, bool inLayout) which I would expect is expected to be O(N), not O(N^2) as it could be if we moved to a Vector here. Hum... 124359 3 eric 2009-06-04 12:41:19 -0700 The only time floatToRemove is ever non-null is from: void RenderBox::removeFloatingOrPositionedChildFromBlockLists() Which is only called when an object is losing float status in a styleWillChange or the like. I was also wrong above. This will not turn this from O(N) to O(N^2) because we're only going to remove it once. This will cause pages which make things floating-and-then-not-again slower, but I doubt anyone would notice. I do expect the iPhone will notice the memory savings on all pages which include floats! :) So I still think this change is a good one. 137616 4 sam 2009-08-06 12:17:13 -0700 *** This bug has been marked as a duplicate of bug 17425 *** 30953 2009-06-04 12:33:23 -0700 2009-06-04 12:33:23 -0700 list of places that DeprecatedPtrList is used list_of_uses.txt text/plain 6676 eric UmVuZGVyQmxvY2suY3BwOiAgICAgICwgbV9mbG9hdGluZ09iamVjdHMoMCkKUmVuZGVyQmxvY2su Y3BwOiAgICBkZWxldGUgbV9mbG9hdGluZ09iamVjdHM7ClJlbmRlckJsb2NrLmNwcDogICAgICAg IC8vIFdlIHRoaW5rIHRoYXQgd2UgbXVzdCBiZSBpbiBhIGJhZCBzdGF0ZSBpZiBtX2Zsb2F0aW5n T2JqZWN0cyBpcyBuaWwgYXQgdGhpcyBwb2ludCwgc28gClJlbmRlckJsb2NrLmNwcDogICAgICAg IEFTU0VSVChtX2Zsb2F0aW5nT2JqZWN0cyk7ClJlbmRlckJsb2NrLmNwcDogICAgICAgIGlmICgh bV9mbG9hdGluZ09iamVjdHMpClJlbmRlckJsb2NrLmNwcDogICAgICAgIERlcHJlY2F0ZWRQdHJM aXN0SXRlcmF0b3I8RmxvYXRpbmdPYmplY3Q+IGl0KCptX2Zsb2F0aW5nT2JqZWN0cyk7ClJlbmRl ckJsb2NrLmNwcDogICAgaWYgKCFtX2Zsb2F0aW5nT2JqZWN0cykKUmVuZGVyQmxvY2suY3BwOiAg ICBEZXByZWNhdGVkUHRyTGlzdEl0ZXJhdG9yPEZsb2F0aW5nT2JqZWN0PiBpdCgqbV9mbG9hdGlu Z09iamVjdHMpOwpSZW5kZXJCbG9jay5jcHA6ICAgICAgICBpZiAobV9mbG9hdGluZ09iamVjdHMp IHsKUmVuZGVyQmxvY2suY3BwOiAgICAgICAgICAgIGZvciAoRGVwcmVjYXRlZFB0ckxpc3RJdGVy YXRvcjxGbG9hdGluZ09iamVjdD4gaXQoKm1fZmxvYXRpbmdPYmplY3RzKTsgaXQuY3VycmVudCgp OyArK2l0KSB7ClJlbmRlckJsb2NrLmNwcDogICAgaWYgKCFtX2Zsb2F0aW5nT2JqZWN0cykgewpS ZW5kZXJCbG9jay5jcHA6ICAgICAgICBtX2Zsb2F0aW5nT2JqZWN0cyA9IG5ldyBEZXByZWNhdGVk UHRyTGlzdDxGbG9hdGluZ09iamVjdD47ClJlbmRlckJsb2NrLmNwcDogICAgICAgIG1fZmxvYXRp bmdPYmplY3RzLT5zZXRBdXRvRGVsZXRlKHRydWUpOwpSZW5kZXJCbG9jay5jcHA6ICAgICAgICBE ZXByZWNhdGVkUHRyTGlzdEl0ZXJhdG9yPEZsb2F0aW5nT2JqZWN0PiBpdCgqbV9mbG9hdGluZ09i amVjdHMpOwpSZW5kZXJCbG9jay5jcHA6ICAgIG1fZmxvYXRpbmdPYmplY3RzLT5hcHBlbmQobmV3 T2JqKTsKUmVuZGVyQmxvY2suY3BwOiAgICBpZiAobV9mbG9hdGluZ09iamVjdHMpIHsKUmVuZGVy QmxvY2suY3BwOiAgICAgICAgRGVwcmVjYXRlZFB0ckxpc3RJdGVyYXRvcjxGbG9hdGluZ09iamVj dD4gaXQoKm1fZmxvYXRpbmdPYmplY3RzKTsKUmVuZGVyQmxvY2suY3BwOiAgICAgICAgICAgICAg ICBtX2Zsb2F0aW5nT2JqZWN0cy0+cmVtb3ZlUmVmKGl0LmN1cnJlbnQoKSk7ClJlbmRlckJsb2Nr LmNwcDogICAgaWYgKCFtX2Zsb2F0aW5nT2JqZWN0cykKUmVuZGVyQmxvY2suY3BwOiAgICBGbG9h dGluZ09iamVjdCogZiA9IG1fZmxvYXRpbmdPYmplY3RzLT5sYXN0KCk7ClJlbmRlckJsb2NrLmNw cDogICAgRmxvYXRpbmdPYmplY3QqIGxhc3RGbG9hdCA9IG1fZmxvYXRpbmdPYmplY3RzLT5nZXRQ cmV2KCk7ClJlbmRlckJsb2NrLmNwcDogICAgICAgIGYgPSBtX2Zsb2F0aW5nT2JqZWN0cy0+cHJl digpOwpSZW5kZXJCbG9jay5jcHA6ICAgICAgICBsYXN0RmxvYXQgPSBtX2Zsb2F0aW5nT2JqZWN0 cy0+Z2V0UHJldigpOwpSZW5kZXJCbG9jay5jcHA6ICAgICAgICAgICAgZiA9IG1fZmxvYXRpbmdP YmplY3RzLT5uZXh0KCk7ClJlbmRlckJsb2NrLmNwcDogICAgICAgIGYgPSBtX2Zsb2F0aW5nT2Jq ZWN0cy0+bmV4dCgpOwpSZW5kZXJCbG9jay5jcHA6ICAgIGlmIChtX2Zsb2F0aW5nT2JqZWN0cykg ewpSZW5kZXJCbG9jay5jcHA6ICAgICAgICBEZXByZWNhdGVkUHRyTGlzdEl0ZXJhdG9yPEZsb2F0 aW5nT2JqZWN0PiBpdCgqbV9mbG9hdGluZ09iamVjdHMpOwpSZW5kZXJCbG9jay5jcHA6ICAgIGlm IChtX2Zsb2F0aW5nT2JqZWN0cykgewpSZW5kZXJCbG9jay5jcHA6ICAgICAgICBEZXByZWNhdGVk UHRyTGlzdEl0ZXJhdG9yPEZsb2F0aW5nT2JqZWN0PiBpdCgqbV9mbG9hdGluZ09iamVjdHMpOwpS ZW5kZXJCbG9jay5jcHA6ICAgIGlmICghbV9mbG9hdGluZ09iamVjdHMpClJlbmRlckJsb2NrLmNw cDogICAgRGVwcmVjYXRlZFB0ckxpc3RJdGVyYXRvcjxGbG9hdGluZ09iamVjdD4gaXQoKm1fZmxv YXRpbmdPYmplY3RzKTsKUmVuZGVyQmxvY2suY3BwOiAgICBpZiAoIW1fZmxvYXRpbmdPYmplY3Rz KSByZXR1cm4gMDsKUmVuZGVyQmxvY2suY3BwOiAgICBEZXByZWNhdGVkUHRyTGlzdEl0ZXJhdG9y PEZsb2F0aW5nT2JqZWN0PiBpdCgqbV9mbG9hdGluZ09iamVjdHMpOwpSZW5kZXJCbG9jay5jcHA6 ICAgIGlmICghbV9mbG9hdGluZ09iamVjdHMgfHwgaGFzT3ZlcmZsb3dDbGlwKCkpClJlbmRlckJs b2NrLmNwcDogICAgRGVwcmVjYXRlZFB0ckxpc3RJdGVyYXRvcjxGbG9hdGluZ09iamVjdD4gaXQo Km1fZmxvYXRpbmdPYmplY3RzKTsKUmVuZGVyQmxvY2suY3BwOiAgICBpZiAobV9mbG9hdGluZ09i amVjdHMpIHsKUmVuZGVyQmxvY2suY3BwOiAgICAgICAgRGVwcmVjYXRlZFB0ckxpc3RJdGVyYXRv cjxGbG9hdGluZ09iamVjdD4gaXQoKm1fZmxvYXRpbmdPYmplY3RzKTsKUmVuZGVyQmxvY2suY3Bw OiAgICBpZiAobV9mbG9hdGluZ09iamVjdHMpIHsKUmVuZGVyQmxvY2suY3BwOiAgICAgICAgRGVw cmVjYXRlZFB0ckxpc3RJdGVyYXRvcjxGbG9hdGluZ09iamVjdD4gaXQoKm1fZmxvYXRpbmdPYmpl Y3RzKTsKUmVuZGVyQmxvY2suY3BwOiAgICBpZiAobV9mbG9hdGluZ09iamVjdHMpIHsKUmVuZGVy QmxvY2suY3BwOiAgICAgICAgRGVwcmVjYXRlZFB0ckxpc3RJdGVyYXRvcjxGbG9hdGluZ09iamVj dD4gaXQoKm1fZmxvYXRpbmdPYmplY3RzKTsKUmVuZGVyQmxvY2suY3BwOiAgICBpZiAoIW1fZmxv YXRpbmdPYmplY3RzKSByZXR1cm4gMDsKUmVuZGVyQmxvY2suY3BwOiAgICBEZXByZWNhdGVkUHRy TGlzdEl0ZXJhdG9yPEZsb2F0aW5nT2JqZWN0PiBpdCgqbV9mbG9hdGluZ09iamVjdHMpOwpSZW5k ZXJCbG9jay5jcHA6ICAgIGlmICghbV9mbG9hdGluZ09iamVjdHMpIHJldHVybiAwOwpSZW5kZXJC bG9jay5jcHA6ICAgIERlcHJlY2F0ZWRQdHJMaXN0SXRlcmF0b3I8RmxvYXRpbmdPYmplY3Q+IGl0 KCptX2Zsb2F0aW5nT2JqZWN0cyk7ClJlbmRlckJsb2NrLmNwcDogICAgICAgIGlmIChtX2Zsb2F0 aW5nT2JqZWN0cykKUmVuZGVyQmxvY2suY3BwOiAgICAgICAgICAgIG1fZmxvYXRpbmdPYmplY3Rz LT5jbGVhcigpOwpSZW5kZXJCbG9jay5jcHA6ICAgIGlmIChtX2Zsb2F0aW5nT2JqZWN0cykgewpS ZW5kZXJCbG9jay5jcHA6ICAgICAgICAgICAgbV9mbG9hdGluZ09iamVjdHMtPmZpcnN0KCk7ClJl bmRlckJsb2NrLmNwcDogICAgICAgICAgICB3aGlsZSAoRmxvYXRpbmdPYmplY3QqIGYgPSBtX2Zs b2F0aW5nT2JqZWN0cy0+dGFrZSgpKQpSZW5kZXJCbG9jay5jcHA6ICAgICAgICAgICAgbV9mbG9h dGluZ09iamVjdHMtPmNsZWFyKCk7ClJlbmRlckJsb2NrLmNwcDogICAgaWYgKGJsb2NrLT5tX2Zs b2F0aW5nT2JqZWN0cyAmJiBibG9jay0+ZmxvYXRCb3R0b20oKSA+IG9mZnNldCkKUmVuZGVyQmxv Y2suY3BwOiAgICAgICAgaWYgKG1fZmxvYXRpbmdPYmplY3RzKSB7ClJlbmRlckJsb2NrLmNwcDog ICAgICAgICAgICBmb3IgKEZsb2F0aW5nT2JqZWN0KiBmID0gbV9mbG9hdGluZ09iamVjdHMtPmZp cnN0KCk7IGY7IGYgPSBtX2Zsb2F0aW5nT2JqZWN0cy0+bmV4dCgpKSB7ClJlbmRlckJsb2NrLmNw cDogICAgRGVwcmVjYXRlZFB0ckxpc3RJdGVyYXRvcjxGbG9hdGluZ09iamVjdD4gaXQoKmNoaWxk LT5tX2Zsb2F0aW5nT2JqZWN0cyk7ClJlbmRlckJsb2NrLmNwcDogICAgICAgICAgICAgICAgaWYg KCFtX2Zsb2F0aW5nT2JqZWN0cykgewpSZW5kZXJCbG9jay5jcHA6ICAgICAgICAgICAgICAgICAg ICBtX2Zsb2F0aW5nT2JqZWN0cyA9IG5ldyBEZXByZWNhdGVkUHRyTGlzdDxGbG9hdGluZ09iamVj dD47ClJlbmRlckJsb2NrLmNwcDogICAgICAgICAgICAgICAgICAgIG1fZmxvYXRpbmdPYmplY3Rz LT5zZXRBdXRvRGVsZXRlKHRydWUpOwpSZW5kZXJCbG9jay5jcHA6ICAgICAgICAgICAgICAgIG1f ZmxvYXRpbmdPYmplY3RzLT5hcHBlbmQoZmxvYXRpbmdPYmopOwpSZW5kZXJCbG9jay5jcHA6ICAg IGlmICghcHJldi0+bV9mbG9hdGluZ09iamVjdHMpClJlbmRlckJsb2NrLmNwcDogICAgRGVwcmVj YXRlZFB0ckxpc3RJdGVyYXRvcjxGbG9hdGluZ09iamVjdD4gaXQoKnByZXYtPm1fZmxvYXRpbmdP YmplY3RzKTsKUmVuZGVyQmxvY2suY3BwOiAgICAgICAgICAgIGlmIChtX2Zsb2F0aW5nT2JqZWN0 cykgewpSZW5kZXJCbG9jay5jcHA6ICAgICAgICAgICAgICAgIERlcHJlY2F0ZWRQdHJMaXN0SXRl cmF0b3I8RmxvYXRpbmdPYmplY3Q+IGl0KCptX2Zsb2F0aW5nT2JqZWN0cyk7ClJlbmRlckJsb2Nr LmNwcDogICAgICAgICAgICAgICAgaWYgKCFtX2Zsb2F0aW5nT2JqZWN0cykgewpSZW5kZXJCbG9j ay5jcHA6ICAgICAgICAgICAgICAgICAgICBtX2Zsb2F0aW5nT2JqZWN0cyA9IG5ldyBEZXByZWNh dGVkUHRyTGlzdDxGbG9hdGluZ09iamVjdD47ClJlbmRlckJsb2NrLmNwcDogICAgICAgICAgICAg ICAgICAgIG1fZmxvYXRpbmdPYmplY3RzLT5zZXRBdXRvRGVsZXRlKHRydWUpOwpSZW5kZXJCbG9j ay5jcHA6ICAgICAgICAgICAgICAgIG1fZmxvYXRpbmdPYmplY3RzLT5hcHBlbmQoZmxvYXRpbmdP YmopOwpSZW5kZXJCbG9jay5jcHA6ICAgIGlmIChtX2Zsb2F0aW5nT2JqZWN0cykgewpSZW5kZXJC bG9jay5jcHA6ICAgICAgICBEZXByZWNhdGVkUHRyTGlzdEl0ZXJhdG9yPEZsb2F0aW5nT2JqZWN0 PiBpdCgqbV9mbG9hdGluZ09iamVjdHMpOwpSZW5kZXJCbG9jay5jcHA6ICAgICAgICBpZiAoaGl0 VGVzdEFjdGlvbiA9PSBIaXRUZXN0RmxvYXQgJiYgbV9mbG9hdGluZ09iamVjdHMpIHsKUmVuZGVy QmxvY2suY3BwOiAgICAgICAgICAgIERlcHJlY2F0ZWRQdHJMaXN0SXRlcmF0b3I8RmxvYXRpbmdP YmplY3Q+IGl0KCptX2Zsb2F0aW5nT2JqZWN0cyk7ClJlbmRlckJsb2NrLmNwcDogICAgICAgIGlm IChtX2Zsb2F0aW5nT2JqZWN0cykgewpSZW5kZXJCbG9jay5jcHA6ICAgICAgICAgICAgRGVwcmVj YXRlZFB0ckxpc3RJdGVyYXRvcjxGbG9hdGluZ09iamVjdD4gaXQoKm1fZmxvYXRpbmdPYmplY3Rz KTsKUmVuZGVyQmxvY2suaDogICAgYm9vbCBjb250YWluc0Zsb2F0cygpIHsgcmV0dXJuIG1fZmxv YXRpbmdPYmplY3RzICYmICFtX2Zsb2F0aW5nT2JqZWN0cy0+aXNFbXB0eSgpOyB9ClJlbmRlckJs b2NrLmg6ICAgIERlcHJlY2F0ZWRQdHJMaXN0PEZsb2F0aW5nT2JqZWN0PiogbV9mbG9hdGluZ09i amVjdHM7CmJpZGkuY3BwOiAgICAgICAgRmxvYXRpbmdPYmplY3QqIGxhc3RGbG9hdCA9IG1fZmxv YXRpbmdPYmplY3RzID8gbV9mbG9hdGluZ09iamVjdHMtPmxhc3QoKSA6IDA7CmJpZGkuY3BwOiAg ICAgICAgICAgIGlmIChtX2Zsb2F0aW5nT2JqZWN0cyAmJiBsYXN0Um9vdEJveCgpKSB7CmJpZGku Y3BwOiAgICAgICAgICAgICAgICAgICAgZm9yIChGbG9hdGluZ09iamVjdCogZiA9IG1fZmxvYXRp bmdPYmplY3RzLT5sYXN0KCk7IGYgIT0gbGFzdEZsb2F0OyBmID0gbV9mbG9hdGluZ09iamVjdHMt PnByZXYoKSkgewpiaWRpLmNwcDogICAgICAgICAgICAgICAgICAgIG1fZmxvYXRpbmdPYmplY3Rz LT5uZXh0KCk7CmJpZGkuY3BwOiAgICAgICAgICAgICAgICAgICAgbV9mbG9hdGluZ09iamVjdHMt PmZpcnN0KCk7CmJpZGkuY3BwOiAgICAgICAgICAgICAgICBmb3IgKEZsb2F0aW5nT2JqZWN0KiBm ID0gbV9mbG9hdGluZ09iamVjdHMtPmN1cnJlbnQoKTsgZjsgZiA9IG1fZmxvYXRpbmdPYmplY3Rz LT5uZXh0KCkpIHsKYmlkaS5jcHA6ICAgICAgICAgICAgICAgIGxhc3RGbG9hdCA9IG1fZmxvYXRp bmdPYmplY3RzLT5sYXN0KCk7CmJpZGkuY3BwOiAgICAgICAgaWYgKG1fZmxvYXRpbmdPYmplY3Rz ICYmIChjaGVja0ZvckZsb2F0c0Zyb21MYXN0TGluZSB8fCBwb3NpdGlvbk5ld0Zsb2F0cygpKSAm JiBsYXN0Um9vdEJveCgpKSB7CmJpZGkuY3BwOiAgICAgICAgICAgICAgICBmb3IgKEZsb2F0aW5n T2JqZWN0KiBmID0gbV9mbG9hdGluZ09iamVjdHMtPmxhc3QoKTsgZiAhPSBsYXN0RmxvYXQ7IGYg PSBtX2Zsb2F0aW5nT2JqZWN0cy0+cHJldigpKSB7CmJpZGkuY3BwOiAgICAgICAgICAgICAgICBt X2Zsb2F0aW5nT2JqZWN0cy0+bmV4dCgpOwpiaWRpLmNwcDogICAgICAgICAgICAgICAgbV9mbG9h dGluZ09iamVjdHMtPmZpcnN0KCk7CmJpZGkuY3BwOiAgICAgICAgICAgIGZvciAoRmxvYXRpbmdP YmplY3QqIGYgPSBtX2Zsb2F0aW5nT2JqZWN0cy0+Y3VycmVudCgpOyBmOyBmID0gbV9mbG9hdGlu Z09iamVjdHMtPm5leHQoKSkgewpiaWRpLmNwcDogICAgICAgICAgICBsYXN0RmxvYXQgPSBtX2Zs b2F0aW5nT2JqZWN0cy0+bGFzdCgpOwpiaWRpLmNwcDogICAgICAgIGlmICghZGVsdGEgfHwgIW1f ZmxvYXRpbmdPYmplY3RzKQpiaWRpLmNwcDogICAgICAgIGZvciAoRmxvYXRpbmdPYmplY3QqIGYg PSBtX2Zsb2F0aW5nT2JqZWN0cy0+Zmlyc3QoKTsgZjsgZiA9IG1fZmxvYXRpbmdPYmplY3RzLT5u ZXh0KCkpIHsKYmlkaS5jcHA6ICAgICAgICAgICAgaWYgKGRlbHRhICYmIG1fZmxvYXRpbmdPYmpl Y3RzKSB7CmJpZGkuY3BwOiAgICAgICAgICAgICAgICBmb3IgKEZsb2F0aW5nT2JqZWN0KiBmID0g bV9mbG9hdGluZ09iamVjdHMtPmZpcnN0KCk7IGY7IGYgPSBtX2Zsb2F0aW5nT2JqZWN0cy0+bmV4 dCgpKSB7Cg==