26191 2009-06-04 10:41:42 -0700 We should not need to include xmath.h 2009-06-12 15:42:54 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) PC Windows Vista RESOLVED FIXED P2 Normal --- 1 dglazkov dglazkov andersca oldest_to_newest 124334 0 dglazkov 2009-06-04 10:41:42 -0700 Per http://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?FeedbackID=361804, we shouldn't need to include <xmath.h> in MathExtras.h This in turn breaks VS2008 builds with TR1 turned on. 124335 1 30951 dglazkov 2009-06-04 10:44:16 -0700 Created attachment 30951 Remove xmath, v1. JavaScriptCore/ChangeLog | 10 ++++++++++ JavaScriptCore/wtf/MathExtras.h | 2 -- 2 files changed, 10 insertions(+), 2 deletions(-) 124446 2 30951 eric 2009-06-04 20:17:34 -0700 Comment on attachment 30951 Remove xmath, v1. Assuming you're going to watch and make sure you didn't break the Windows bot, then this is OK with me. 125547 3 eric 2009-06-12 15:16:53 -0700 Success! 125548 4 eric 2009-06-12 15:17:34 -0700 Bah, sorry. My commit-script went amuck. 125556 5 eric 2009-06-12 15:42:07 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/wtf/MathExtras.h Committed r44633 M JavaScriptCore/wtf/MathExtras.h M JavaScriptCore/ChangeLog r44633 = c2c22c62a94efb33933a7dddfceebe1899f6f229 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk 125557 6 eric 2009-06-12 15:42:54 -0700 Tada! My commit script worked!!! bug 26283 30951 2009-06-04 10:44:16 -0700 2009-06-04 20:17:34 -0700 Remove xmath, v1. Remove-xmath-v1..patch text/plain 956 dglazkov MDE1MzhmNWFiMGE3YzM0NDQ4OWU5MmYwZWJlY2M5YzA3MWRkZjkwNwpkaWZmIC0tZ2l0IGEvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDE1 NGY1YTQuLjJlZmY2YjMgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysg Yi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wNi0wNCAg RGltaXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yNjE5MQorICAgICAgICBSZW1vdmUgeG1hdGggaW5jbHVkZSBpbiBN YXRoRXh0cmFzLmgsIGJlY2F1c2UgaXQgaXMgbm90IG5lZWRlZCBhbmQgYWxzbworICAgICAgICBi cmVha3MgVlMyMDA4IGJ1aWxkcyB3aXRoIFRSMSB0dXJuZWQgb24uCisKKyAgICAgICAgKiB3dGYv TWF0aEV4dHJhcy5oOiBSZW1vdmVkIHhtYXRoIGluY2x1ZGUuCisKIDIwMDktMDYtMDIgIE1hcmsg Um93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2Fy bHNzb24uCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS93dGYvTWF0aEV4dHJhcy5oIGIvSmF2 YVNjcmlwdENvcmUvd3RmL01hdGhFeHRyYXMuaAppbmRleCA3NjQ4OGI0Li5mYmVjMWUwIDEwMDY0 NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvTWF0aEV4dHJhcy5oCisrKyBiL0phdmFTY3JpcHRD b3JlL3d0Zi9NYXRoRXh0cmFzLmgKQEAgLTQxLDggKzQxLDYgQEAKICNpZiBDT01QSUxFUihNU1ZD KQogI2lmIFBMQVRGT1JNKFdJTl9DRSkKICNpbmNsdWRlIDxzdGRsaWIuaD4KLSNlbHNlCi0jaW5j bHVkZSA8eG1hdGguaD4KICNlbmRpZgogI2luY2x1ZGUgPGxpbWl0cz4KIAo=