26190 2009-06-04 10:38:33 -0700 Null dereference when hidding -webkit-media-*. 2009-06-09 15:43:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 pdherbemont webkit-unassigned eric.carlson oldest_to_newest 124331 0 pdherbemont 2009-06-04 10:38:33 -0700 STEPS: - dropping a <video> part - adding this css: video::-webkit-media-controls-panel{ display:none } <rdar://problem/6941889> 124358 1 30954 pdherbemont 2009-06-04 12:38:34 -0700 Created attachment 30954 patch v1. Patch + Test attached. 124447 2 30954 eric 2009-06-04 20:19:16 -0700 Comment on attachment 30954 patch v1. The test case is kinda strangely out-of-style for LayoutTests. But it's fine and the patch is fine. 124578 3 pdherbemont 2009-06-05 14:44:30 -0700 Eric - I can update the out-of-style test. But I have no idea what does out-of-style mean :) If you have any pointers... 125027 4 bfulgham 2009-06-09 15:43:56 -0700 Landed in @r44546. Corrected use of tabs (FORBIDDEN!) in test file. 30954 2009-06-04 12:38:34 -0700 2009-06-04 20:19:16 -0700 patch v1. patch-v1.patch text/plain 3662 pdherbemont Y29tbWl0IDBhMGNhMDY5NDNhZWRlZDFlNTM5YzIyZjVkYjAyNWNkOWQxZDdkNmIKQXV0aG9yOiBQ aWVycmUgZCdIZXJiZW1vbnQgPHBkaGVyYmVtb250QGFwcGxlLmNvbT4KRGF0ZTogICBUaHUgSnVu IDQgMTE6MDM6NTQgMjAwOSAtMDcwMAoKICAgIENyYXNoIGZpeC4KCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMWZkMTBlMS4u NmFmMmEyNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRl c3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDA5LTA2LTA0ICBQaWVycmUgZCdIZXJi ZW1vbnQgIDxwZGhlcmJlbW9udEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdCBjYXNlIG9uIGludGVybmFsIC13ZWJraXQtbWVk aWEgb3ZlcmxvYWQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTI2MTkwCisKKyAgICAgICAgKiBtZWRpYS9jb250cm9scy1jc3Mtb3ZlcmxvYWQtZXhw ZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBtZWRpYS9jb250cm9scy1jc3Mtb3ZlcmxvYWQu aHRtbDogQWRkZWQuCisKIDIwMDktMDYtMDUgIERtaXRyeSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9tZWRpYS9jb250cm9scy1jc3Mtb3ZlcmxvYWQtZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvbWVkaWEvY29udHJvbHMtY3NzLW92ZXJsb2FkLWV4cGVjdGVkLnR4dApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi44NTViNjY5Ci0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvbWVkaWEvY29udHJvbHMtY3NzLW92ZXJsb2FkLWV4cGVjdGVkLnR4dApAQCAt MCwwICsxLDQgQEAKKyAKK0kgZGlkIG5vdCBjcmFzaAorRU5EIE9GIFRFU1QKKwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvbWVkaWEvY29udHJvbHMtY3NzLW92ZXJsb2FkLmh0bWwgYi9MYXlvdXRU ZXN0cy9tZWRpYS9jb250cm9scy1jc3Mtb3ZlcmxvYWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwLi4xYjg4Y2EwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv bWVkaWEvY29udHJvbHMtY3NzLW92ZXJsb2FkLmh0bWwKQEAgLTAsMCArMSwyNiBAQAorPCFET0NU WVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEvL0VOIgorICAgImh0dHA6Ly93 d3cudzMub3JnL1RSL2h0bWw0L3N0cmljdC5kdGQiPgorCis8aHRtbD4KKzxoZWFkPgorICAgIDx0 aXRsZT5UZXN0aW5nIHRoYXQgb3ZlcmxvYWRpbmcgc29tZSBjb250cm9scyBkb2Vzbid0IGNyYXNo IHRoZSBicm93c2VyPC90aXRsZT4KKwk8c3R5bGU+CisJCS5ub2NvbnRyb2xzOjotd2Via2l0LW1l ZGlhLWNvbnRyb2xzLXBhbmVseworCQkJZGlzcGxheTpub25lOworCQl9CisJCS5ub3RpbWVsaW5l Ojotd2Via2l0LW1lZGlhLWNvbnRyb2xzLXRpbWVsaW5lLWNvbnRhaW5lcnsKKwkJCWRpc3BsYXk6 bm9uZTsKKwkJfQorCTwvc3R5bGU+CisgICAgPHNjcmlwdCBzcmM9dmlkZW8tdGVzdC5qcz48L3Nj cmlwdD4KKzwvaGVhZD4KKzxib2R5PgorCisJPHZpZGVvIGNsYXNzPSJub2NvbnRyb2xzIiB3aWR0 aD0zMDAgaGVpZ2h0PTIwMCBjb250cm9scz48L3ZpZGVvPgorCTx2aWRlbyBjbGFzcz0ibm90aW1l bGluZSIgd2lkdGg9MzAwIGhlaWdodD0yMDAgY29udHJvbHM+PC92aWRlbz4KKyAgICA8c2NyaXB0 PgorICAgIGNvbnNvbGVXcml0ZSgiSSBkaWQgbm90IGNyYXNoIik7CisgICAgZW5kVGVzdCgpOwor ICAgIDwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFu Z2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiZjVjMmM3Li4zMmQ4NmViIDEwMDY0NAot LS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDA5LTA2LTA0ICBQaWVycmUgZCdIZXJiZW1vbnQgIDxwZGhlcmJlbW9udEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2MTkwCisKKyAgICAgICAg VGVzdDogbWVkaWEvY29udHJvbHMtY3NzLW92ZXJsb2FkLmh0bWwKKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJNZWRpYS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJNZWRpYTo6dXBk YXRlQ29udHJvbHMpOiBQcmV2ZW50IE5VTEwgZGVyZWZlcmVuY2UgaW4gY2FzZSBjb250YWluZXJz IGdldHMgaGlkZGVuLgorCiAyMDA5LTA2LTAzICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyTWVkaWEuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTWVk aWEuY3BwCmluZGV4IDJmZmEyZjYuLjE4MDNlNDkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlck1lZGlhLmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNZWRpYS5j cHAKQEAgLTI2OSwxNSArMjY5LDE5IEBAIHZvaWQgUmVuZGVyTWVkaWE6OnVwZGF0ZUNvbnRyb2xz KCkKICAgICBpZiAoIW1fY29udHJvbHNTaGFkb3dSb290KSB7CiAgICAgICAgIGNyZWF0ZUNvbnRy b2xzU2hhZG93Um9vdCgpOwogICAgICAgICBjcmVhdGVQYW5lbCgpOwotICAgICAgICBjcmVhdGVN dXRlQnV0dG9uKCk7Ci0gICAgICAgIGNyZWF0ZVBsYXlCdXR0b24oKTsKLSAgICAgICAgY3JlYXRl VGltZWxpbmVDb250YWluZXIoKTsKLSAgICAgICAgY3JlYXRlVGltZWxpbmUoKTsKLSAgICAgICAg Y3JlYXRlU2Vla0JhY2tCdXR0b24oKTsKLSAgICAgICAgY3JlYXRlU2Vla0ZvcndhcmRCdXR0b24o KTsKLSAgICAgICAgY3JlYXRlQ3VycmVudFRpbWVEaXNwbGF5KCk7Ci0gICAgICAgIGNyZWF0ZVRp bWVSZW1haW5pbmdEaXNwbGF5KCk7Ci0gICAgICAgIGNyZWF0ZUZ1bGxzY3JlZW5CdXR0b24oKTsK KyAgICAgICAgaWYgKG1fcGFuZWwgJiYgbV9wYW5lbC0+cmVuZGVyZXIoKSkgeworICAgICAgICAg ICAgY3JlYXRlTXV0ZUJ1dHRvbigpOworICAgICAgICAgICAgY3JlYXRlUGxheUJ1dHRvbigpOwor ICAgICAgICAgICAgY3JlYXRlVGltZWxpbmVDb250YWluZXIoKTsKKyAgICAgICAgICAgIGNyZWF0 ZVNlZWtCYWNrQnV0dG9uKCk7CisgICAgICAgICAgICBjcmVhdGVTZWVrRm9yd2FyZEJ1dHRvbigp OworICAgICAgICAgICAgY3JlYXRlRnVsbHNjcmVlbkJ1dHRvbigpOyAgICAgICAgICAgIAorICAg ICAgICB9CisgICAgICAgIGlmIChtX3RpbWVsaW5lQ29udGFpbmVyICYmIG1fdGltZWxpbmVDb250 YWluZXItPnJlbmRlcmVyKCkpIHsKKyAgICAgICAgICAgIGNyZWF0ZUN1cnJlbnRUaW1lRGlzcGxh eSgpOworICAgICAgICAgICAgY3JlYXRlVGltZWxpbmUoKTsKKyAgICAgICAgICAgIGNyZWF0ZVRp bWVSZW1haW5pbmdEaXNwbGF5KCk7CisgICAgICAgIH0KICAgICB9CiAKICAgICBpZiAobWVkaWEt PmNhblBsYXkoKSkgewo=