26188 2009-06-04 09:49:03 -0700 Clarify some of the cases in the coding style guide 2009-06-05 10:44:12 -0700 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 kenneth webkit-unassigned ddkilzer oldest_to_newest 124322 0 kenneth 2009-06-04 09:49:03 -0700 Here is a patch clarifying some cases of ambiguity in the coding style guide, with regard to control clauses. 124323 1 30948 kenneth 2009-06-04 09:49:57 -0700 Created attachment 30948 Changed the coding style document to clarify some cases of ambiguity. 124342 2 30948 ddkilzer 2009-06-04 11:26:34 -0700 Comment on attachment 30948 Changed the coding style document to clarify some cases of ambiguity. You must set the review? flag to get it reviewed. :) 124350 3 levin 2009-06-04 11:59:13 -0700 Since you're clarifying this rule about single line clauses, you may want to make it slightly more general (as discussed on webkit-dev). Here was my attempt but you may find a way to phrase it better: "Control clauses (including any preceeding comments) that are one physical line should not use braces". Good: if (test) { myFunction(reallyLongParam1, reallyLongParam2, ... reallyLongParam4); } 124364 4 30955 kenneth 2009-06-04 13:00:37 -0700 Created attachment 30955 Incorporated the review commetns 124375 5 30955 ddkilzer 2009-06-04 13:32:10 -0700 Comment on attachment 30955 Incorporated the review commetns You must still set the review? flag. 124376 6 kenneth 2009-06-04 13:39:10 -0700 How do I do that? Add a keyword? 124518 7 ddkilzer 2009-06-05 07:52:10 -0700 (In reply to comment #6) > How do I do that? Add a keyword? Click the "Edit" button on the attachment after it's been attached, or look for the "Flags" section when attaching new files and set the pop-up menu to "?" next to the word "review". 124544 8 30955 ddkilzer 2009-06-05 10:41:53 -0700 Comment on attachment 30955 Incorporated the review commetns r=me. I'll land this with some verbage tweaks. 124545 9 ddkilzer 2009-06-05 10:43:31 -0700 $ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitSite/ChangeLog M WebKitSite/coding/coding-style.html Committed r44473 http://trac.webkit.org/changeset/44473 124546 10 ddkilzer 2009-06-05 10:44:12 -0700 (In reply to comment #8) > (From update of attachment 30955 [review]) > r=me. I'll land this with some verbage tweaks. Also, verbiage tweaks. :) 30948 2009-06-04 09:49:57 -0700 2009-06-04 13:32:17 -0700 Changed the coding style document to clarify some cases of ambiguity. 0001-2009-06-04-Kenneth-Rohde-Christiansen-kenneth.chr.patch text/plain 2392 kenneth RnJvbSBiMGVhNjNmYmQ4ZDNiNTgxZDMyZjg4NGJjYzEzNjdlZGMxNjUyMDQxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiA8a2VubmV0aEBz cGlzbmlnZWwub3NtdGMuaW5kdC5vcmcuYnI+CkRhdGU6IFRodSwgNCBKdW4gMjAwOSAxMzo0Njoz MCAtMDMwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMDktMDYtMDQgIEtlbm5ldGggUm9oZGUgQ2hyaXN0 aWFuc2VuICA8a2VubmV0aC5jaHJpc3RpYW5zZW5Ab3BlbmJvc3NhLmNvbT4KCiAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIENoYW5nZWQgdGhlIGNvZGluZyBzdHls ZSBkb2N1bWVudCB0byBjbGFyaWZ5IHNvbWUgY2FzZXMgb2YgYW1iaWd1aXR5LgoKICAgICAgICAq IGNvZGluZy9jb2Rpbmctc3R5bGUuaHRtbDoKLS0tCiBXZWJLaXRTaXRlL0NoYW5nZUxvZyAgICAg ICAgICAgICAgICB8ICAgIDggKysrKysrKysKIFdlYktpdFNpdGUvY29kaW5nL2NvZGluZy1zdHls ZS5odG1sIHwgICAyNCArKysrKysrKysrKysrKysrKysrKysrLS0KIDIgZmlsZXMgY2hhbmdlZCwg MzAgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXRTaXRl L0NoYW5nZUxvZyBiL1dlYktpdFNpdGUvQ2hhbmdlTG9nCmluZGV4IDdlNzY3YmIuLjQ1OWQ5YWIg MTAwNjQ0Ci0tLSBhL1dlYktpdFNpdGUvQ2hhbmdlTG9nCisrKyBiL1dlYktpdFNpdGUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDktMDYtMDQgIEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFu c2VuICA8a2VubmV0aC5jaHJpc3RpYW5zZW5Ab3BlbmJvc3NhLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2VkIHRoZSBjb2Rpbmcgc3R5 bGUgZG9jdW1lbnQgdG8gY2xhcmlmeSBzb21lIGNhc2VzIG9mIGFtYmlndWl0eS4KKworICAgICAg ICAqIGNvZGluZy9jb2Rpbmctc3R5bGUuaHRtbDoKKwogMjAwOS0wNS0yNyAgTWFjaWVqIFN0YWNo b3dpYWsgIDxtanNAYXBwbGUuY29tPgogCiAgICAgICAgIE5vdCByZXZpZXdlZCwgZGVtbyBjb250 ZW50LgpkaWZmIC0tZ2l0IGEvV2ViS2l0U2l0ZS9jb2RpbmcvY29kaW5nLXN0eWxlLmh0bWwgYi9X ZWJLaXRTaXRlL2NvZGluZy9jb2Rpbmctc3R5bGUuaHRtbAppbmRleCAwMzU1OTBjLi41OTJhNmFk IDEwMDY0NAotLS0gYS9XZWJLaXRTaXRlL2NvZGluZy9jb2Rpbmctc3R5bGUuaHRtbAorKysgYi9X ZWJLaXRTaXRlL2NvZGluZy9jb2Rpbmctc3R5bGUuaHRtbApAQCAtMjIwLDcgKzIyMCw3IEBAIGlm IChjb25kaXRpb24pIGRvSXQoKTsKIDwvcHJlPgogPC9saT4KIAotPGxpPkFuIDxjb2RlPmVsc2U8 L2NvZGU+IHN0YXRlbWVudCBzaG91bGQgZ28gb24gdGhlIHNhbWUgbGluZSBhcyBhIHByZWNlZGlu ZyBjbG9zZSBicmFjZS4KKzxsaT5BbiA8Y29kZT5lbHNlPC9jb2RlPiBzdGF0ZW1lbnQgc2hvdWxk IGdvIG9uIHRoZSBzYW1lIGxpbmUgYXMgYSBwcmVjZWRpbmcgY2xvc2UgYnJhY2UsIGlmIHN1Y2gg b25lIGlzIHByZXNlbnQKIDxoNCBjbGFzcz0icmlnaHQiPlJpZ2h0OjwvaDQ+CiA8cHJlIGNsYXNz PSJjb2RlIj4KIGlmIChjb25kaXRpb24pIHsKQEAgLTIyOCw2ICsyMjgsMTcgQEAgaWYgKGNvbmRp dGlvbikgewogfSBlbHNlIHsKICAgICAuLi4KIH0KKworaWYgKGNvbmRpdGlvbikKKyAgICBkb1Nv bWV0aGluZygpOworZWxzZQorICAgIGRvU29tZXRoaW5nRWxzZSgpOworCitpZiAoY29uZGl0aW9u KQorICAgIGRvU29tZXRoaW5nKCk7CitlbHNlIHsKKyAgICAuLi4KK30KIDwvcHJlPgogCiA8aDQg Y2xhc3M9Indyb25nIj5Xcm9uZzo8L2g0PgpAQCAtMzA4LDExICszMTksMTYgQEAgY2xhc3MgTXlD bGFzcwogICAgIC4uLgogfTsKIDwvcHJlPgotPGxpPk9uZS1saW5lIGNvbnRyb2wgY2xhdXNlcyBz aG91bGQgbm90IHVzZSBicmFjZXMKKzxsaT5PbmUtbGluZSBjb250cm9sIGNsYXVzZXMgc2hvdWxk IG5vdCB1c2UgYnJhY2VzLCB1bmxlc3MgYSBjb21tZW50IGlzIGFkZGVkIGluc2lkZSB0aGUgbG9j YWwgc2NvcGUuCiA8aDQgY2xhc3M9InJpZ2h0Ij5SaWdodDo8L2g0PgogPHByZSBjbGFzcz0iY29k ZSI+CiBpZiAoY29uZGl0aW9uKQogICAgIGRvSXQoKTsKKworaWYgKGNvbmRpdGlvbikgeworICAg IC8vIHNvbWUgY29tbWVudAorICAgIGRvSXQoKTsKK30KIDwvcHJlPgogCiA8aDQgY2xhc3M9Indy b25nIj5Xcm9uZzo8L2g0PgpAQCAtMzIwLDYgKzMzNiwxMCBAQCBpZiAoY29uZGl0aW9uKQogaWYg KGNvbmRpdGlvbikgewogICAgIGRvSXQoKTsKIH0KKworaWYgKGNvbmRpdGlvbikKKyAgICAvLyBz b21lIGNvbW1lbnQKKyAgICBkb0l0KCk7CiA8L3ByZT4KIDwvbGk+CiAKLS0gCjEuNi4wLjQKCg== 30955 2009-06-04 13:00:37 -0700 2009-06-05 10:41:53 -0700 Incorporated the review commetns new-patch-incorporating-review-comments.patch text/plain 2613 kenneth RnJvbSAwNjcyNTcyNjU4OGY1OGVhOWU3NDZkMjE0OWE2MTBjNjMyMmRjNjE0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiA8a2VubmV0aEBz cGlzbmlnZWwub3NtdGMuaW5kdC5vcmcuYnI+CkRhdGU6IFRodSwgNCBKdW4gMjAwOSAxMzo0Njoz MCAtMDMwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMDktMDYtMDQgIEtlbm5ldGggUm9oZGUgQ2hyaXN0 aWFuc2VuICA8a2VubmV0aC5jaHJpc3RpYW5zZW5Ab3BlbmJvc3NhLmNvbT4KCiAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIENoYW5nZWQgdGhlIGNvZGluZyBzdHls ZSBkb2N1bWVudCB0byBjbGFyaWZ5IHNvbWUgY2FzZXMgb2YgYW1iaWd1aXR5LgoKICAgICAgICAq IGNvZGluZy9jb2Rpbmctc3R5bGUuaHRtbDoKLS0tCiBXZWJLaXRTaXRlL0NoYW5nZUxvZyAgICAg ICAgICAgICAgICB8ICAgIDggKysrKysrKysKIFdlYktpdFNpdGUvY29kaW5nL2NvZGluZy1zdHls ZS5odG1sIHwgICAzMyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0KIDIgZmlsZXMg Y2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9X ZWJLaXRTaXRlL0NoYW5nZUxvZyBiL1dlYktpdFNpdGUvQ2hhbmdlTG9nCmluZGV4IDdlNzY3YmIu LjQ1OWQ5YWIgMTAwNjQ0Ci0tLSBhL1dlYktpdFNpdGUvQ2hhbmdlTG9nCisrKyBiL1dlYktpdFNp dGUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDktMDYtMDQgIEtlbm5ldGggUm9oZGUg Q2hyaXN0aWFuc2VuICA8a2VubmV0aC5jaHJpc3RpYW5zZW5Ab3BlbmJvc3NhLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2VkIHRoZSBj b2Rpbmcgc3R5bGUgZG9jdW1lbnQgdG8gY2xhcmlmeSBzb21lIGNhc2VzIG9mIGFtYmlndWl0eS4K KworICAgICAgICAqIGNvZGluZy9jb2Rpbmctc3R5bGUuaHRtbDoKKwogMjAwOS0wNS0yNyAgTWFj aWVqIFN0YWNob3dpYWsgIDxtanNAYXBwbGUuY29tPgogCiAgICAgICAgIE5vdCByZXZpZXdlZCwg ZGVtbyBjb250ZW50LgpkaWZmIC0tZ2l0IGEvV2ViS2l0U2l0ZS9jb2RpbmcvY29kaW5nLXN0eWxl Lmh0bWwgYi9XZWJLaXRTaXRlL2NvZGluZy9jb2Rpbmctc3R5bGUuaHRtbAppbmRleCAwMzU1OTBj Li41YzI2NGQzIDEwMDY0NAotLS0gYS9XZWJLaXRTaXRlL2NvZGluZy9jb2Rpbmctc3R5bGUuaHRt bAorKysgYi9XZWJLaXRTaXRlL2NvZGluZy9jb2Rpbmctc3R5bGUuaHRtbApAQCAtMjIwLDcgKzIy MCw3IEBAIGlmIChjb25kaXRpb24pIGRvSXQoKTsKIDwvcHJlPgogPC9saT4KIAotPGxpPkFuIDxj b2RlPmVsc2U8L2NvZGU+IHN0YXRlbWVudCBzaG91bGQgZ28gb24gdGhlIHNhbWUgbGluZSBhcyBh IHByZWNlZGluZyBjbG9zZSBicmFjZS4KKzxsaT5BbiA8Y29kZT5lbHNlPC9jb2RlPiBzdGF0ZW1l bnQgc2hvdWxkIGdvIG9uIHRoZSBzYW1lIGxpbmUgYXMgYSBwcmVjZWRpbmcgY2xvc2UgYnJhY2Us IGlmIHN1Y2ggb25lIGlzIHByZXNlbnQKIDxoNCBjbGFzcz0icmlnaHQiPlJpZ2h0OjwvaDQ+CiA8 cHJlIGNsYXNzPSJjb2RlIj4KIGlmIChjb25kaXRpb24pIHsKQEAgLTIyOCw2ICsyMjgsMTcgQEAg aWYgKGNvbmRpdGlvbikgewogfSBlbHNlIHsKICAgICAuLi4KIH0KKworaWYgKGNvbmRpdGlvbikK KyAgICBkb1NvbWV0aGluZygpOworZWxzZQorICAgIGRvU29tZXRoaW5nRWxzZSgpOworCitpZiAo Y29uZGl0aW9uKQorICAgIGRvU29tZXRoaW5nKCk7CitlbHNlIHsKKyAgICAuLi4KK30KIDwvcHJl PgogCiA8aDQgY2xhc3M9Indyb25nIj5Xcm9uZzo8L2g0PgpAQCAtMzA4LDExICszMTksMjEgQEAg Y2xhc3MgTXlDbGFzcwogICAgIC4uLgogfTsKIDwvcHJlPgotPGxpPk9uZS1saW5lIGNvbnRyb2wg Y2xhdXNlcyBzaG91bGQgbm90IHVzZSBicmFjZXMKKzxsaT5Db250cm9sIGNsYXVzZXMgKGluY2x1 ZGluZyBhbnkgcHJlY2VkaW5nIGNvbW1lbnRzKSB0aGF0IGFyZSBvbmUgcGh5c2ljYWwgbGluZSBz aG91bGQgbm90IHVzZSBicmFjZXMuCiA8aDQgY2xhc3M9InJpZ2h0Ij5SaWdodDo8L2g0PgogPHBy ZSBjbGFzcz0iY29kZSI+CiBpZiAoY29uZGl0aW9uKQogICAgIGRvSXQoKTsKKworaWYgKGNvbmRp dGlvbikgeworICAgIC8vIHNvbWUgY29tbWVudAorICAgIGRvSXQoKTsKK30KKworaWYgKGNvbmRp dGlvbikgeworICAgIG15RnVuY3Rpb24ocmVhbGx5TG9uZ1BhcmFtMSwgcmVhbGx5TG9uZ1BhcmFt MiwgLi4uCisgICAgICAgIHJlYWxseUxvbmdQYXJhbTUpOworfQogPC9wcmU+CiAKIDxoNCBjbGFz cz0id3JvbmciPldyb25nOjwvaDQ+CkBAIC0zMjAsNiArMzQxLDE0IEBAIGlmIChjb25kaXRpb24p CiBpZiAoY29uZGl0aW9uKSB7CiAgICAgZG9JdCgpOwogfQorCitpZiAoY29uZGl0aW9uKQorICAg IC8vIHNvbWUgY29tbWVudAorICAgIGRvSXQoKTsKKworaWYgKGNvbmRpdGlvbikKKyAgICBteUZ1 bmN0aW9uKHJlYWxseUxvbmdQYXJhbTEsIHJlYWxseUxvbmdQYXJhbTIsIC4uLgorICAgICAgICBy ZWFsbHlMb25nUGFyYW01KTsKIDwvcHJlPgogPC9saT4KIAotLSAKMS42LjAuNAoK