26187 2009-06-04 08:22:04 -0700 Canvas initial lineWidth not in sync with graphics backends. 2009-06-09 17:18:22 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 deanm webkit-unassigned bfulgham eric oliver oldest_to_newest 124308 0 deanm 2009-06-04 08:22:04 -0700 The canvas rendering context has two pieces of state, the drawing context / graphics backend. Canvas always defaults to a thickness of 1. It happens that the CG backend also defaults to 1. However, the Skia backend defaults to 0, and the Cairo backend defaults to 2. This means that the follow line changes the style in both the Skia and Cairo backends: ctx.lineWidth = ctx.lineWidth; This is because ctx.lineWidth reports the <canvas> state, which is initially 1. However, this is not actually querying the graphics backend. Then setting it to 1 actually keeps them in sync. My fix is simple, to set 1 to the graphics backend on creation of the canvas rendering context. It might be something bigger / for the future to consider whether the Skia and Cairo backends should also default to a thickness of 1. 124309 1 30947 deanm 2009-06-04 08:24:26 -0700 Created attachment 30947 patch w/ layout test 124360 2 30947 oliver 2009-06-04 12:42:00 -0700 Comment on attachment 30947 patch w/ layout test The fix itself looks good but i don't like the layout test. You should look at the design of the more modern canvas tests -- they're basically the same structure as JS ones so find a test which has the following fast/canvas/test-name.html // html document will just have some boiler plate that includes a couple of js files, resoureces/test-name.js and then another js file fast/canvas/resources/test-name.js // The actual test itself I *think* the isPointInPath tests cases will be of this newer style. The newer style is vastly more useful as we use getImagedata to anaylse the result of drawing rather than relying on pixel comparisons. This is especially benefical given people typically do no run pixel tests, but also because it's much easier to see what is being tested. --Oliver 124922 3 31088 deanm 2009-06-09 03:16:18 -0700 Created attachment 31088 New patch with more modern layout test 124972 4 31088 oliver 2009-06-09 10:46:30 -0700 Comment on attachment 31088 New patch with more modern layout test r=me 125004 5 bfulgham 2009-06-09 13:40:19 -0700 Landed in @r44542 125038 6 fishd 2009-06-09 16:50:05 -0700 Guys, this is missing expected test results. The buildbots are not happy. 125040 7 bfulgham 2009-06-09 17:18:22 -0700 Added missing canvas-lineWidth-expected.txt in @r44548. 30947 2009-06-04 08:24:26 -0700 2009-06-04 12:42:00 -0700 patch w/ layout test p text/plain 2635 deanm ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwNGIyOWFiLi4zY2ZhNmI0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTAgQEAKKzIwMDktMDYt MDQgIERlYW4gTWNOYW1lZSAgPGRlYW5tQGNocm9taXVtLm9yZz4KKworICAgICAgICBNYWtlIHN1 cmUgdGhlIGdyYXBoaWNzIGJhY2tlbmRzIGFyZSBpbiBzeW5jIHdpdGggdGhlIGNhbnZhcyBsaW5l V2lkdGggc3RhdGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yNjE4NworCisgICAgICAgICogZmFzdC9jYW52YXMvY2FudmFzLWxpbmUtd2lkdGguaHRt bDogQWRkZWQuCisKIDIwMDktMDYtMDMgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IE1hcmsgUm93ZS4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL2NhbnZhcy1saW5lLXdpZHRoLmh0bWwgYi9MYXlvdXRU ZXN0cy9mYXN0L2NhbnZhcy9jYW52YXMtbGluZS13aWR0aC5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAuLjYyNDViZjQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2NhbnZhcy9jYW52YXMtbGluZS13aWR0aC5odG1sCkBAIC0wLDAgKzEsMjkgQEAKKzxo dG1sPgorPGJvZHk+Cis8cD4KK1Rlc3QgdGhlIGRlZmF1bHQgbGluZSB3aWR0aCBpcyBjb25zaXN0 ZW50LiAgQWxsIHRocmVlIGxpbmVzIHNob3VsZCBzdHJva2UgdGhlIHNhbWUuCis8L3A+Cis8Y2Fu dmFzIGlkPSJjYW52YXMiIHdpZHRoPTYwMCBoZWlnaHQ9MzAwIHN0eWxlPSJib3JkZXI6NXB4IHNv bGlkIGJsYWNrIj4KKzxzY3JpcHQ+Cit2YXIgY3R4ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo J2NhbnZhcycpLmdldENvbnRleHQoJzJkJyk7CitjdHguc3Ryb2tlU3R5bGUgPSAnYmx1ZSc7CisK K2ZvciAodmFyIGogPSAxOyBqIDwgNDsgKytqKSB7CisgICAgY3R4LmJlZ2luUGF0aCgpOworICAg IGZvciAodmFyIGkgPSAwOyBpIDwgMTAwOyArK2kpIHsKKyAgICAgICAgaWYgKGkgPT0gMCkgewor ICAgICAgICAgICAgY3R4Lm1vdmVUbyhpICogMTAsIGogKiA1MCArIChpICUgMTApKTsKKyAgICAg ICAgfSBlbHNlIHsKKyAgICAgICAgICAgIGN0eC5saW5lVG8oaSAqIDEwLCBqICogNTAgKyAoaSAl IDEwKSk7CisgICAgICAgIH0KKyAgICB9CisgICAgY3R4LnN0cm9rZSgpOworCisgICAgaWYgKGog PT0gMSkgeworICAgICAgICBjdHgubGluZVdpZHRoID0gY3R4LmxpbmVXaWR0aDsKKyAgICB9IGVs c2UgeworICAgICAgICBjdHgubGluZVdpZHRoID0gMTsKKyAgICB9Cit9CisKKzwvc2NyaXB0Pgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBm M2IyZGI3Li5iYzc4NmQ0IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDA5LTA2LTA0ICBEZWFuIE1jTmFtZWUg IDxkZWFubUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTWFrZSBzdXJlIHRoZSBncmFwaGljcyBi YWNrZW5kcyBhcmUgaW4gc3luYyB3aXRoIHRoZSBjYW52YXMgbGluZVdpZHRoIHN0YXRlLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjYxODcKKworICAg ICAgICBUZXN0OiBmYXN0L2NhbnZhcy9jYW52YXMtbGluZS13aWR0aC5odG1sCisKKyAgICAgICAg KiBodG1sL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpD YW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRCk6CisKIDIw MDktMDYtMDMgIEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuICA8a2VubmV0aC5jaHJpc3RpYW5z ZW5Ab3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwIGIv V2ViQ29yZS9odG1sL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKaW5kZXggYjMyMWI0MC4u MThjM2JkOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQy RC5jcHAKKysrIGIvV2ViQ29yZS9odG1sL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKQEAg LTk2LDYgKzk2LDkgQEAgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpDYW52YXNSZW5kZXJpbmdD b250ZXh0MkQoSFRNTENhbnZhc0VsZW1lbnQqIGNhbnZhcykKICAgICA6IG1fY2FudmFzKGNhbnZh cykKICAgICAsIG1fc3RhdGVTdGFjaygxKQogeworICAgIC8vIE1ha2Ugc3VyZSB0aGF0IGV2ZW4g aWYgdGhlIGRyYXdpbmdDb250ZXh0KCkgaGFzIGEgZGlmZmVyZW50IGRlZmF1bHQKKyAgICAvLyB0 aGlja25lc3MsIGl0IGlzIGluIHN5bmMgd2l0aCB0aGF0IGNhbnZhcyB0aGlja25lc3MuCisgICAg c2V0TGluZVdpZHRoKGxpbmVXaWR0aCgpKTsKIH0KIAogdm9pZCBDYW52YXNSZW5kZXJpbmdDb250 ZXh0MkQ6OnJlZigpCg== 31088 2009-06-09 03:16:18 -0700 2009-06-09 10:46:30 -0700 New patch with more modern layout test p text/plain 4055 deanm ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxMDUzNjlhLi5lZWUzZTQ2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDYt MDkgIERlYW4gTWNOYW1lZSAgPGRlYW5tQGNocm9taXVtLm9yZz4KKworICAgICAgICBNYWtlIHN1 cmUgdGhlIGdyYXBoaWNzIGJhY2tlbmRzIGFyZSBpbiBzeW5jIHdpdGggdGhlIGNhbnZhcyBsaW5l V2lkdGggc3RhdGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yNjE4NworCisgICAgICAgICogZmFzdC9jYW52YXMvY2FudmFzLWxpbmVXaWR0aC5odG1s OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2NhbnZhcy9jYW52YXMtbGluZVdpZHRoLmpzOiBBZGRl ZC4KKyAgICAgICAgKGNvbXBhcmVSb3dzKToKKwogMjAwOS0wNi0wOCAgQnJhZHkgRWlkc29uICA8 YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW50dGkgS29pdmlzdG8K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL2NhbnZhcy1saW5lV2lkdGguaHRt bCBiL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL2NhbnZhcy1saW5lV2lkdGguaHRtbApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5lMGFlYjExCi0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvY2FudmFzLWxpbmVXaWR0aC5odG1sCkBAIC0wLDAgKzEs MTQgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxo dG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uL2pzL3Jlc291cmNl cy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRl c3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9u Ij48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxjYW52YXMgaWQ9ImNhbnZhcyIgd2lk dGg9NjAwIGhlaWdodD0zMDAgc3R5bGU9ImJvcmRlcjo1cHggc29saWQgYmxhY2siPgorPHNjcmlw dCBzcmM9ImNhbnZhcy1saW5lV2lkdGguanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL2pz L3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvY2FudmFzLWxpbmVXaWR0aC5qcyBi L0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL2NhbnZhcy1saW5lV2lkdGguanMKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMWY0Y2RjYgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL2Zhc3QvY2FudmFzL2NhbnZhcy1saW5lV2lkdGguanMKQEAgLTAsMCArMSw0NyBAQAor Ly8gQ29tcGFyZSBzZWN0aW9ucyBvZiBhIDxjYW52YXM+IHRvIGFzc2VydCB0aGV5IGFyZSBpZGVu dGljYWwuCitmdW5jdGlvbiBjb21wYXJlUm93cyhjdHgsIHkwLCB5MSwgd2lkdGgsIGhlaWdodCkg eworICAgIHZhciBkYXRhMCA9IGN0eC5nZXRJbWFnZURhdGEoMCwgeTAsIHdpZHRoLCBoZWlnaHQp LmRhdGE7CisgICAgdmFyIGRhdGExID0gY3R4LmdldEltYWdlRGF0YSgwLCB5MSwgd2lkdGgsIGhl aWdodCkuZGF0YTsKKyAgICBmb3IgKHZhciBpID0gMCwgaWwgPSBkYXRhMC5sZW5ndGg7IGkgPCBp bDsgKytpKSB7CisgICAgICAgIGlmIChkYXRhMFtpXSAhPSBkYXRhMVtpXSkgeworICAgICAgICAg ICAgdGVzdEZhaWxlZCgiUGl4ZWwgYXQgIiArIGkgKyAiIHNob3VsZCBiZSAiICsgZGF0YTBbaV0g KyAiIGJ1dCB3YXMgIiArIGRhdGExW2ldKTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICB9 CisgICAgfQorfQorCitkZXNjcmlwdGlvbigiVGVzdCB0aGUgZGVmYXVsdCBsaW5lV2lkdGggaXMg Y29uc2lzdGVudC4iKTsKKworY3R4ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNhbnZhcyIp LmdldENvbnRleHQoIjJkIik7CisKK2N0eC5zdHJva2VTdHlsZSA9ICdibHVlJzsKKworZm9yICh2 YXIgaiA9IDA7IGogPCAzOyArK2opIHsKKyAgICBjdHguYmVnaW5QYXRoKCk7CisgICAgZm9yICh2 YXIgaSA9IDA7IGkgPCA2MDsgKytpKSB7CisgICAgICAgIHZhciB4ID0gaSAqIDEwOworICAgICAg ICB2YXIgeSA9IGogKiAxMDAgKyAzMCArIChpICUgMTUpOworICAgICAgICBpZiAoaSA9PSAwKSB7 CisgICAgICAgICAgICBjdHgubW92ZVRvKHgsIHkpOworICAgICAgICB9IGVsc2UgeworICAgICAg ICAgICAgY3R4LmxpbmVUbyh4LCB5KTsKKyAgICAgICAgfQorICAgIH0KKyAgICBjdHguc3Ryb2tl KCk7CisKKyAgICBpZiAoaiA9PSAwKSB7CisgICAgICAgIHNob3VsZEJlKCJjdHgubGluZVdpZHRo IiwgIjEiKTsKKyAgICAgICAgY3R4LmxpbmVXaWR0aCA9IGN0eC5saW5lV2lkdGg7CisgICAgICAg IHNob3VsZEJlKCJjdHgubGluZVdpZHRoIiwgIjEiKTsKKyAgICB9IGVsc2UgeworICAgICAgICBz aG91bGRCZSgiY3R4LmxpbmVXaWR0aCIsICIxIik7CisgICAgICAgIGN0eC5saW5lV2lkdGggPSAx OworICAgICAgICBzaG91bGRCZSgiY3R4LmxpbmVXaWR0aCIsICIxIik7CisgICAgfQorfQorCisv LyBNYWtlIHN1cmUgdGhhdCBhbGwgcm93cyBhcmUgaWRlbnRpY2FsLgorY29tcGFyZVJvd3MoY3R4 LCAwLCAxMDAsIDYwMCwgMTAwKTsKK2NvbXBhcmVSb3dzKGN0eCwgMCwgMjAwLCA2MDAsIDEwMCk7 CisKK3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9D aGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxN2QzMjMyLi42NTFlNTE3IDEwMDY0 NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEzIEBACisyMDA5LTA2LTA5ICBEZWFuIE1jTmFtZWUgIDxkZWFubUBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgTWFrZSBzdXJlIHRoZSBncmFwaGljcyBiYWNrZW5kcyBhcmUgaW4gc3luYyB3 aXRoIHRoZSBjYW52YXMgbGluZVdpZHRoIHN0YXRlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjYxODcKKworICAgICAgICBUZXN0OiBmYXN0L2NhbnZh cy9jYW52YXMtbGluZS13aWR0aC5odG1sCisKKyAgICAgICAgKiBodG1sL0NhbnZhc1JlbmRlcmlu Z0NvbnRleHQyRC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDYW52YXNSZW5kZXJpbmdDb250ZXh0 MkQ6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRCk6CisKIDIwMDktMDYtMDkgIFNpbW9uIEhhdXNt YW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgogCiAgICAgICAgIEZpeCB0aGUgUXQgYnVp bGQsIHRoZSB0aW1lIGZ1bmN0aW9ucyBtb3ZlZCBpbnRvIHRoZSBXVEYgbmFtZXNwYWNlLgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9odG1sL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAgYi9XZWJD b3JlL2h0bWwvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAppbmRleCBiMzIxYjQwLi4yNTQz NjllIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNw cAorKysgYi9XZWJDb3JlL2h0bWwvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcApAQCAtOTYs NiArOTYsOSBAQCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OkNhbnZhc1JlbmRlcmluZ0NvbnRl eHQyRChIVE1MQ2FudmFzRWxlbWVudCogY2FudmFzKQogICAgIDogbV9jYW52YXMoY2FudmFzKQog ICAgICwgbV9zdGF0ZVN0YWNrKDEpCiB7CisgICAgLy8gTWFrZSBzdXJlIHRoYXQgZXZlbiBpZiB0 aGUgZHJhd2luZ0NvbnRleHQoKSBoYXMgYSBkaWZmZXJlbnQgZGVmYXVsdAorICAgIC8vIHRoaWNr bmVzcywgaXQgaXMgaW4gc3luYyB3aXRoIHRoZSBjYW52YXMgdGhpY2tuZXNzLgorICAgIHNldExp bmVXaWR0aChsaW5lV2lkdGgoKSk7CiB9CiAKIHZvaWQgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJE OjpyZWYoKQo=