261786 2023-09-19 17:36:32 -0700 requestPointerLock does not cancel existing pointer capture 2023-09-21 13:37:02 -0700 1 1 1 Unclassified WebKit UI Events Safari 17 Mac (Apple Silicon) macOS 13 NEW BrowserCompat, InRadar P2 Normal --- 1 jameshoward webkit-unassigned a_protyasha jameshoward karlcow webkit-bug-importer oldest_to_newest 1978492 0 467769 jameshoward 2023-09-19 17:36:32 -0700 Created attachment 467769 Fixed version of pointerevent_pointerlock_after_pointercapture.html See attached test page, which is an adaptation of this wpt: https://github.com/WebKit/WebKit/blob/main/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerlock/pointerevent_pointerlock_after_pointercapture.html The wpt passes because it only verifies that 'lostpointercapture' occurs after sending pointerUp({button: actions.ButtonType.LEFT}) to the test driver. But the spec[^1] says that we're supposed to get lostpointercapture after 'pointerlockchange'. In my modified test, the expected console output is as follows (taken from Chrome 116.0.5845.179): lostcapture.html:24 setPointerCapture lostcapture.html:45 got_capture = true lostcapture.html:38 requestPointerLock lostcapture.html:55 Pointer lock element: div1 lostcapture.html:49 lost_capture = true lostcapture.html:30 pointerup In STP 176 (Safari 17.0, WebKit 18617.1.3.2), as well as ToT WebKit as of this writing, the output is as follows: [Log] setPointerCapture (lostcapture.html, line 24) [Log] got_capture = true (lostcapture.html, line 45) [Log] requestPointerLock (lostcapture.html, line 38) [Log] Pointer lock element: – "div1" (lostcapture.html, line 55) [Log] pointerup (lostcapture.html, line 30) [Log] lost_capture = true (lostcapture.html, line 49) Note that the last two lines are swapped comparing Chromium to WebKit. This is because Chromium is correctly cancelling pointer capture when pointer lock is engaged, but WebKit is only doing it after I lifted the left mouse button, which is unrelated to pointer lock. [^1]: https://w3c.github.io/pointerevents/#implicit-release-of-pointer-capture 1978499 1 a_protyasha 2023-09-19 17:46:03 -0700 Out of curiosity; are other browser engines passing this modified layout test? 1978500 2 a_protyasha 2023-09-19 17:47:06 -0700 (In reply to Abrar Rahman Protyasha from comment #1) > Out of curiosity; are other browser engines passing this modified layout > test? (it seems like Chromium is; and Gecko?) 1978501 3 jameshoward 2023-09-19 17:48:42 -0700 Yeah, Gecko passes too (117.0). WebKit is the only one that fails. 1979087 4 a_protyasha 2023-09-21 11:57:51 -0700 I believe this is a real bug, but without investigating too far, I can say that simply adding a call to `PointerCaptureController::pointerLockWasApplied()` in `PointerLockController::didAcquirePointerLock()` does not fix things. We should look into all possible ways to acquire pointer lock and unify the codepaths where we need to disengage pointer capture. 1979094 5 jameshoward 2023-09-21 12:16:39 -0700 Yeah I tried the same thing as well. I don’t think pointerLockWasApplied is doing what it needs to do. 1979098 6 jameshoward 2023-09-21 12:26:35 -0700 I should note that this bug isn’t a big issue for me personally. I simply found it by code inspection. 1979112 7 a_protyasha 2023-09-21 13:28:03 -0700 Sure! But is a real bug (and a potential WPT failure) nonetheless, if someone were to change the WPT to be more in-line with the spec. 1979115 8 a_protyasha 2023-09-21 13:32:11 -0700 (Thanks for catching this, btw!) 1979116 9 webkit-bug-importer 2023-09-21 13:32:42 -0700 <rdar://problem/115857922> 1979117 10 a_protyasha 2023-09-21 13:33:14 -0700 I'm importing this into our internal bug tracker, but feel free to work on this as you see fit. Just let me know if you're about to submit a patch so that we don't duplicate efforts. 1979118 11 jameshoward 2023-09-21 13:36:40 -0700 Sure if you want to take this I'd appreciate it. I can help review since I'm not familiar with the surrounding code and tests. 1979119 12 jameshoward 2023-09-21 13:37:02 -0700 (In reply to James Howard from comment #11) > Sure if you want to take this I'd appreciate it. I can help review since I'm > not familiar with the surrounding code and tests. err, I am *now* familiar with the surrounding code and tests. :) 467769 2023-09-19 17:36:32 -0700 2023-09-19 17:36:32 -0700 Fixed version of pointerevent_pointerlock_after_pointercapture.html lostcapture.html text/html 3353 jameshoward PCFkb2N0eXBlIGh0bWw+CjxodG1sPgogICAgPGhlYWQ+CiAgICAgICAgPHRpdGxlPlBvaW50ZXIg RXZlbnRzIHBvaW50ZXIgbG9jayB0ZXN0PC90aXRsZT4KICAgICAgICA8bWV0YSBuYW1lPSJ2aWV3 cG9ydCIgY29udGVudD0id2lkdGg9ZGV2aWNlLXdpZHRoIj4KICAgICAgICA8c2NyaXB0PgogICAg ICAgICAgICB2YXIgZ290X2NhcHR1cmUgPSBmYWxzZTsKICAgICAgICAgICAgdmFyIGxvc3RfY2Fw dHVyZSA9IGZhbHNlOwogICAgICAgICAgICB2YXIgbG9ja19yZXF1ZXN0ZWQgPSBmYWxzZTsKCiAg ICAgICAgICAgIGZ1bmN0aW9uIHJlc2V0VGVzdFN0YXRlKCkgewogICAgICAgICAgICB9CiAgICAg ICAgICAgIAogICAgICAgICAgICBmdW5jdGlvbiBvbl9ldmVudCh0YXJnZXQsIGV2dCwgY2FsbGJh Y2spIHsKICAgICAgICAgICAgICAgIHRhcmdldC5hZGRFdmVudExpc3RlbmVyKGV2dCwgY2FsbGJh Y2spOwogICAgICAgICAgICB9CgogICAgICAgICAgICBmdW5jdGlvbiBydW4oKSB7CiAgICAgICAg ICAgICAgICB2YXIgZGl2MSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJkaXYxIik7CiAgICAg ICAgICAgICAgICB2YXIgZGl2MiA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJkaXYyIik7Cgog ICAgICAgICAgICAgICAgb25fZXZlbnQoZGl2MSwgJ3BvaW50ZXJkb3duJywgZnVuY3Rpb24oZXZl bnQpIHsKICAgICAgICAgICAgICAgICAgICBpZiAoZXZlbnQuYnV0dG9uID09IDApIHsKICAgICAg ICAgICAgICAgICAgICAgICAgY29uc29sZS5sb2coInNldFBvaW50ZXJDYXB0dXJlIik7CiAgICAg ICAgICAgICAgICAgICAgICAgIGRpdjIuc2V0UG9pbnRlckNhcHR1cmUoZXZlbnQucG9pbnRlcklk KTsKICAgICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICB9KTsKICAgICAgICAgICAg ICAgIG9uX2V2ZW50KGRpdjEsICdwb2ludGVydXAnLCBmdW5jdGlvbihldmVudCkgewogICAgICAg ICAgICAgICAgICAgIGlmIChldmVudC5idXR0b24gPT0gMCkgewogICAgICAgICAgICAgICAgICAg ICAgICBjb25zb2xlLmxvZygicG9pbnRlcnVwIik7CiAgICAgICAgICAgICAgICAgICAgfQogICAg ICAgICAgICAgICAgfSk7CiAgICAgICAgICAgICAgICBvbl9ldmVudChkb2N1bWVudCwgJ2NvbnRl eHRtZW51JywgZnVuY3Rpb24oZXZlbnQpIHsKICAgICAgICAgICAgICAgICAgICBldmVudC5wcmV2 ZW50RGVmYXVsdCgpOwogICAgICAgICAgICAgICAgfSk7CiAgICAgICAgICAgICAgICBvbl9ldmVu dChkaXYyLCAncG9pbnRlcm1vdmUnLCBmdW5jdGlvbihldmVudCkgewogICAgICAgICAgICAgICAg ICAgIGlmIChldmVudC5idXR0b24gPT0gMiAmJiBnb3RfY2FwdHVyZSAmJiAhbG9ja19yZXF1ZXN0 ZWQpIHsKICAgICAgICAgICAgICAgICAgICAgICAgY29uc29sZS5sb2coInJlcXVlc3RQb2ludGVy TG9jayIpOwogICAgICAgICAgICAgICAgICAgICAgICBkaXYxLnJlcXVlc3RQb2ludGVyTG9jaygp OwogICAgICAgICAgICAgICAgICAgICAgICBsb2NrX3JlcXVlc3RlZCA9IHRydWU7CiAgICAgICAg ICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgfSk7CiAgICAgICAgICAgICAgICBvbl9ldmVu dChkaXYyLCAnZ290cG9pbnRlcmNhcHR1cmUnLCBmdW5jdGlvbihldmVudCkgewogICAgICAgICAg ICAgICAgICAgIGdvdF9jYXB0dXJlID0gdHJ1ZTsKICAgICAgICAgICAgICAgICAgICBjb25zb2xl LmxvZygiZ290X2NhcHR1cmUgPSB0cnVlIik7CiAgICAgICAgICAgICAgICB9KTsKICAgICAgICAg ICAgICAgIG9uX2V2ZW50KGRpdjIsICdsb3N0cG9pbnRlcmNhcHR1cmUnLCBmdW5jdGlvbihldmVu dCkgewogICAgICAgICAgICAgICAgICAgIGxvc3RfY2FwdHVyZSA9IHRydWU7CiAgICAgICAgICAg ICAgICAgICAgY29uc29sZS5sb2coImxvc3RfY2FwdHVyZSA9IHRydWUiKTsKICAgICAgICAgICAg ICAgIH0pOwogICAgICAgICAgICAgICAgb25fZXZlbnQoZG9jdW1lbnQsInBvaW50ZXJsb2NrZXJy b3IiLCBmdW5jdGlvbigpIHsKICAgICAgICAgICAgICAgICAgICBjb25zb2xlLmVycm9yKCJQb2lu dGVyIGxvY2sgZXJyb3IiKTsKICAgICAgICAgICAgICAgIH0pCiAgICAgICAgICAgICAgICBvbl9l dmVudChkb2N1bWVudCwicG9pbnRlcmxvY2tjaGFuZ2UiLCBmdW5jdGlvbihldmVudCkgewogICAg ICAgICAgICAgICAgICAgIGNvbnNvbGUubG9nKCJQb2ludGVyIGxvY2sgZWxlbWVudDogIiwgZG9j dW1lbnQucG9pbnRlckxvY2tFbGVtZW50Py5pZCk7CiAgICAgICAgICAgICAgICB9KQogICAgICAg ICAgICB9CiAgICAgICAgPC9zY3JpcHQ+CiAgICA8L2hlYWQ+CiAgICA8Ym9keSBvbmxvYWQ9InJ1 bigpIj4KICAgICAgICA8aDE+UG9pbnRlciBFdmVudHMgcG9pbnRlciBsb2NrIHRlc3Q8L2gxPgog ICAgICAgIDxoMiBpZD0icG9pbnRlclR5cGVEZXNjcmlwdGlvbiI+PC9oMj4KICAgICAgICA8aDQ+ CiAgICAgICAgICAgIFRlc3QgRGVzY3JpcHRpb246IFRoaXMgdGVzdCBjaGVja3MgdGhhdCB3ZSBy ZWxlYXNlIHRoZSBleHNpdGluZyBwb2ludGVyIGNhcHR1cmUgd2hlbiBhbnkgZWxlbWVudCBpbiB0 aGUgcGFnZSBnZXRzIGEgcG9pbnRlciBsb2NrLgogICAgICAgICAgICA8b2w+CiAgICAgICAgICAg ICAgICAgPGxpPlByZXNzIGxlZnQgYnV0dG9uIGRvd24gb24gdGhlIGdyZWVuIHJlY3RhbmdsZSBh bmQgaG9sZCBpdC48L2xpPgogICAgICAgICAgICAgICAgIDxsaT5Nb3ZlIHRoZSBtb3VzZSBpbnNp ZGUgdGhlIGdyZWVuIHJlY3RhbmdsZS48L2xpPgogICAgICAgICAgICAgICAgIDxsaT5DbGljayBy aWdodCBidXR0b24gd2hpbGUga2VlcGluZyBsZWZ0IGJ1dHRvbiBkb3duPC9saT4KICAgICAgICAg ICAgICAgICA8bGk+S2VlcCBtb3ZpbmcgdGhlIG1vdXNlIGluc2lkZSB0aGUgZ3JlZW4gcmVjdGFu Z2xlLjwvbGk+CiAgICAgICAgICAgIDwvb2w+CgogICAgICAgICAgICBUZXN0IHBhc3NlcyBpZiB0 aGUgcG9pbnRlciBjYXB0dXJlIGlzIHJlbGVhc2VkIG9uIHRoZSB5ZWxsb3cgcmVjdGFuZ2xlIHdo ZW4gdGhlIGdyZWVuIHJlY3RhbmdsZSBnZXRzIHRoZSBwb2ludGVyIGxvY2suCiAgICAgICAgPC9o ND4KICAgICAgICA8ZGl2IGlkPSJ0ZXN0Q29udGFpbmVyIj4KICAgICAgICAgICAgPGRpdiBpZD0i ZGl2MSIgc3R5bGU9IndpZHRoOjgwMHB4O2hlaWdodDoyNTBweDtiYWNrZ3JvdW5kOmdyZWVuIj48 L2Rpdj4KICAgICAgICAgICAgPGRpdiBpZD0iZGl2MiIgc3R5bGU9IndpZHRoOjgwMHB4O2hlaWdo dDoyNTBweDtiYWNrZ3JvdW5kOnllbGxvdyI+PC9kaXY+CiAgICAgICAgPC9kaXY+CiAgICAgICAg PGRpdiBjbGFzcz0ic3BhY2VyIj48L2Rpdj4KICAgIDwvYm9keT4KPC9odG1sPgo=