26177 2009-06-03 16:12:11 -0700 Add Chromium-specific constructors to Platform event classes. 2009-06-03 17:08:33 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dimich dimich dglazkov fishd oldest_to_newest 124240 0 dimich 2009-06-03 16:12:11 -0700 That fixes the build break caused by change of 'protected' data members to 'private' in PlatformMouseEvent and PlatformWheelEvent. Also it makes it possible to remove MakePlatformMouseEvent and MakePlatformWheelEvent in Chromium glue. 124242 1 30931 dimich 2009-06-03 16:13:48 -0700 Created attachment 30931 Proposed patch 124244 2 dglazkov 2009-06-03 16:27:43 -0700 Let's just turn private back into protected here. 124245 3 sam 2009-06-03 16:45:40 -0700 It seems like a gratuitous layering violation to have WebKit level classes referenced from WebCore. 124248 4 dglazkov 2009-06-03 16:49:45 -0700 (In reply to comment #3) > It seems like a gratuitous layering violation to have WebKit level classes > referenced from WebCore. > yup. 124249 5 30931 dimich 2009-06-03 16:58:16 -0700 Comment on attachment 30931 Proposed patch Removing r? Yep, that is layering violation. Will just change 'private' back to 'protected'. The better solution can come from integrating Chromium glue into WebKit tree. 124254 6 dimich 2009-06-03 17:08:33 -0700 Change to 'protected' landed as a build fix: http://trac.webkit.org/changeset/44404 30931 2009-06-03 16:13:48 -0700 2009-06-03 16:58:16 -0700 Proposed patch patch.txt text/plain 2272 dimich ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzYyNjk5Ny4uYmNhYTQ0MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0wNi0wMyAgRG1pdHJ5IFRpdG92 ICA8ZGltaWNoQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjYxNzcKKyAgICAgICAgQWRkIENocm9taXVtLXNwZWNpZmljIGNvbnN0cnVjdG9ycyB0byBQbGF0 Zm9ybSBldmVudCBjbGFzc2VzLgorICAgICAgICBUaGlzIG9ubHkgaW5jbHVkZXMgdGhlIGhlYWRl cnMsIHRoZSBpbXBsZW1lbnRhdGlvbiBpcyBpbiB0aGUgQ2hyb21pdW0gdHJlZS4KKworICAgICAg ICAqIHBsYXRmb3JtL1BsYXRmb3JtTW91c2VFdmVudC5oOgorICAgICAgICAqIHBsYXRmb3JtL1Bs YXRmb3JtV2hlZWxFdmVudC5oOgorCiAyMDA5LTA2LTAzICBBZGFtIExhbmdsZXkgIDxhZ2xAZ29v Z2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBh L1dlYkNvcmUvcGxhdGZvcm0vUGxhdGZvcm1Nb3VzZUV2ZW50LmggYi9XZWJDb3JlL3BsYXRmb3Jt L1BsYXRmb3JtTW91c2VFdmVudC5oCmluZGV4IGQzNDMxN2QuLmRiZTY4YWUgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvcGxhdGZvcm0vUGxhdGZvcm1Nb3VzZUV2ZW50LmgKKysrIGIvV2ViQ29yZS9wbGF0 Zm9ybS9QbGF0Zm9ybU1vdXNlRXZlbnQuaApAQCAtNTAsNiArNTAsMTUgQEAgdHlwZWRlZiBsb25n IExQQVJBTTsKIGNsYXNzIHd4TW91c2VFdmVudDsKICNlbmRpZgogCisjaWYgUExBVEZPUk0oQ0hS T01JVU0pCituYW1lc3BhY2UgV2ViQ29yZSB7CitjbGFzcyBXaWRnZXQ7Cit9CituYW1lc3BhY2Ug V2ViS2l0IHsKK2NsYXNzIFdlYk1vdXNlRXZlbnQ7Cit9CisjZW5kaWYKKwogbmFtZXNwYWNlIFdl YkNvcmUgewogICAgIAogICAgIC8vIFRoZXNlIGJ1dHRvbiBudW1iZXJzIG1hdGNoIHRoZSBvbmVz IHVzZWQgaW4gdGhlIERPTSBBUEksIDAgdGhyb3VnaCAyLCBleGNlcHQgZm9yIE5vQnV0dG9uIHdo aWNoIGlzbid0IHNwZWNpZmllZC4KQEAgLTEyOCw2ICsxMzcsMTAgQEAgbmFtZXNwYWNlIFdlYkNv cmUgewogICAgICAgICBQbGF0Zm9ybU1vdXNlRXZlbnQoY29uc3Qgd3hNb3VzZUV2ZW50JiwgY29u c3Qgd3hQb2ludCYgZ2xvYmFsUG9pbnQsIGludCBjbGlja0NvdW50KTsKICNlbmRpZgogCisjaWYg UExBVEZPUk0oQ0hST01JVU0pCisgICAgICAgIFBsYXRmb3JtTW91c2VFdmVudChXZWJDb3JlOjpX aWRnZXQqLCBjb25zdCBXZWJLaXQ6OldlYk1vdXNlRXZlbnQmKTsKKyNlbmRpZgorCiAgICAgcHJp dmF0ZToKICAgICAgICAgSW50UG9pbnQgbV9wb3NpdGlvbjsKICAgICAgICAgSW50UG9pbnQgbV9n bG9iYWxQb3NpdGlvbjsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vUGxhdGZvcm1XaGVl bEV2ZW50LmggYi9XZWJDb3JlL3BsYXRmb3JtL1BsYXRmb3JtV2hlZWxFdmVudC5oCmluZGV4IDNl NGY1OTcuLmI2MzFmMTQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vUGxhdGZvcm1XaGVl bEV2ZW50LmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9QbGF0Zm9ybVdoZWVsRXZlbnQuaApAQCAt NDksNiArNDksMTUgQEAgY2xhc3Mgd3hNb3VzZUV2ZW50OwogY2xhc3Mgd3hQb2ludDsKICNlbmRp ZgogCisjaWYgUExBVEZPUk0oQ0hST01JVU0pCituYW1lc3BhY2UgV2ViQ29yZSB7CitjbGFzcyBX aWRnZXQ7Cit9CituYW1lc3BhY2UgV2ViS2l0IHsKK2NsYXNzIFdlYk1vdXNlV2hlZWxFdmVudDsK K30KKyNlbmRpZgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICAvLyBXaGVlbCBldmVudHMg Y29tZSBpbiB0d28gZmxhdm9yczoKQEAgLTEwNSw2ICsxMTQsMTAgQEAgbmFtZXNwYWNlIFdlYkNv cmUgewogICAgICAgICBQbGF0Zm9ybVdoZWVsRXZlbnQoY29uc3Qgd3hNb3VzZUV2ZW50JiwgY29u c3Qgd3hQb2ludCYpOwogI2VuZGlmCiAKKyNpZiBQTEFURk9STShDSFJPTUlVTSkKKyAgICAgICAg UGxhdGZvcm1XaGVlbEV2ZW50KFdlYkNvcmU6OldpZGdldCosIGNvbnN0IFdlYktpdDo6V2ViTW91 c2VXaGVlbEV2ZW50Jik7CisjZW5kaWYKKwogICAgIHByaXZhdGU6CiAgICAgICAgIEludFBvaW50 IG1fcG9zaXRpb247CiAgICAgICAgIEludFBvaW50IG1fZ2xvYmFsUG9zaXRpb247Cg==