26172 2009-06-03 13:15:33 -0700 v8's ScriptController::evaluate should protect the Frame like the jsc version. 2009-06-03 13:33:31 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 levin levin dglazkov oldest_to_newest 124204 0 levin 2009-06-03 13:15:33 -0700 jsc;s ScriptController added refs to the Frame to protect it during certain javascript calls in the following changes: * http://trac.webkit.org/changeset/42409 * http://trac.webkit.org/changeset/42417 v8's version should have the same ref count protections to avoid similar crashes. 124205 1 30923 levin 2009-06-03 13:24:03 -0700 Created attachment 30923 Proposed fix. 124206 2 levin 2009-06-03 13:33:31 -0700 Committed as http://trac.webkit.org/changeset/44391 30923 2009-06-03 13:24:03 -0700 2009-06-03 13:25:48 -0700 Proposed fix. bug26712.txt text/plain 1754 levin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTUxZjE4MC4uMGVlNmEyMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wNi0wMyAgRGF2aWQgTGV2aW4g IDxsZXZpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgdjgncyBTY3JpcHRDb250cm9sbGVyOjpldmFsdWF0ZSBzaG91bGQgcHJv dGVjdCB0aGUgRnJhbWUgbGlrZSB0aGUganNjIHZlcnNpb24uCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjE3MgorCisgICAgICAgIFRoaXMgY2hhbmdl IGlzIHNpbXBseSBjb3B5aW5nIHByb3RlY3Rpb25zIGRvbmUgZm9yIEZyYW1lIGluIHRoZSBtZXRo b2QgCisgICAgICAgIFdlYkNvcmU6OlNjcmlwdENvbnRyb2xsZXI6OmV2YWx1YXRlIGluIHRoZSBm aWxlIGpzL1NjcmlwdENvbnRyb2xsZXIuY3BwLgorICAgICAgICAKKyAgICAgICAgKiBiaW5kaW5n cy92OC9TY3JpcHRDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdENvbnRy b2xsZXI6OmV2YWx1YXRlKToKKwogMjAwOS0wNi0wMyAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBw bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEpvaG4gU3VsbGl2YW4uCmRpZmYgLS1naXQg YS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdENvbnRyb2xsZXIuY3BwIGIvV2ViQ29yZS9iaW5k aW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNwcAppbmRleCA2ZjNmNmRlLi45ZWNmM2FiIDEwMDY0 NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdENvbnRyb2xsZXIuY3BwCisrKyBiL1dl YkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHAKQEAgLTEsNSArMSw2IEBACiAv KgogICogQ29weXJpZ2h0IChDKSAyMDA4LCAyMDA5IEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVz ZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMDkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2Vy dmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkg Zm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHBy b3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQpAQCAtMTkxLDggKzE5Miwx NSBAQCBTY3JpcHRWYWx1ZSBTY3JpcHRDb250cm9sbGVyOjpldmFsdWF0ZShjb25zdCBTY3JpcHRT b3VyY2VDb2RlJiBzb3VyY2VDb2RlKQogICAgICAgICByZXR1cm4gU2NyaXB0VmFsdWUoKTsKIAog ICAgIHY4OjpDb250ZXh0OjpTY29wZSBzY29wZShjb250ZXh0KTsKKworICAgIFJlZlB0cjxGcmFt ZT4gcHJvdGVjdChtX2ZyYW1lKTsKKwogICAgIHY4OjpMb2NhbDx2ODo6VmFsdWU+IG9iamVjdCA9 IG1fcHJveHktPmV2YWx1YXRlKHNvdXJjZUNvZGUsIDApOwogCisgICAgLy8gRXZhbHVhdGluZyB0 aGUgSmF2YVNjcmlwdCBjb3VsZCBjYXVzZSB0aGUgZnJhbWUgdG8gYmUgZGVhbGxvY2F0ZWQKKyAg ICAvLyBzbyB3ZSBzdGFydCB0aGUga2VlcCBhbGl2ZSB0aW1lciBoZXJlLgorICAgIG1fZnJhbWUt PmtlZXBBbGl2ZSgpOworCiAgICAgaWYgKG9iamVjdC5Jc0VtcHR5KCkgfHwgb2JqZWN0LT5Jc1Vu ZGVmaW5lZCgpKQogICAgICAgICByZXR1cm4gU2NyaXB0VmFsdWUoKTsKIAo=