261637 2023-09-16 02:09:49 -0700 [GTK] build breaks with -DUSE_GBM=OFF: WebCore/DMABufFormat.h: No such file or directory 2023-09-27 01:10:25 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jmason cgarcia bugs-noreply thomas.devoogdt oldest_to_newest 1977826 0 jmason 2023-09-16 02:09:49 -0700 building 2.42.0 (tarball) -DUSE_GBM=OFF Unguarded inclusion of a GBM-related header breaks compilation of two source files: webkitgtk-2.42.0/Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp:36:10: fatal error: WebCore/DMABufFormat.h: No such file or directory 36 | #include <WebCore/DMABufFormat.h> webkitgtk-2.42.0/Source/WebKit/WebProcess/WebPage/gtk/AcceleratedSurfaceDMABuf.cpp:34:10: fatal error: WebCore/DMABufFormat.h: No such file or directory 34 | #include <WebCore/DMABufFormat.h> Both source files reference one constant from DMABufFormat.h, `WebCore::DMABufFormat::Modifier::Invalid` Build completes normally when the header file and test involving the constant are removed from the source files. 1978002 1 cgarcia 2023-09-18 02:46:06 -0700 Pull request: https://github.com/WebKit/WebKit/pull/17854 1978221 2 ews-feeder 2023-09-19 01:02:28 -0700 Committed 268112@main (ba13698c64e0): <https://commits.webkit.org/268112@main> Reviewed commits have been landed. Closing PR #17854 and removing active labels. 1980410 3 thomas.devoogdt 2023-09-27 00:32:40 -0700 There is more here, also #include <epoxy/egl.h> is not a given if USE_OPENGL_OR_ES=OFF and USE_GBM=OFF. webkitgtk-2.42.0/Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp:39:10: fatal error: epoxy/egl.h: No such file or directory 39 | #include <epoxy/egl.h> | ^~~~~~~~~~~~~ 1980413 4 cgarcia 2023-09-27 00:44:53 -0700 (In reply to Thomas Devoogdt from comment #3) > There is more here, also #include <epoxy/egl.h> is not a given if > USE_OPENGL_OR_ES=OFF and USE_GBM=OFF. > > > webkitgtk-2.42.0/Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf. > cpp:39:10: fatal error: epoxy/egl.h: No such file or directory > 39 | #include <epoxy/egl.h> > | ^~~~~~~~~~~~~ That's because of USE_OPENGL_OR_ES not GBM. File a new bug report, please. 1980425 5 thomas.devoogdt 2023-09-27 01:10:25 -0700 New bug report: https://bugs.webkit.org/show_bug.cgi?id=262169.