261550 2023-09-14 00:54:30 -0700 [WebCrypto] Refactoring: Add checks for supported algorithms 2023-09-19 08:29:32 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jfernandez dpino dpino webkit-bug-importer oldest_to_newest 1977452 0 jfernandez 2023-09-14 00:54:30 -0700 We have several functions using if/then/else clauses and ternary operators to reuse the logic structure between several algorithms that use the OKP keys (eg, Curve25519 and Curve488). While it's not a big deal for Curve25519, since we are talking just about 2 algorithms, it may become a problem if we want to add support for Curve488 in the future. 1977454 1 jfernandez 2023-09-14 01:12:08 -0700 Pull request: https://github.com/WebKit/WebKit/pull/17768 1978005 2 ews-feeder 2023-09-18 03:29:48 -0700 Committed 268079@main (1fa83f2bc4ee): <https://commits.webkit.org/268079@main> Reviewed commits have been landed. Closing PR #17768 and removing active labels. 1978006 3 webkit-bug-importer 2023-09-18 03:30:16 -0700 <rdar://problem/115649943> 1978292 4 dpino 2023-09-19 08:20:42 -0700 Debian Stable and Ubuntu 20.04 build bots are failing after this patch with the following error: https://build.webkit.org/#/builders/595/builds/13369 ``` In file included from /home/buildbot/worker/GTK-Linux-64-bit-Release-Ubuntu-2004-Build/build/WebKitBuild/Release/WebCore/DerivedSources/unified-sources/UnifiedSource-44a97133-6.cpp:4: /home/buildbot/worker/GTK-Linux-64-bit-Release-Ubuntu-2004-Build/build/Source/WebCore/crypto/gcrypt/CryptoKeyOKPGCrypt.cpp: In function ‘const std::array<unsigned char, 12> WebCore::algorithmId(WebCore::CryptoKeyOKP::NamedCurve)’: /home/buildbot/worker/GTK-Linux-64-bit-Release-Ubuntu-2004-Build/build/Source/WebCore/crypto/gcrypt/CryptoKeyOKPGCrypt.cpp:260:25: error: could not convert ‘{{""}}’ from ‘<brace-enclosed initializer list>’ to ‘const std::array<unsigned char, 12>’ 260 | return { { "" } }; | ^ | | | <brace-enclosed initializer list> ninja: build stopped: subcommand failed. ``` 1978293 5 dpino 2023-09-19 08:21:22 -0700 Re-opening for pull request https://github.com/webkit/webkit/pull/17917 1978295 6 ews-feeder 2023-09-19 08:29:30 -0700 Committed 268126@main (0d052d134bf0): <https://commits.webkit.org/268126@main> Reviewed commits have been landed. Closing PR #17917 and removing active labels.