261485 2023-09-12 16:54:35 -0700 `Expected` constructor with `unexpect` tag is broken 2023-09-12 22:27:31 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jean-yves.avenard g_squelart g_squelart webkit-bug-importer oldest_to_newest 1977181 0 jean-yves.avenard 2023-09-12 16:54:35 -0700 Trying to construct an `Expected<int, double>` using `Expected(unexpect, 32.0)` gave me a compilation error "No viable conversion from 'std::experimental::unexpected<double>' to 'value_type' (aka 'int')" The code is wrong https://searchfox.org/wubkat/rev/b38121da42a0483fdb1bc13782f1c7a8059de100/Source/WTF/wtf/Expected.h#448 `template<class... Args> constexpr explicit expected(unexpected_t, Args&&... args) : base(__expected_detail::value_tag, unexpected_type(std::forward<Args>(args)...)) { }` should be: `template<class... Args> constexpr explicit expected(unexpected_t, Args&&... args) : base(__expected_detail::error_tag, unexpected_type(std::forward<Args>(args)...)) { }` 1977199 1 webkit-bug-importer 2023-09-12 18:55:21 -0700 <rdar://problem/115401559> 1977202 2 g_squelart 2023-09-12 19:09:53 -0700 Pull request: https://github.com/WebKit/WebKit/pull/17720 1977220 3 ews-feeder 2023-09-12 22:27:25 -0700 Committed 267931@main (95191e8f4045): <https://commits.webkit.org/267931@main> Reviewed commits have been landed. Closing PR #17720 and removing active labels.