26134 2009-06-02 09:17:43 -0700 REGRESSION: Crash (preceded by assertion) in InspectorController::didCommitLoad when reloading or navigating with the Inspector open 2009-06-03 09:42:22 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC All RESOLVED FIXED InRadar, Regression P2 Normal --- 1 aroben webkit-unassigned dglazkov pfeldman timothy oldest_to_newest 123991 0 aroben 2009-06-02 09:17:43 -0700 To reproduce: 1. Go to <http://webkit.org/> 2. Right-click on the page and choose "Inspect Element" 3. Reload the page, or click a link on the page You'll hit this assertion in InspectorController::didCommitLoad: ASSERT(m_mainResource && m_mainResource->isSameLoader(loader)); Continuing past this assertion would lead to a crash. Here's the backtrace (when reloading): > WebKit_debug.dll!WebCore::InspectorController::didCommitLoad(WebCore::DocumentLoader * loader=0x0e3f09b8) Line 738 + 0x49 bytes C++ WebKit_debug.dll!WebCore::FrameLoader::dispatchDidCommitLoad() Line 5208 C++ WebKit_debug.dll!WebCore::FrameLoader::receivedFirstData() Line 888 C++ WebKit_debug.dll!WebCore::FrameLoader::setEncoding(const WebCore::String & name={}, bool userChosen=false) Line 1810 C++ WebKit_debug.dll!WebFrameLoaderClient::receivedData(const char * data=0x0aa91fb8, int length=1095, const WebCore::String & textEncoding={}) Line 463 C++ WebKit_debug.dll!WebFrameLoaderClient::committedLoad(WebCore::DocumentLoader * loader=0x0e3f09b8, const char * data=0x0aa91fb8, int length=1095) Line 435 C++ WebKit_debug.dll!WebCore::FrameLoader::committedLoad(WebCore::DocumentLoader * loader=0x0e3f09b8, const char * data=0x0aa91fb8, int length=1095) Line 3639 + 0x24 bytes C++ WebKit_debug.dll!WebCore::DocumentLoader::commitLoad(const char * data=0x0aa91fb8, int length=1095) Line 362 C++ WebKit_debug.dll!WebCore::DocumentLoader::receivedData(const char * data=0x0aa91fb8, int length=1095) Line 374 C++ WebKit_debug.dll!WebCore::FrameLoader::receivedData(const char * data=0x0aa91fb8, int length=1095) Line 2458 C++ WebKit_debug.dll!WebCore::MainResourceLoader::addData(const char * data=0x0aa91fb8, int length=1095, bool allAtOnce=false) Line 149 C++ WebKit_debug.dll!WebCore::ResourceLoader::didReceiveData(const char * data=0x0aa91fb8, int length=1095, __int64 lengthReceived=1095, bool allAtOnce=false) Line 257 + 0x1b bytes C++ WebKit_debug.dll!WebCore::MainResourceLoader::didReceiveData(const char * data=0x0aa91fb8, int length=1095, __int64 lengthReceived=1095, bool allAtOnce=false) Line 361 C++ WebKit_debug.dll!WebCore::ResourceLoader::didReceiveData(WebCore::ResourceHandle * __formal=0x091f1cc8, const char * data=0x0aa91fb8, int length=1095, int lengthReceived=1095) Line 411 + 0x1f bytes C++ WebKit_debug.dll!WebCore::didReceiveData(_CFURLConnection * conn=0x0abe2fc8, const __CFData * data=0x0a5d3268, long originalLength=1095, const void * clientInfo=0x091f1cc8) Line 155 + 0x2a bytes C++ 123993 1 aroben 2009-06-02 09:18:41 -0700 <rdar://problem/6940554> 124024 2 30877 pfeldman 2009-06-02 11:48:05 -0700 Created attachment 30877 Patch with the fix 124043 3 30877 timothy 2009-06-02 13:42:26 -0700 Comment on attachment 30877 Patch with the fix Thanks for fixing this. Next time make sure to mark the patch as review? so it shows up in the review queue. 124159 4 dglazkov 2009-06-03 09:42:22 -0700 Landed as http://trac.webkit.org/changeset/44385. 30877 2009-06-02 11:48:05 -0700 2009-06-02 13:42:26 -0700 Patch with the fix bugfixes.patch text/plain 4660 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjVkZGVmZS4uOTNkMjQwYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAwOS0wNi0wMiAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAtIEZpeCBmb3IgY3Jhc2ggKHByZWNlZGVkIGJ5IGFzc2VydGlv bikgaW4gSW5zcGVjdG9yQ29udHJvbGxlcjo6ZGlkQ29tbWl0TG9hZAorICAgICAgICAgIHdoZW4g cmVsb2FkaW5nIG9yIG5hdmlnYXRpbmcgd2l0aCB0aGUgSW5zcGVjdG9yIG9wZW4uCisgICAgICAg IC0gRml4IGZvciBJbnNwZWN0b3IncyBFbGVtZW50cyBwYW5lbCBiZWluZyBlbXB0eSB3aGVuIElu c3BlY3RvciBmaXJzdCBhcHBlYXJzLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yNjEzNAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjYxMzUKKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JDb250 cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNvbnRyb2xsZXI6OnNjcmlw dE9iamVjdFJlYWR5KToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNvbnRyb2xsZXI6OmRp ZExvYWRSZXNvdXJjZUZyb21NZW1vcnlDYWNoZSk6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0 b3JDb250cm9sbGVyOjppZGVudGlmaWVyRm9ySW5pdGlhbFJlcXVlc3QpOgorICAgICAgICAoV2Vi Q29yZTo6SW5zcGVjdG9yQ29udHJvbGxlcjo6ZW5zdXJlUmVzb3VyY2VUcmFja2luZ1NldHRpbmdz TG9hZGVkKToKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5oOgorCiAy MDA5LTA2LTAxICBKZXJlbXkgT3Jsb3cgIDxqb3Jsb3dAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IERhcmluIEFkbGVyLiAgTGFuZGVkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1n aXQgYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcCBiL1dlYkNvcmUv aW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCmluZGV4IGY1MTliNGMuLjNiM2MzYjAg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCisr KyBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCkBAIC04MDcsMTEg KzgwNywxNSBAQCB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6OmRpZExvYWRSZXNvdXJjZUZyb21N ZW1vcnlDYWNoZShEb2N1bWVudExvYWRlciogbG9hZGVyLAogICAgIGlmIChtX2tub3duUmVzb3Vy Y2VzLmNvbnRhaW5zKGNhY2hlZFJlc291cmNlLT51cmwoKSkpCiAgICAgICAgIHJldHVybjsKIAot ICAgIFJlZlB0cjxJbnNwZWN0b3JSZXNvdXJjZT4gcmVzb3VyY2UgPSBJbnNwZWN0b3JSZXNvdXJj ZTo6Y3JlYXRlQ2FjaGVkKG1fbmV4dElkZW50aWZpZXItLSwgbG9hZGVyLCBjYWNoZWRSZXNvdXJj ZSk7Ci0KICAgICBBU1NFUlQobV9pbnNwZWN0ZWRQYWdlKTsKKyAgICBib29sIGlzTWFpblJlc291 cmNlID0gbG9hZGVyLT5mcmFtZSgpID09IG1faW5zcGVjdGVkUGFnZS0+bWFpbkZyYW1lKCkgJiYg Y2FjaGVkUmVzb3VyY2UtPnVybCgpID09IGxvYWRlci0+cmVxdWVzdFVSTCgpOworICAgIGVuc3Vy ZVJlc291cmNlVHJhY2tpbmdTZXR0aW5nc0xvYWRlZCgpOworICAgIGlmICghaXNNYWluUmVzb3Vy Y2UgJiYgIW1fcmVzb3VyY2VUcmFja2luZ0VuYWJsZWQpCisgICAgICAgIHJldHVybjsKKyAgICAK KyAgICBSZWZQdHI8SW5zcGVjdG9yUmVzb3VyY2U+IHJlc291cmNlID0gSW5zcGVjdG9yUmVzb3Vy Y2U6OmNyZWF0ZUNhY2hlZChtX25leHRJZGVudGlmaWVyLS0sIGxvYWRlciwgY2FjaGVkUmVzb3Vy Y2UpOwogCi0gICAgaWYgKGxvYWRlci0+ZnJhbWUoKSA9PSBtX2luc3BlY3RlZFBhZ2UtPm1haW5G cmFtZSgpICYmIGNhY2hlZFJlc291cmNlLT51cmwoKSA9PSBsb2FkZXItPnJlcXVlc3RVUkwoKSkg eworICAgIGlmIChpc01haW5SZXNvdXJjZSkgewogICAgICAgICBtX21haW5SZXNvdXJjZSA9IHJl c291cmNlOwogICAgICAgICByZXNvdXJjZS0+bWFya01haW5SZXNvdXJjZSgpOwogICAgIH0KQEAg LTgyNiwyNCArODMwLDE4IEBAIHZvaWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6aWRlbnRpZmllckZv ckluaXRpYWxSZXF1ZXN0KHVuc2lnbmVkIGxvbmcgaWRlbnRpZmllciwKIHsKICAgICBpZiAoIWVu YWJsZWQoKSkKICAgICAgICAgcmV0dXJuOworICAgIEFTU0VSVChtX2luc3BlY3RlZFBhZ2UpOwog Ci0gICAgaWYgKCFtX3Jlc291cmNlVHJhY2tpbmdTZXR0aW5nc0xvYWRlZCkgewotICAgICAgICBt X3Jlc291cmNlVHJhY2tpbmdTZXR0aW5nc0xvYWRlZCA9IHRydWU7Ci0gICAgICAgIFNldHRpbmcg cmVzb3VyY2VUcmFja2luZyA9IHNldHRpbmcocmVzb3VyY2VUcmFja2luZ0VuYWJsZWRTZXR0aW5n TmFtZSk7Ci0gICAgICAgIGlmIChyZXNvdXJjZVRyYWNraW5nLnR5cGUoKSA9PSBTZXR0aW5nOjpC b29sZWFuVHlwZSAmJiByZXNvdXJjZVRyYWNraW5nLmJvb2xlYW5WYWx1ZSgpKQotICAgICAgICAg ICAgbV9yZXNvdXJjZVRyYWNraW5nRW5hYmxlZCA9IHRydWU7Ci0gICAgfQotCi0gICAgaWYgKCFt X3Jlc291cmNlVHJhY2tpbmdFbmFibGVkKQorICAgIGJvb2wgaXNNYWluUmVzb3VyY2UgPSBtX2lu c3BlY3RlZFBhZ2UtPm1haW5GcmFtZSgpICYmIHJlcXVlc3QudXJsKCkgPT0gbG9hZGVyLT5yZXF1 ZXN0VVJMKCk7CisgICAgZW5zdXJlUmVzb3VyY2VUcmFja2luZ1NldHRpbmdzTG9hZGVkKCk7Cisg ICAgaWYgKCFpc01haW5SZXNvdXJjZSAmJiAhbV9yZXNvdXJjZVRyYWNraW5nRW5hYmxlZCkKICAg ICAgICAgcmV0dXJuOwogCiAgICAgUmVmUHRyPEluc3BlY3RvclJlc291cmNlPiByZXNvdXJjZSA9 IEluc3BlY3RvclJlc291cmNlOjpjcmVhdGUoaWRlbnRpZmllciwgbG9hZGVyKTsKIAogICAgIHJl c291cmNlLT51cGRhdGVSZXF1ZXN0KHJlcXVlc3QpOwogCi0gICAgQVNTRVJUKG1faW5zcGVjdGVk UGFnZSk7Ci0KLSAgICBpZiAobG9hZGVyLT5mcmFtZSgpID09IG1faW5zcGVjdGVkUGFnZS0+bWFp bkZyYW1lKCkgJiYgcmVxdWVzdC51cmwoKSA9PSBsb2FkZXItPnJlcXVlc3RVUkwoKSkgeworICAg IGlmIChpc01haW5SZXNvdXJjZSkgewogICAgICAgICBtX21haW5SZXNvdXJjZSA9IHJlc291cmNl OwogICAgICAgICByZXNvdXJjZS0+bWFya01haW5SZXNvdXJjZSgpOwogICAgIH0KQEAgLTEwMDcs NiArMTAwNSwxNyBAQCB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6OmRpc2FibGVSZXNvdXJjZVRy YWNraW5nKGJvb2wgYWx3YXlzKSB7CiAgICAgICAgIG1fZnJvbnRlbmQtPnJlc291cmNlVHJhY2tp bmdXYXNEaXNhYmxlZCgpOwogfQogCit2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6OmVuc3VyZVJl c291cmNlVHJhY2tpbmdTZXR0aW5nc0xvYWRlZCgpCit7CisgICAgaWYgKG1fcmVzb3VyY2VUcmFj a2luZ1NldHRpbmdzTG9hZGVkKQorICAgICAgICByZXR1cm47CisgICAgbV9yZXNvdXJjZVRyYWNr aW5nU2V0dGluZ3NMb2FkZWQgPSB0cnVlOworCisgICAgU2V0dGluZyByZXNvdXJjZVRyYWNraW5n ID0gc2V0dGluZyhyZXNvdXJjZVRyYWNraW5nRW5hYmxlZFNldHRpbmdOYW1lKTsKKyAgICBpZiAo cmVzb3VyY2VUcmFja2luZy50eXBlKCkgPT0gU2V0dGluZzo6Qm9vbGVhblR5cGUgJiYgcmVzb3Vy Y2VUcmFja2luZy5ib29sZWFuVmFsdWUoKSkKKyAgICAgICAgbV9yZXNvdXJjZVRyYWNraW5nRW5h YmxlZCA9IHRydWU7Cit9CisKICNpZiBFTkFCTEUoREFUQUJBU0UpCiB2b2lkIEluc3BlY3RvckNv bnRyb2xsZXI6OmRpZE9wZW5EYXRhYmFzZShEYXRhYmFzZSogZGF0YWJhc2UsIGNvbnN0IFN0cmlu ZyYgZG9tYWluLCBjb25zdCBTdHJpbmcmIG5hbWUsIGNvbnN0IFN0cmluZyYgdmVyc2lvbikKIHsK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuaCBiL1dl YkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuaAppbmRleCA5NmEwYThhLi5iYjJh NjFjIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmgK KysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5oCkBAIC0yMTMsNiAr MjEzLDcgQEAgcHVibGljOgogICAgIHZvaWQgZW5hYmxlUmVzb3VyY2VUcmFja2luZyhib29sIGFs d2F5cyA9IGZhbHNlKTsKICAgICB2b2lkIGRpc2FibGVSZXNvdXJjZVRyYWNraW5nKGJvb2wgYWx3 YXlzID0gZmFsc2UpOwogICAgIGJvb2wgcmVzb3VyY2VUcmFja2luZ0VuYWJsZWQoKSBjb25zdCB7 IHJldHVybiBtX3Jlc291cmNlVHJhY2tpbmdFbmFibGVkOyB9CisgICAgdm9pZCBlbnN1cmVSZXNv dXJjZVRyYWNraW5nU2V0dGluZ3NMb2FkZWQoKTsKIAogI2lmIEVOQUJMRShEQVRBQkFTRSkKICAg ICB2b2lkIGRpZE9wZW5EYXRhYmFzZShEYXRhYmFzZSosIGNvbnN0IFN0cmluZyYgZG9tYWluLCBj b25zdCBTdHJpbmcmIG5hbWUsIGNvbnN0IFN0cmluZyYgdmVyc2lvbik7Cg==